-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICDHandler initialization #30030
ICDHandler initialization #30030
Conversation
PR #30030: Size comparison from 1f9814e to 7c2302e Increases (7 builds for cc32xx, mbed, nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #30030: Size comparison from 1f9814e to 19d2c4d Increases (7 builds for cc32xx, mbed, nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #30030: Size comparison from 28de696 to 2dc3fe6 Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 02e7647 to c5abbdf Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 02e7647 to fd0e81c Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICDHandler bit has the correct structure to lay the fundations.
The request change is for the protocol bit.
PR #30030: Size comparison from b3c844b to 10ca506 Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for bl702l)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from b3c844b to 159cb86 Increases above 0.2%:
Increases (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #30030: Size comparison from b3c844b to 8249b3d Increases above 0.2%:
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from a16d6e9 to 321f299 Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 5c9d8e8 to f534a54 Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 94a6f93 to 05e6801 Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 9b64072 to f952926 Increases (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, mbed, nrfconnect, psoc6)
Decreases (6 builds for bl702, bl702l, cc32xx, psoc6)
Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, mbed, nrfconnect, psoc6)
|
PR #30030: Size comparison from 57578cc to c628353 Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl702, bl702l, cc32xx, efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30030: Size comparison from 5db749b to a54af50 Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/icd/ICDHandler.cpp
Outdated
System::PacketBufferHandle && payload) | ||
{ | ||
// TODO : Parse the checkInMsg payload and pass to ICDClientManagement via callback | ||
if (payloadHeader.HasMessageType(Protocols::SecureChannel::MsgType::ICD_CheckIn)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment, VerifyOrReturn
can be used here.
PR #30030: Size comparison from a3c5d19 to 466df7e Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
466df7e
to
c8bea78
Compare
Fixes #28232
Implements the CheckInMessage Handler class and registers unsolicited handler for handling checkin messages.