-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest docker version everywhere #29794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
examples
integrations
vscode
github
workflows
test driver
docker
labels
Oct 16, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple and
cecille
October 16, 2023 15:25
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 16, 2023 15:26
PR #29794: Size comparison from ee1f306 to 600d1ea Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #29794: Size comparison from ee1f306 to 7228e2c Full report (3 builds for cc32xx, qpg)
|
PR #29794: Size comparison from ee1f306 to aab5bf5 Full report (14 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #29794: Size comparison from ee1f306 to 69e3dd2 Increases above 0.2%:
Increases (12 builds for esp32, linux)
Decreases (5 builds for esp32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Oct 16, 2023
jmartinez-silabs
approved these changes
Oct 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Use latest docker version everywhere * Revert java tests since java will only be available in docker image 21 * Fix type checks according to linter * Fix type checks according to linter * Fix type checks according to linter * Undo some odd awk changes due to script automation * Undo some odd awk changes due to script automation * Undo version setting in dockerfile as that seems wrong * One more isinstance change to make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all CI and docs to Docker version 20.
These images should be 800MB smaller, so hopefully download and execute slightly faster and are harder to run out of space.
Changes
isinstance/is/is not
- apparently newer image has newer linterChange was generally scripted, however our existing script is kind of buggy (e.g. replaced
awk -F: ...
withawk -F:20 ...
in tlink example readmes. I undid stuff that seemed odd and even fixed some other readmes manually. Hoping CI would catch any other obvious issues.