-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install openjdk8 in chip-build-java #29795
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:install_java_in_java_image
Oct 16, 2023
Merged
Install openjdk8 in chip-build-java #29795
andy31415
merged 2 commits into
project-chip:master
from
andy31415:install_java_in_java_image
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248 and
hicklin
October 16, 2023 15:51
pullapprove
bot
requested review from
sharadb-amazon,
yufengwangca,
tecimovic,
yunhanw-google,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
October 16, 2023 15:52
andy31415
force-pushed
the
install_java_in_java_image
branch
from
October 16, 2023 16:15
5b7da63
to
32493b2
Compare
PR #29795: Size comparison from ee1f306 to 32493b2 Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Oct 16, 2023
yufengwangca
approved these changes
Oct 16, 2023
bzbarsky-apple
approved these changes
Oct 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Install openjdk8 in chip-build-java * Make sure vscode also has java installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image 20 removed java from the main image (since most platforms do not require java and it is large) ... however chip-build-java should have java ...
Changes: