-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define LastReceivedEventNumber as a global variable. #28896
Define LastReceivedEventNumber as a global variable. #28896
Conversation
Keep this variable available for tests to use. Update SMOKECO tests to use it.
PR #28896: Size comparison from 863fdb0 to be70328 Decreases (1 build for bl702l)
Full report (27 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28896: Size comparison from 863fdb0 to 15b18c2 Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Wouldn't it be better to change "LastReceivedEventNumber" to "NewEventNumber" or something like that, so that the manual "+1" can be done in the parser? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the changes in runner.py
. That was really not the right place for toying with events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming @vivien-apple's comments are addressed.
|
PR #28896: Size comparison from abe94e7 to 805b57a Increases (1 build for bl702)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Okay, thanks for the changes. |
) * Define LastReceivedEventNumber as a global variable. Keep this variable available for tests to use. Update SMOKECO tests to use it. * Restyle * Fix unit tests * Restyle * Updated based on code review feedback * Fix typo * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]>
Keep this variable available for tests to use.
Update SMOKECO tests to use it.
Fixes #28885
Testing
Validated that it passes