-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop the SetupCodePairer when StopPairing is called #28881
Merged
mergify
merged 1 commit into
project-chip:master
from
ksperling-apple:setupcodepairer-stop
Aug 28, 2023
Merged
Stop the SetupCodePairer when StopPairing is called #28881
mergify
merged 1 commit into
project-chip:master
from
ksperling-apple:setupcodepairer-stop
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28881: Size comparison from 2e59655 to a088911 Increases (3 builds for linux)
Decreases (3 builds for bl602, efr32, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 25, 2023
PR #28881: Size comparison from 2e59655 to 1639027 Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Prior to this change the SetupCodePairer was left running, and in particular its discovery timeout timer was not correctly cancelled.
ksperling-apple
force-pushed
the
setupcodepairer-stop
branch
from
August 27, 2023 22:40
1639027
to
54ae663
Compare
pullapprove
bot
requested review from
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
lazarkov and
lpbeliveau-silabs
August 27, 2023 22:41
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
younghak-hwang and
yunhanw-google
August 27, 2023 22:41
PR #28881: Size comparison from 2d5fe2c to 54ae663 Increases (3 builds for linux)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Aug 28, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Prior to this change the SetupCodePairer was left running, and in particular its discovery timeout timer was not correctly cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the SetupCodePairer was left running, and in particular its discovery timeout timer was not correctly cancelled.