Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE #28523

Merged
merged 6 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/tests/chiptest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ def _GetChipReplUnsupportedTests() -> Set[str]:
"Test_TC_DRLK_2_8.yaml", # Test fails only in chip-repl: Refer--> https://github.com/project-chip/connectedhomeip/pull/27011#issuecomment-1593339855
"Test_TC_ACE_1_6.yaml", # Test fails only in chip-repl: Refer--> https://github.com/project-chip/connectedhomeip/pull/27910#issuecomment-1632485584
"Test_TC_IDM_1_2.yaml", # chip-repl does not support AnyCommands (19/07/2023)
"Test_TC_DRLK_2_2.yaml", # chip-repl does not support EqualityCommands pseudo-cluster (08/04/2023)
"Test_TC_DRLK_2_3.yaml", # chip-repl does not support EqualityCommands pseudo-cluster (08/04/2023)
"Test_TC_DRLK_2_12.yaml", # chip-repl does not support EqualityCommands pseudo-cluster (08/04/2023)
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
"TestGroupKeyManagementCluster.yaml", # chip-repl does not support EqualityCommands (2023-08-04)
"Test_TC_S_2_2.yaml", # chip-repl does not support scenes cluster commands
"Test_TC_S_2_3.yaml", # chip-repl does not support scenes cluster commands
Expand Down
117 changes: 107 additions & 10 deletions src/app/tests/suites/certification/Test_TC_DRLK_2_12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ config:
nodeId: 0x12344321
cluster: "Door Lock"
endpoint: 1
requirePINIsTrue:
type: BOOLEAN
defaultValue: false

tests:
- label: "Wait for the commissioned device to be retrieved"
Expand Down Expand Up @@ -152,13 +155,61 @@ tests:
command: "readAttribute"
attribute: "RequirePINforRemoteOperation"
response:
value: false
saveAs: requirePINIsTrue
constraints:
type: boolean
minValue: 0
maxValue: 1

- label:
"Step 2a: TH verifies the RequirePINforRemoteOperation attribute value
is now False on the DUT"
PICS: DRLK.S.F07 && DRLK.S.F00 && DRLK.S.A0033.Write
cluster: "EqualityCommands"
command: "BooleanEquals"
arguments:
values:
- name: "Value1"
value: requirePINIsTrue
- name: "Value2"
value: false
response:
- values:
- name: "Equals"
value: true

- label: "Step 2b: Compute RequirePINforRemoteOperation"
cluster: "EqualityCommands"
command: "BooleanEquals"
arguments:
values:
- name: "Value1"
value: requirePINIsTrue
- name: "Value2"
value: false
response:
- values:
- name: "Equals"
saveAs: requirePINIsFalse
constraints:
type: boolean
minValue: 0
maxValue: 1

- label: "Step 3: TH sends Ubolt Door Command to the DUT without PINCode"
runIf: requirePINIsFalse
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000

- label: "Step 3: TH sends Ubolt Door Command to the DUT without PINCode"
runIf: requirePINIsTrue
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000
response:
error: FAILURE

- label: "Step 4: TH sends Ubolt Door Command to the DUT with PINCode"
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
Expand Down Expand Up @@ -195,19 +246,49 @@ tests:
command: "readAttribute"
attribute: "RequirePINforRemoteOperation"
response:
value: true
saveAs: requirePINIsTrue
constraints:
type: boolean
minValue: 0
maxValue: 1

- label: "Step 7: TH sends Ubolt Door Command to the DUT with valid PINCode"
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000
- label:
"Step 6a: TH verifies the RequirePINforRemoteOperation attribute value
is now True on the DUT"
PICS: DRLK.S.F07 && DRLK.S.F00 && DRLK.S.A0033.Write
cluster: "EqualityCommands"
command: "BooleanEquals"
arguments:
values:
- name: "PINCode"
value: "123456"
- name: "Value1"
value: requirePINIsTrue
- name: "Value2"
value: true
response:
- values:
- name: "Equals"
value: true

- label: "Step 6b: Compute RequirePINforRemoteOperation"
cluster: "EqualityCommands"
command: "BooleanEquals"
arguments:
values:
- name: "Value1"
value: requirePINIsTrue
- name: "Value2"
value: false
response:
- values:
- name: "Equals"
saveAs: requirePINIsFalse
constraints:
type: boolean
minValue: 0
maxValue: 1

- label:
"Step 8: TH sends Unbolt Door Command to the DUT with Invalid PINCode"
"Step 7: TH sends Unbolt Door Command to the DUT with Invalid PINCode"
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000
Expand All @@ -218,13 +299,29 @@ tests:
response:
error: FAILURE

- label: "Step 9: TH sends Unbolt Door Command to the DUT without PINCode"
- label: "Step 8: TH sends Unbolt Door Command to the DUT without PINCode"
runIf: requirePINIsTrue
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000
response:
error: FAILURE

- label: "Step 8: TH sends Unbolt Door Command to the DUT without PINCode"
runIf: requirePINIsFalse
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000

- label: "Step 9: TH sends Ubolt Door Command to the DUT with valid PINCode"
PICS: DRLK.S.C27.Rsp
command: "UnboltDoor"
timedInteractionTimeoutMs: 1000
arguments:
values:
- name: "PINCode"
value: "123456"

- label:
"Step 10: TH writes WrongCodeEntryLimit attribute value as 3 on the
DUT"
Expand Down
Loading