-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE #28523
Merged
mergify
merged 6 commits into
project-chip:master
from
jrhees-cae:drlk-2_2-2_3-2_12-fixes
Aug 10, 2023
Merged
TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE #28523
mergify
merged 6 commits into
project-chip:master
from
jrhees-cae:drlk-2_2-2_3-2_12-fixes
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration to be TRUE or FALSE - Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE - Reorder steps 7-9 to ensure subsequent test of WrongCodeEntryLimit doesn't already have existing failed entry attempts - Fix incorrect PICS (use .Write PICS) for writing WrongCodeEntryLimit and UserCodeTemporaryDisableTime Fixes project-chip#3263 Fixes project-chip#3265 Fixes project-chip#3266
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
August 4, 2023 14:15
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 4, 2023 14:16
PR #28523: Size comparison from 32ed9c5 to 8d16184 Increases (12 builds for bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc32xx, k32w, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28523: Size comparison from 32ed9c5 to 2768ed7 Increases (4 builds for bl702, cyw30739, nrfconnect, psoc6)
Decreases (3 builds for bl602, nrfconnect, psoc6)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28523: Size comparison from 32ed9c5 to bfad40a Increases (12 builds for cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc32xx, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28523: Size comparison from 32ed9c5 to 3d7bf64 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (40 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2023
andy31415
approved these changes
Aug 8, 2023
@jrhees-cae it looks like this needs merge with master and regen. |
PR #28523: Size comparison from 95e3d94 to b9afdc0 Increases (15 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (9 builds for efr32, esp32, linux, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…ration to be TRUE or FALSE (project-chip#28523) * TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE - Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE - Reorder steps 7-9 to ensure subsequent test of WrongCodeEntryLimit doesn't already have existing failed entry attempts - Fix incorrect PICS (use .Write PICS) for writing WrongCodeEntryLimit and UserCodeTemporaryDisableTime Fixes project-chip#3263 Fixes project-chip#3265 Fixes project-chip#3266 * Restyled by autopep8 * Exclude .yaml tests from CI due to use of EqualityTests pseudo-cluster * Add zap-regen'd files * Exclude .yaml tests from CI linux due to use of EqualityTests pseudo-cluster --------- Co-authored-by: Restyled.io <[email protected]>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
…ration to be TRUE or FALSE (project-chip#28523) * TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE - Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE - Reorder steps 7-9 to ensure subsequent test of WrongCodeEntryLimit doesn't already have existing failed entry attempts - Fix incorrect PICS (use .Write PICS) for writing WrongCodeEntryLimit and UserCodeTemporaryDisableTime Fixes project-chip#3263 Fixes project-chip#3265 Fixes project-chip#3266 * Restyled by autopep8 * Exclude .yaml tests from CI due to use of EqualityTests pseudo-cluster * Add zap-regen'd files * Exclude .yaml tests from CI linux due to use of EqualityTests pseudo-cluster --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC-DRLK-2.2/2.3/2.12: Modify flow to allow for RequirePINforRemoteOperation to be TRUE or FALSE
Fixes https://github.com/CHIP-Specifications/chip-test-plans/issues/3263
Fixes https://github.com/CHIP-Specifications/chip-test-plans/issues/3265
Fixes https://github.com/CHIP-Specifications/chip-test-plans/issues/3266
Accompanying PR for test plan here: https://github.com/CHIP-Specifications/chip-test-plans/pull/3277