-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mode select xml following spec pr 7151 #27249
Merged
andy31415
merged 33 commits into
project-chip:master
from
dysonltd:update_mode_select_xml_following_spec_pr_7151
Jun 16, 2023
Merged
Update mode select xml following spec pr 7151 #27249
andy31415
merged 33 commits into
project-chip:master
from
dysonltd:update_mode_select_xml_following_spec_pr_7151
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the contets to match the spec from PR 7151
…ed the relevant lists.
github-actions
bot
added
app
controller
darwin
examples
github
scripts
workflows
labels
Jun 14, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha and
franck-apple
June 14, 2023 15:54
PR #27249: Size comparison from 2926ff7 to 374eef4 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #27249: Size comparison from 5efdd31 to 8fed43d Increases (12 builds for cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6)
Decreases (21 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, qpg)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27249: Size comparison from 5efdd31 to d60d80e Increases (2 builds for cc32xx, linux)
Decreases (6 builds for bl602, bl702, cc32xx, linux)
Full report (10 builds for bl602, bl702, cc32xx, linux, mbed, qpg)
|
PR #27249: Size comparison from 82438f5 to 7ae693a Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #27249: Size comparison from b9f0476 to fb49a7c Increases (6 builds for linux, nrfconnect, psoc6)
Decreases (13 builds for bl602, bl702, cc32xx, linux, nrfconnect, psoc6)
Full report (21 builds for bl602, bl702, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27249: Size comparison from eef9529 to a9744d3 Increases (12 builds for bl602, bl702, cyw30739, linux, nrfconnect, psoc6)
Decreases (23 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
8 tasks
PR #27249: Size comparison from 83f7a2f to e62a80c Increases (12 builds for linux, nrfconnect, psoc6, telink)
Decreases (24 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mhazley
approved these changes
Jun 16, 2023
plauric
approved these changes
Jun 16, 2023
PR #27249: Size comparison from 561d7e1 to f55e993 Increases (12 builds for bl602, linux, nrfconnect, psoc6, telink)
Decreases (24 builds for bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes updates the Mode Select XMLs to match the changes made in the spec PR 7151.
This PR also fixes #27083
As a summary