-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix color conversion bug lighting-example #27065
Conversation
This commit fixes the bug of issue project-chip#27063. The used code is a copy of `[MATTERROOT]/examples/lighting-app/genio/src/ColorFormat.cpp`
PR #27065: Size comparison from 275341e to d9da036 Increases (1 build for qpg)
Decreases (1 build for cc32xx)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #27065: Size comparison from 275341e to 640e1fb Increases (8 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (12 builds for cyw30739, k32w, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There is still a bug in the calculation |
False alert. Function is working. new code: Further helping links: |
PR #27065: Size comparison from 991f367 to 640e1fb Increases (11 builds for bl602, bl702, cc32xx, k32w, psoc6, qpg, telink)
Decreases (10 builds for bl702, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27065: Size comparison from cd898c4 to 290c672 Increases (10 builds for esp32, k32w, psoc6, qpg, telink)
Decreases (12 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27065: Size comparison from 4f6923f to db30a5a Increases (9 builds for k32w, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@Sickeroni it would be awesome if this function would have a unit test for some known input & output conversions. |
Fixes #27063.
The used code is a copy of
[MATTERROOT]/examples/lighting-app/genio/src/ColorFormat.cpp
More details in the issue itself.
Short version: function expects 3 variables in a struct in the following range
Matter provides and is only capable of