You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code works somehow, but the used used colors are wrong.
Reproduction:
compile and test the lighting-example for esp32 (and every other platform using lighting-common's ColorFormat.cpp
url: examples/lighting-app/lighting-common/src/ColorFormat.cpp
Reason:
The function HsvToRgb() uses following struct as the input:
The function itself expects not "0-255, 0-255, 0-255" but "0-360, 0-100, 0-100". aka "degree for H, percent for the saturation and value". Therefore the result of the function is not what is wanted.
Bug prevalence
Every time the lighting example is used.
GitHub hash of the SDK that was being used
?
Platform
other
Platform Version(s)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Sickeroni
added a commit
to Sickeroni/connectedhomeip
that referenced
this issue
Jun 5, 2023
* Fix color conversion bug lighting-example
This commit fixes the bug of issue #27063.
The used code is a copy of `[MATTERROOT]/examples/lighting-app/genio/src/ColorFormat.cpp`
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <[email protected]>
Reproduction steps
brief
The code works somehow, but the used used colors are wrong.
Reproduction:
lighting-common
'sColorFormat.cpp
url: examples/lighting-app/lighting-common/src/ColorFormat.cpp
Reason:
The function
HsvToRgb()
uses following struct as the input:In matter-space it is correct!
The function itself expects not "0-255, 0-255, 0-255" but "0-360, 0-100, 0-100". aka "degree for H, percent for the saturation and value". Therefore the result of the function is not what is wanted.
Bug prevalence
Every time the lighting example is used.
GitHub hash of the SDK that was being used
?
Platform
other
Platform Version(s)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: