-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync refrigerator alarm xml to spec. #27030
Merged
andy31415
merged 3 commits into
project-chip:master
from
jadhavrohit924:sync/ref-alarm-xml
Jun 6, 2023
Merged
Sync refrigerator alarm xml to spec. #27030
andy31415
merged 3 commits into
project-chip:master
from
jadhavrohit924:sync/ref-alarm-xml
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Jun 2, 2023
•
edited
Loading
edited
- Problem
- Changes
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
June 2, 2023 06:36
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 2, 2023 06:36
PR #27030: Size comparison from 43cfe21 to 6e0a2d0 Increases (2 builds for esp32, telink)
Decreases (17 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Jun 2, 2023
src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml
Outdated
Show resolved
Hide resolved
jadhavrohit924
force-pushed
the
sync/ref-alarm-xml
branch
from
June 6, 2023 08:52
6e0a2d0
to
d64905a
Compare
PR #27030: Size comparison from 4f6923f to d64905a Increases (5 builds for esp32, k32w, telink)
Decreases (20 builds for bl602, bl702, cc32xx, esp32, k32w, linux, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 6, 2023
dhrishi
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.