-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server implementation of refrigerator alarm cluster #26631
Add server implementation of refrigerator alarm cluster #26631
Conversation
jadhavrohit924
commented
May 17, 2023
- Changes
b782dca
to
7ae9575
Compare
@bzbarsky-apple Please review src/app/clusters code. Will rebase this once #26572 get merged. |
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Show resolved
Hide resolved
76a81c5
to
3adb592
Compare
98315c5
to
8446431
Compare
PR #26631: Size comparison from 6b99adb to 8446431 Increases above 0.2%:
Increases (19 builds for bl702, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
8446431
to
bdad61a
Compare
PR #26631: Size comparison from 643f7aa to bdad61a Increases above 0.2%:
Increases (13 builds for bl602, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
do we want to wait for the addition of the new support attribute ? |
@jmeg-sfy I don’t understand, what is new support attribute? Is there anything going on about refrigerator alarm cluster that I am not following? |
@jadhavrohit924 there's spec churn happening. There'll be a new issue raised to track that in the SDK once merged on the spec side. I wouldn't hold this PR up waiting on that. |
Thanks @marktrayer. So if spec changes we have to change cluster definition in xml and regen zap too. I think we can have followup PRs when the spec changes gets merged. |
Co-authored-by: Boris Zbarsky <[email protected]>
bdad61a
to
0cfd28b
Compare
PR #26631: Size comparison from f5c4621 to 0cfd28b Increases above 0.2%:
Increases (22 builds for bl602, bl702, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|