Apply suggestions from code review

Co-authored-by: Boris Zbarsky <[email protected]>
project-chip · May 22, 2023 · 76a81c5 · 76a81c5
1 parent 7ae9575
commit 76a81c5
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp b/src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
@@ -32,7 +32,7 @@ using chip::Protocols::InteractionModel::Status;
 
 static Status resetHandler(app::CommandHandler * commandObj, const app::ConcreteCommandPath & commandPath, const chip::BitMask<AlarmMap> alarms, const chip::Optional<chip::BitMask<AlarmMap>> mask);
 
-static Status resetHandler(app::CommandHandler * commandObj, const app::ConcreteCommandPath & commandPath, const chip::BitMask<AlarmMap> alarms, const chip::Optional<chip::BitMask<AlarmMap>> mask)
+static Status resetHandler(CommandHandler * commandObj, const ConcreteCommandPath & commandPath, const BitMask<AlarmMap> & alarms, const Optional<BitMask<AlarmMap>> & mask)
 {
     EndpointId endpoint = commandPath.mEndpointId;
 
@@ -44,16 +44,7 @@ static Status resetHandler(app::CommandHandler * commandObj, const app::Concrete
         return Status::Failure;
     }
 
-    uint32_t alarmValue = alarms.Raw();
-    uint32_t stateValue = state.Raw();
-
-    // Flip the bits of alarms (i.e. ~alarms)
-    alarmValue = 0xFFFF ^ alarmValue;
-
-    // Reset state from active to inactive
-    stateValue = stateValue & alarmValue;
-
-    state.SetRaw(stateValue);
+    state.Clear(alarms);
     status = State::Set(endpoint, state);
     if (status != EMBER_ZCL_STATUS_SUCCESS)
     {