-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bridge app codegen to handle Optional<> #26229
Conversation
PR #26229: Size comparison from 343634a to 5171a58 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
@achaulk-goog Does this fix #25799 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a litter confuse to me, if a definition happens to be nullable and Optional ,how will this code works well. and i think every if statement had missed a return
It does not return because it chains them - a type depends on a previous type. So if both optional and nullable I expect to see |
Optional was never properly handled in codegen, this recently caused some breakages