Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bridge app codegen to handle Optional<> #26229

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

achaulk-goog
Copy link
Contributor

Optional was never properly handled in codegen, this recently caused some breakages

@github-actions
Copy link

PR #26229: Size comparison from 343634a to 5171a58

Decreases (1 build for cc32xx)
platform target config section 343634a 5171a58 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330830 20330829 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 343634a 5171a58 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20330830 20330829 -1 -0.0
.debug_line 2687904 2687904 0 0.0
.debug_loc 2838960 2838960 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042335 3042335 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466336 2466336 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428980 1428980 0 0.0

@andy31415 andy31415 enabled auto-merge (squash) April 24, 2023 19:58
@andy31415 andy31415 merged commit 20cb8dd into project-chip:master Apr 24, 2023
@bzbarsky-apple
Copy link
Contributor

@achaulk-goog Does this fix #25799 ?

Copy link
Contributor

@jinbiaochenstayhungry jinbiaochenstayhungry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a litter confuse to me, if a definition happens to be nullable and Optional ,how will this code works well. and i think every if statement had missed a return

@andy31415
Copy link
Contributor

this is a litter confuse to me, if a definition happens to be nullable and Optional ,how will this code works well. and i think every if statement had missed a return

It does not return because it chains them - a type depends on a previous type. So if both optional and nullable I expect to see ::chip::Optional<::chip::app::DataModel::Nullable<....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants