Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bridge matter idl generation #25799

Closed
mustafayuce33 opened this issue Mar 23, 2023 · 1 comment
Closed

[BUG] Bridge matter idl generation #25799

mustafayuce33 opened this issue Mar 23, 2023 · 1 comment
Labels
dynamic-bridge Issues in the dynamic-bridge example

Comments

@mustafayuce33
Copy link

Reproduction steps

If you take a look at this line;
https://github.com/project-chip/connectedhomeip/blob/master/scripts/py_matter_idl/matter_idl/generators/bridge/__init__.py#L90

It checks if the definition is nullable. But it should check if it is optional I guess. So this line should be as follows

if definition.is_optional:
        cType = '::chip::Optional<{}>'.format(cType)

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

b9d32ec

Platform

raspi

Platform Version(s)

No response

Anything else?

No response

@andy31415
Copy link
Contributor

Seems fixed by #26229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamic-bridge Issues in the dynamic-bridge example
Projects
None yet
Development

No branches or pull requests

3 participants