Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mdns client example shutdown sequence. #25889

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Shutting down the platform manager while the event loop is not fully shut down (which is the case when StopEventLoopTask is called from inside the event loop itself) is not supported.

Fixes #8917

Shutting down the platform manager while the event loop is not fully shut down
(which is the case when StopEventLoopTask is called from inside the event loop
itself) is not supported.

Fixes project-chip#8917
@github-actions
Copy link

PR #25889: Size comparison from 2aefaa6 to c2b96af

Decreases (1 build for cc32xx)
platform target config section 2aefaa6 c2b96af change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310044 20310043 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 2aefaa6 c2b96af change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645769 645769 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310044 20310043 -1 -0.0
.debug_line 2681024 2681024 0 0.0
.debug_loc 2827360 2827360 0 0.0
.debug_ranges 286352 286352 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537696 537696 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a358967 into project-chip:master Apr 4, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-mdns-example-shutdown branch April 4, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/minimal-mdns/client.cpp does shutdown weirdly
4 participants