Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/minimal-mdns/client.cpp does shutdown weirdly #8917

Closed
bzbarsky-apple opened this issue Aug 11, 2021 · 2 comments · Fixed by #25889
Closed

examples/minimal-mdns/client.cpp does shutdown weirdly #8917

bzbarsky-apple opened this issue Aug 11, 2021 · 2 comments · Fixed by #25889
Assignees
@bzbarsky-apple
Labels
V1.X

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

  1. We should probably MemoryShutdown as needed.
  2. PlatformMgr().Shutdown() needs to come after RunEventLoop returns, not from inside an event on the event loop.

Proposed Solution

Fix the above.
@bzbarsky-apple bzbarsky-apple self-assigned this Aug 11, 2021
@stale
Copy link

stale bot commented Aug 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 16, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Aug 26, 2022
@stale
Copy link

stale bot commented Mar 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 12, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 29, 2023
@bzbarsky-apple
Fix mdns client example shutdown sequence.
c2b96af 
Shutting down the platform manager while the event loop is not fully shut down
(which is the case when StopEventLoopTask is called from inside the event loop
itself) is not supported.

Fixes project-chip#8917
@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 29, 2023
Merged
bzbarsky-apple added a commit that referenced this issue Apr 4, 2023
@bzbarsky-apple
Fix mdns client example shutdown sequence. (#25889)
a358967 
Shutting down the platform manager while the event loop is not fully shut down
(which is the case when StopEventLoopTask is called from inside the event loop
itself) is not supported.

Fixes #8917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
V1.X
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mdns client example shutdown sequence. bzbarsky-apple/connectedhomeip
2 participants
@woody-apple @bzbarsky-apple