-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Implement multiple read and subscribe #25840
[Darwin] Implement multiple read and subscribe #25840
Conversation
… implement_darwin_multiple_read_subscribe
…:joonhaengHeo/connectedhomeip into implement_darwin_multiple_read_subscribe
… implement_darwin_multiple_read_subscribe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very very close! Thank you for moving the code (made it much easier to review) and adding the tests!
The only real issue here that still needs to get sorted out is the memory leak on error in the read function.
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #25840: Size comparison from 76eaffc to 3619342 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
f676acb
to
d493f31
Compare
PR #25840: Size comparison from 8809801 to d493f31 Decreases (2 builds for nrfconnect, qpg)
Full report (6 builds for mbed, nrfconnect, qpg)
|
Fast-tracking platform-specific change with platform owner review. |
PR #25840: Size comparison from 8809801 to 995d77f Full report (3 builds for mbed, qpg)
|
@joonhaengHeo Thank you for the fix, and your patience! |
Fixes #25424