Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the readAttributePaths unit tests a bit #26077

Closed
bzbarsky-apple opened this issue Apr 13, 2023 · 0 comments · Fixed by #26166
Closed

Improve the readAttributePaths unit tests a bit #26077

bzbarsky-apple opened this issue Apr 13, 2023 · 0 comments · Fixed by #26166
Assignees
@bzbarsky-apple
Labels
darwin v1.2

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Apr 13, 2023 •
edited
Loading

The tests being added in #25840 are not really carefully testing that we got the right number of attributes back, whether we are getting the right errors, etc. We should be able to test for that.
@bzbarsky-apple bzbarsky-apple self-assigned this Apr 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 19, 2023
@bzbarsky-apple
Improve the readAttributePaths tests a bit.
0181e26 
More stringent result checking, somewhat more readable code.

Fixes project-chip#26077
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 19, 2023
Merged
bzbarsky-apple added a commit that referenced this issue Apr 19, 2023
@bzbarsky-apple
Improve the readAttributePaths tests a bit. (#26166)
4766142 
* Improve the readAttributePaths tests a bit.

More stringent result checking, somewhat more readable code.

Fixes #26077

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the readAttributePaths tests a bit. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple