Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: chip_tool: clarify some parts #25818

Merged
merged 2 commits into from
Mar 29, 2023
Merged

doc: chip_tool: clarify some parts #25818

merged 2 commits into from
Mar 29, 2023

Conversation

greg-fer
Copy link
Contributor

Edited sections that were in need of updates after the previous review. These edits change the meaning of existing doc in the parts related to the interactive mode vs single-command mode, and in the part about commissioning commands.

The previous review was done in #25731

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 24, 2023
@greg-fer
Copy link
Contributor Author

@bzbarsky-apple , @kkasperczyk-no , addressed your comments from #25731 . Please check.

@github-actions
Copy link

PR #25818: Size comparison from a4a407b to 1c02604

Decreases (1 build for cc32xx)
platform target config section a4a407b 1c02604 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20229260 20229259 -1 -0.0
Full report (1 build for cc32xx)
platform target config section a4a407b 1c02604 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930266 930266 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20229260 20229259 -1 -0.0
.debug_line 2661728 2661728 0 0.0
.debug_loc 2806516 2806516 0 0.0
.debug_ranges 283400 283400 0 0.0
.debug_str 3028246 3028246 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

kkasperczyk-no
kkasperczyk-no approved these changes Mar 24, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Mar 24, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
@greg-fer greg-fer force-pushed the doc_chip_tool_guide_fixes_from_review branch from 1c02604 to 80cd284 Compare March 27, 2023 13:51
@github-actions
Copy link

PR #25818: Size comparison from 3ab9136 to b6b3ae5

Full report (1 build for cc32xx)
platform target config section 3ab9136 b6b3ae5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309905 20309905 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 27, 2023
View reviewed changes
docs/guides/chip_tool_guide.md Outdated Show resolved Hide resolved
@greg-fer greg-fer force-pushed the doc_chip_tool_guide_fixes_from_review branch from b6b3ae5 to 45521b8 Compare March 28, 2023 07:44
greg-fer and others added 2 commits March 28, 2023 15:41
@greg-fer
doc: chip_tool: clarify some parts
500e508 
Edited sections that were in need of updates after the previous review.
These edits change the meaning of existing doc in the parts related to
the interactive mode vs single-command mode, and in the part about
commissioning commands.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@restyled-commits @greg-fer
Restyled by prettier-markdown
a384aa0
@greg-fer greg-fer force-pushed the doc_chip_tool_guide_fixes_from_review branch from d628b31 to a384aa0 Compare March 28, 2023 13:41
@github-actions
Copy link

PR #25818: Size comparison from 2bcac10 to a384aa0

Full report (1 build for cc32xx)
platform target config section 2bcac10 a384aa0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309907 20309907 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

@kkasperczyk-no kkasperczyk-no merged commit a193746 into project-chip:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@greg-fer @andy31415 @bzbarsky-apple @kkasperczyk-no @restyled-commits