-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove asserts for Chip Task lock in SystemStats.cpp #25656
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jmartinez-silabs:remove_assert
Mar 13, 2023
Merged
Remove asserts for Chip Task lock in SystemStats.cpp #25656
bzbarsky-apple
merged 1 commit into
project-chip:master
from
jmartinez-silabs:remove_assert
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 13, 2023 14:11
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
March 13, 2023 14:11
bzbarsky-apple
approved these changes
Mar 13, 2023
jepenven-silabs
approved these changes
Mar 13, 2023
PR #25656: Size comparison from bc8c9ec to 4c93b91 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Mar 13, 2023
yufengwangca
approved these changes
Mar 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove asserts added in #25485 as they cause crashes for many platforms. We don't revert the PR to keep the Darwin changes that fixes a data race.
fixes #25604