Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asserts for Chip Task lock in SystemStats.cpp #25656

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jmartinez-silabs
Copy link
Member

Remove asserts added in #25485 as they cause crashes for many platforms. We don't revert the PR to keep the Darwin changes that fixes a data race.

fixes #25604

@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Mar 13, 2023
@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) March 13, 2023 14:13
@github-actions
Copy link

PR #25656: Size comparison from bc8c9ec to 4c93b91

Decreases (1 build for cc32xx)
platform target config section bc8c9ec 4c93b91 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275630 -2 -0.0
.debug_line 2660982 2660978 -4 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ec 4c93b91 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275630 -2 -0.0
.debug_line 2660982 2660978 -4 -0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 768b3dd into project-chip:master Mar 13, 2023
@jmartinez-silabs jmartinez-silabs deleted the remove_assert branch March 13, 2023 17:55
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review review - pending system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Chip Stack Protection in LwIP UDP receive path
5 participants