Revert "Use assertChipStackLockedByCurrentThread when accessing statics in src/system/SystemStats.cpp"

[tcarmelveilleux]

Causes many crashes

Reverts #25485

fixes #25604

[github-actions]

PR #25638: Size comparison from 4892a51 to e238867

Increases (3 builds for nrfconnect, qpg, telink)

platform	target	config	section	4892a51	e238867	change	% change
nrfconnect	all-clusters-minimal-app	nrf52840dk_nrf52840	text	773792	773796	4	0.0
qpg	lock-app	qpg6105+debug	(read/write)	1120092	1120100	8	0.0
			.text	567192	567200	8	0.0
telink	pump-app	tlsr9518adk80d	text	589028	589032	4	0.0

Decreases (12 builds for efr32, linux, telink)

platform	target	config	section	4892a51	e238867	change	% change
efr32	lighting-app	BRD4161A+rs9116	(read/write)	1028492	1028364	-128	-0.0
			.text	847064	846936	-128	-0.0
		BRD4187C	(read/write)	1014652	1014516	-136	-0.0
			.text	839024	838888	-136	-0.0
	lock-app	BRD4161A+wf200	(read/write)	1080876	1080740	-136	-0.0
			.text	905016	904880	-136	-0.0
	window-app	BRD4187C	(read/write)	1131396	1131268	-128	-0.0
			.text	971452	971324	-128	-0.0
linux	chip-tool-ipv6only	arm64	(read only)	12171596	1217145	-144	-0.0
			.rodata	588956	588876	-80	-0.0
			.text	9842052	9841988	-64	-0.0
	thermostat-no-ble	arm64	(read only)	2523484	2523340	-144	-0.0
			.rodata	151016	150920	-96	-0.1
			.text	2110080	2110032	-48	-0.0
telink	contact-sensor-app	tlsr9518adk80d	text	583186	583184	-2	-0.0
	lighting-app	tlsr9518adk80d	(read/write)	956200	956192	-8	-0.0
			text	663742	663740	-2	-0.0
	lock-app	tlsr9518adk80d	(read/write)	915856	915848	-8	-0.0
			text	611038	611036	-2	-0.0
	ota-requestor-app	tlsr9518adk80d	(read/write)	890476	890468	-8	-0.0
			text	607914	607912	-2	-0.0
	pump-controller-app	tlsr9518adk80d	(read/write)	854456	854448	-8	-0.0
			text	579354	579352	-2	-0.0
	temperature-measurement-app	tlsr9518adk80d	(read/write)	850188	850180	-8	-0.0
			text	574738	574736	-2	-0.0

Full report (28 builds for efr32, k32w, linux, mbed, nrfconnect, qpg, telink)

platform	target	config	section	4892a51	e238867	change	% change
efr32	lighting-app	BRD4161A+rs9116	(read/write)	1028492	1028364	-128	-0.0
			.bss	179356	179356	0	0.0
			.data	2052	2052	0	0.0
			.text	847064	846936	-128	-0.0
		BRD4187C	(read/write)	1014652	1014516	-136	-0.0
			.bss	148336	148336	0	0.0
			.data	2696	2696	0	0.0
			.text	839024	838888	-136	-0.0
	lock-app	BRD4161A+wf200	(read/write)	1080876	1080740	-136	-0.0
			.bss	173772	173772	0	0.0
			.data	2068	2068	0	0.0
			.text	905016	904880	-136	-0.0
	window-app	BRD4187C	(read/write)	1131396	1131268	-128	-0.0
			.bss	132760	132760	0	0.0
			.data	2588	2588	0	0.0
			.text	971452	971324	-128	-0.0
k32w	contact	k32w0+release	(read/write)	674176	674176	0	0.0
			.bss	65532	65532	0	0.0
			.data	2224	2224	0	0.0
			.text	575020	575020	0	0.0
	light	k32w0+release	(read/write)	673220	673220	0	0.0
			.bss	65196	65196	0	0.0
			.data	2212	2212	0	0.0
			.text	574412	574412	0	0.0
	lock	k32w0+release	(read/write)	627708	627708	0	0.0
			.bss	63268	63268	0	0.0
			.data	2136	2136	0	0.0
			.text	547288	547288	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	12171596	1217145	-144	-0.0
			(read/write)	733432	733432	0	0.0
			.bss	34296	34296	0	0.0
			.data	3008	3008	0	0.0
			.data.rel.ro	675528	675528	0	0.0
			.dynamic	560	560	0	0.0
			.got	15392	15392	0	0.0
			.init	24	24	0	0.0
			.init_array	216	216	0	0.0
			.rodata	588956	588876	-80	-0.0
			.text	9842052	9841988	-64	-0.0
	thermostat-no-ble	arm64	(read only)	2523484	2523340	-144	-0.0
			(read/write)	145240	145240	0	0.0
			.bss	56344	56344	0	0.0
			.data	1784	1784	0	0.0
			.data.rel.ro	77696	77696	0	0.0
			.dynamic	560	560	0	0.0
			.got	5368	5368	0	0.0
			.init	24	24	0	0.0
			.init_array	432	432	0	0.0
			.rodata	151016	150920	-96	-0.1
			.text	2110080	2110032	-48	-0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2468104	2468104	0	0.0
			.bss	215964	215964	0	0.0
			.data	5880	5880	0	0.0
			.text	1430748	1430748	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1173400	1173400	0	0.0
			bss	155557	155557	0	0.0
			rodata	132648	132648	0	0.0
			text	804428	804428	0	0.0
		nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1433420	1433420	0	0.0
			bss	135297	135297	0	0.0
			rodata	228700	228700	0	0.0
			text	775348	775348	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1118616	1118616	0	0.0
			bss	154713	154713	0	0.0
			rodata	109464	109464	0	0.0
			text	773792	773796	4	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1153460	1153460	0	0.0
			.bss	100076	100076	0	0.0
			.data	852	852	0	0.0
			.text	600556	600556	0	0.0
	lock-app	qpg6105+debug	(read/write)	1120092	1120100	8	0.0
			.bss	96468	96468	0	0.0
			.data	864	864	0	0.0
			.text	567192	567200	8	0.0
telink	all-clusters-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	1022528	1022528	0	0.0
			bss	98068	98068	0	0.0
			text	691700	691700	0	0.0
	all-clusters-minimal-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	957588	957588	0	0.0
			bss	97120	97120	0	0.0
			text	652862	652862	0	0.0
	contact-sensor-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	861668	861668	0	0.0
			bss	89284	89284	0	0.0
			text	583186	583184	-2	-0.0
	light-switch-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	877596	877596	0	0.0
			bss	89372	89372	0	0.0
			text	597398	597398	0	0.0
	lighting-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	956200	956192	-8	-0.0
			bss	97500	97500	0	0.0
			text	663742	663740	-2	-0.0
	lighting-app-rpc	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	1024372	1024372	0	0.0
			bss	99064	99064	0	0.0
			text	706850	706850	0	0.0
	lock-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	915856	915848	-8	-0.0
			bss	89936	89936	0	0.0
			text	611038	611036	-2	-0.0
	ota-requestor-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	890476	890468	-8	-0.0
			bss	90296	90296	0	0.0
			text	607914	607912	-2	-0.0
	pump-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	867196	867196	0	0.0
			bss	89400	89400	0	0.0
			text	589028	589032	4	0.0
	pump-controller-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	854456	854448	-8	-0.0
			bss	89200	89200	0	0.0
			text	579354	579352	-2	-0.0
	temperature-measurement-app	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	850188	850180	-8	-0.0
			bss	89060	89060	0	0.0
			text	574738	574736	-2	-0.0
	thermostat	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	881740	881740	0	0.0
			bss	90764	90764	0	0.0
			text	598926	598926	0	0.0
	window-covering	tlsr9518adk80d	(read only)	4	4	0	0.0
			(read/write)	944028	944028	0	0.0
			bss	99172	99172	0	0.0
			text	649988	649988	0	0.0

[vivien-apple]

Can you do a PR that just removes the assertion ?
We don't need to reintroduce the data race on the darwin ble code.

[jmartinez-silabs]

@vivien-apple @tcarmelveilleux I just opened #25656. It just removes the assert like you asked Viven. we close this PR