Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sticking an MTRErrorHolder in the userInfo of NSErrors. #25201

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes #22388

Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip#22388
@github-actions
Copy link

PR #25201: Size comparison from ab7bc26 to 07d196c

Increases (1 build for cc32xx)
platform target config section ab7bc26 07d196c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20254060 20254061 1 0.0
Full report (1 build for cc32xx)
platform target config section ab7bc26 07d196c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254061 1 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017470 3017470 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377598 377598 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit e64736c into project-chip:master Feb 21, 2023
@bzbarsky-apple bzbarsky-apple deleted the secure-coding-error-holder branch February 21, 2023 00:20
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…-chip#25201)

Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip#22388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matter.framework should make sure that MTRErrorHolder conforms to NSSecureCoding
2 participants