Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matter.framework should make sure that MTRErrorHolder conforms to NSSecureCoding #22388

Closed
aajain-com opened this issue Sep 3, 2022 · 1 comment · Fixed by #25201
Closed

Matter.framework should make sure that MTRErrorHolder conforms to NSSecureCoding #22388

aajain-com opened this issue Sep 3, 2022 · 1 comment · Fixed by #25201
Labels
darwin

Comments

@aajain-com
Copy link
Contributor

Problem

MTRErrorHolder does not conforms to NSSecureCoding which makes it difficult to be sent over XPC. We have seen a few crashes because of this.

Proposed Solution

Make sure that MTRErrorHolder conforms to NSSecureCoding
@woody-apple
Copy link
Contributor

woody-apple commented Sep 6, 2022 •
edited
Loading

Resolved with: #22328

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 18, 2023
@bzbarsky-apple
Implement NSSecureCoding on MTRErrorHolder.
e15ab82 
Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip#22388
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 18, 2023
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 20, 2023
@bzbarsky-apple
Stop sticking an MTRErrorHolder in the userInfo of NSErrors.
07d196c 
Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip#22388
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 20, 2023
Merged
bzbarsky-apple added a commit that referenced this issue Feb 21, 2023
@bzbarsky-apple
Stop sticking an MTRErrorHolder in the userInfo of NSErrors. (#25201)
e64736c 
Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes #22388
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Stop sticking an MTRErrorHolder in the userInfo of NSErrors. (#25201)
4d953a1 
Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip/connectedhomeip#22388
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Stop sticking an MTRErrorHolder in the userInfo of NSErrors. (#25201)
c7492c8 
Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip/connectedhomeip#22388
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Stop sticking an MTRErrorHolder in the userInfo of NSErrors. (project…
7675b08 
…-chip#25201)

Otherwise the errors we create cannot be usefully encoded/decoded.

Fixes project-chip#22388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
darwin
Projects
None yet
Milestone
No milestone
3 participants
@woody-apple @aajain-com @bzbarsky-apple