-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yaml] Remove optional keyword supports #25016
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YamlTests_RemoveOptionalSupports
Feb 13, 2023
Merged
[Yaml] Remove optional keyword supports #25016
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YamlTests_RemoveOptionalSupports
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
jtung-apple
February 13, 2023 12:51
pullapprove
bot
requested review from
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
February 13, 2023 12:51
PR #25016: Size comparison from bbfd5d6 to f23404d Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tehampson
approved these changes
Feb 13, 2023
bzbarsky-apple
approved these changes
Feb 13, 2023
vivien-apple
force-pushed
the
YamlTests_RemoveOptionalSupports
branch
from
February 13, 2023 14:33
f23404d
to
77a8fa8
Compare
PR #25016: Size comparison from 36d2d4d to 77a8fa8 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Feb 13, 2023
vivien-apple
force-pushed
the
YamlTests_RemoveOptionalSupports
branch
from
February 13, 2023 15:44
77a8fa8
to
a57ee35
Compare
PR #25016: Size comparison from 36d2d4d to a57ee35 Increases (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for bl702, cc13x2_26x2, cc32xx, linux, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
optional
seems completely unused incertification
tests.For the other yaml tests, It is used:
TestCluster.yaml
but the usage is mostly to check that an attribute isunsupported
which can be done just by checking the return error status.TestDiscovery.yaml
because the test make it hard to know what the value is and it would be easier to use a PICS code. Sooptional
is more a workaround than something else there.I suspect that in general
optional
has been completely ignored in favour of PICS code. So instead of keeping it and maintaining some complexity it seems fair to just remove it.