Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin] Use the default MRP values instead of overriding them #23301

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

Darwin MRP active timeout has been set to 2000 ms in #11493
It is unclear to me that it is still a problem or that it was not cause by the mdns collisions issues that used to exist with the darwin CI.

It causes issues since it does not only affect the test applications, but also the controller.

@github-actions
Copy link

PR #23301: Size comparison from 559c7d5 to 46c59c6

Decreases (2 builds for bl702, nrfconnect)
platform target config section 559c7d5 46c59c6 change % change
bl702 lighting-app bl702 .debug_info 37909064 37909063 -1 -0.0
.text 957578 957576 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803784 803780 -4 -0.0
Full report (12 builds for bl702, linux, mbed, nrfconnect, qpg, telink)
platform target config section 559c7d5 46c59c6 change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1189219 1189219 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506980 1506980 0 0.0
.debug_aranges 133168 133168 0 0.0
.debug_frame 486752 486752 0 0.0
.debug_info 37909064 37909063 -1 -0.0
.debug_line 5257986 5257986 0 0.0
.debug_loc 3367729 3367729 0 0.0
.debug_ranges 359568 359568 0 0.0
.debug_str 3458100 3458100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565314 565314 0 0.0
.symtab 171728 171728 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957578 957576 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284883 1284883 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644525 1644525 0 0.0
.debug_aranges 140672 140672 0 0.0
.debug_frame 512124 512124 0 0.0
.debug_info 41815678 41815678 0 0.0
.debug_line 5632517 5632517 0 0.0
.debug_loc 3560376 3560376 0 0.0
.debug_ranges 382024 382024 0 0.0
.debug_str 3854070 3854070 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624487 624487 0 0.0
.symtab 189536 189536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1031024 1031024 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10429700 10429700 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8255988 8255988 0 0.0
thermostat-no-ble arm64 (read only) 2390796 2390796 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2003408 2003408 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452200 2452200 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414844 1414844 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183659 1183659 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 815888 815888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162343 1162343 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803784 803780 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1148824 1148824 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 595924 595924 0 0.0
lock-app qpg6105+debug (read/write) 1113712 1113712 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560808 560808 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790300 790300 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553858 553858 0 0.0
lighting-app tlsr9518adk80d (read/write) 805532 805532 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 565992 565992 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804416 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 564864 564864 0 0.0

@vivien-apple vivien-apple merged commit e6454b8 into project-chip:master Oct 22, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants