Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase MRP timeouts for Darwin to accomodate CI slowness #11493

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Increase MRP timeouts for Darwin to accomodate CI slowness #11493

merged 1 commit into from
Nov 5, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

The CI for Darwin is seeing MRP timeouts and retries.

Failure during session setup

CHIP: [SC] Sent PBKDF param request�[0m
CHIP: [DL] Mdns: OnGetAddrInfo hostname:Mac-1636122098856.local.�[0m
CHIP: [DL] Mdns: OnGetAddrInfo hostname:Mac-1636122098856.local.�[0m
CHIP: [IN] Sending plaintext msg 0x7b6800000080 with MessageCounter:3069700934 to 0x0000000000000000 at monotonic time: 2576476 msec�[0m
CHIP: [EM] Retransmitted MessageCounter:3069700934 on exchange 35136i Send Cnt 1�[0m
CHIP: [IN] Sending plaintext msg 0x7b6800000080 with MessageCounter:3069700934 to 0x0000000000000000 at monotonic time: 2576733 msec�[0m
CHIP: [EM] Retransmitted MessageCounter:3069700934 on exchange 35136i Send Cnt 2�[0m
CHIP: [IN] Sending plaintext msg 0x7b6800000080 with MessageCounter:3069700934 to 0x0000000000000000 at monotonic time: 2576988 msec�[0m

Failure during data model command

CHIP: [IN] Prepared encrypted message 0x7b6800000080 to 0x0000000012344321 of type 0x8 and protocolId (0, 1) on exchange 3934i with MessageCounter:4.�[0m
CHIP: [IN] Sending encrypted msg 0x7b6800000080 with MessageCounter:4 to 0x0000000012344321 at monotonic time: 2416801 msec�[0m
CHIP: [DMG] ICR moving to [CommandSen]�[0m
CHIP: [IN] Sending encrypted msg 0x7b6800000080 with MessageCounter:4 to 0x0000000012344321 at monotonic time: 2421770 msec�[0m
CHIP: [EM] Retransmitted MessageCounter:4 on exchange 3934i Send Cnt 1�[0m
CHIP: [IN] Sending encrypted msg 0x7b6800000080 with MessageCounter:4 to 0x0000000012344321 at monotonic time: 2422027 msec�[0m
CHIP: [EM] Retransmitted MessageCounter:4 on exchange 3934i Send Cnt 2�[0m
CHIP: [IN] Sending encrypted msg 0x7b6800000080 with MessageCounter:4 to 0x0000000012344321 at monotonic time: 2422282 msec�[0m
CHIP: [EM] Retransmitted MessageCounter:4 on exchange 3934i Send Cnt 3�[0m
CHIP: [EM] Failed to Send CHIP MessageCounter:4 on exchange 3934i sendCount: 3 max retries: 3�[0m
CHIP: [DMG] Time out! failed to receive invoke command response from Exchange: 3934i�[0m
CHIP: [TOO]  ***** Test Failure: Expecting success response but got a failure response

Change overview

It seems the peer application is not able to process the packets fast enough to send acknowledgment back to the sender. This results in the sender timing out and retrying MRP exhausting all retries.

This PR ups the timeout for Darwin. The parameters needs fine tuning for Darwin platform. So added a TODO to track the changes.

Testing

Darwin CI will run the tests with the new MRP configuration.

@todo
Copy link

todo bot commented Nov 5, 2021

- Fine tune MRP default parameters for Darwin platform

connectedhomeip/src/platform/Darwin/CHIPPlatformConfig.h

Lines 109 to 115 in 384a4ab

// TODO - Fine tune MRP default parameters for Darwin platform
#define CHIP_CONFIG_MRP_DEFAULT_INITIAL_RETRY_INTERVAL (60000)
#define CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_INTERVAL (2000)
// ==================== Security Configuration Overrides ====================
#ifndef CHIP_CONFIG_MAX_APPLICATION_GROUPS

This comment was generated by todo based on a TODO comment in 384a4ab in #11493. cc @pan-apple.

@woody-apple
Copy link
Contributor

Fast tracking, given platform change by platform maintainer.

@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11493: Size comparison from c585fe6 to 384a4ab

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c585fe6 384a4ab change % change
efr32 lighting-app BRD4161A (read only) 745712 745712 0 0.0
(read/write) 115708 115708 0 0.0
.bss 113932 113932 0 0.0
.data 1772 1772 0 0.0
.text 745704 745704 0 0.0
BRD4161A+rpc (read only) 733240 733240 0 0.0
(read/write) 132324 132324 0 0.0
.bss 130436 130436 0 0.0
.data 1888 1888 0 0.0
.text 733232 733232 0 0.0
lock-app BRD4161A (read only) 724976 724976 0 0.0
(read/write) 113524 113524 0 0.0
.bss 111788 111788 0 0.0
.data 1732 1732 0 0.0
.text 724968 724968 0 0.0
window-app BRD4161A (read only) 725888 725888 0 0.0
(read/write) 113844 113844 0 0.0
.bss 112108 112108 0 0.0
.data 1736 1736 0 0.0
.text 725880 725880 0 0.0
esp32 all-clusters-app c3devkit (read only) 882750 882750 0 0.0
(read/write) 1305960 1305960 0 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198664 198664 0 0.0
.flash.text 882750 882750 0 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913583 913583 0 0.0
(read/write) 423268 423268 0 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204908 204908 0 0.0
.flash.text 913583 913583 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699408 699408 0 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613920 613920 0 0.0
lock-app k32w061+debug (read/write) 592228 592228 0 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516240 516240 0 0.0
shell k32w061+debug (read/write) 657720 657720 0 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 571128 571128 0 0.0
linux all-clusters-app debug (read only) 1704209 1704209 0 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139189 139189 0 0.0
.text 1431554 1431554 0 0.0
bridge-app debug+rpc (read only) 1292213 1292213 0 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110964 110964 0 0.0
.text 1085333 1085333 0 0.0
chip-tool debug (read only) 4509525 4509525 0 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231824 231824 0 0.0
.text 4009237 4009237 0 0.0
lighting-app debug+rpc (read only) 1553209 1553209 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129585 129585 0 0.0
.text 1290018 1290018 0 0.0
ota-provider-app debug (read only) 1251449 1251449 0 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112200 112200 0 0.0
.text 1043122 1043122 0 0.0
ota-requestor-app debug (read only) 1329745 1329745 0 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124176 124176 0 0.0
.text 1107490 1107490 0 0.0
shell debug (read only) 788105 788105 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 608690 608690 0 0.0
tv-app debug (read only) 1817185 1817185 0 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155240 155240 0 0.0
.text 1519634 1519634 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291600 2291600 0 0.0
.bss 178892 178892 0 0.0
.data 5224 5224 0 0.0
.heap 852328 852328 0 0.0
.text 1254200 1254200 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271696 2271696 0 0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1234296 1234296 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249416 2249416 0 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1212016 1212016 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861531 861531 0 0.0
bss 111256 111256 0 0.0
rodata 96892 96892 0 0.0
text 577764 577764 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823859 823859 0 0.0
bss 107608 107608 0 0.0
rodata 88068 88068 0 0.0
text 551912 551912 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786554 786554 0 0.0
bss 112632 112632 0 0.0
rodata 92148 92148 0 0.0
text 507220 507220 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838235 838235 0 0.0
bss 110292 110292 0 0.0
rodata 93260 93260 0 0.0
text 559248 559248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763534 763534 0 0.0
bss 111700 111700 0 0.0
rodata 88568 88568 0 0.0
text 488796 488796 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844331 844331 0 0.0
bss 110428 110428 0 0.0
rodata 94972 94972 0 0.0
text 563408 563408 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838091 838091 0 0.0
bss 110328 110328 0 0.0
rodata 93260 93260 0 0.0
text 558984 558984 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776139 776139 0 0.0
bss 109080 109080 0 0.0
rodata 72496 72496 0 0.0
text 519976 519976 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691178 691178 0 0.0
bss 110060 110060 0 0.0
rodata 67140 67140 0 0.0
text 440568 440568 0 0.0
p6 all-clusters-app default (read/write) 2300984 2300984 0 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1259248 1259248 0 0.0
lock-app default (read/write) 2213704 2213704 0 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171968 1171968 0 0.0
qpg lighting-app qpg6100+debug (read only) 490804 490804 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485484 485484 0 0.0
lock-app qpg6100+debug (read only) 467152 467152 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461832 461832 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663094 663094 0 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 458184 458184 0 0.0

@pan-apple pan-apple merged commit e07c381 into project-chip:master Nov 5, 2021
@todo todo bot mentioned this pull request Nov 5, 2021
Closed
@pan-apple pan-apple deleted the darwin-mrp branch November 5, 2021 21:00
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@pan-apple
Increase MRP timeouts for Darwin to accomodate CI slowness (project-c…
4508a55 
…hip#11493)
@vivien-apple vivien-apple mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
darwin fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-apple @woody-apple