Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the darwin fwk compile #2309

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

sagar-apple
Copy link
Contributor

@sagar-apple sagar-apple commented Aug 24, 2020

Problem

The Darwin CHIP.framework doesn't compile anymore.

Summary of Changes

Looks like #2273 (cc2423adc79698f0a55350e0d53d0e32600a650e) needed to also scope the vector usage in objc to std::vector.

@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@sagar-apple
Copy link
Contributor Author

@woody-apple
Copy link
Contributor

FYI I’m merging this in, it’s been delayed in review and the build is broken right now.

@woody-apple woody-apple merged commit 5a61d31 into project-chip:master Aug 26, 2020
@sagar-apple sagar-apple deleted the fix_darwin_compile branch August 26, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants