Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings -Wheader-hygiene #2273

Merged
merged 4 commits into from
Aug 22, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Aug 21, 2020

../../src/setup_payload/SetupPayloadHelper.h:31:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene]
using namespace std;

../../src/setup_payload/SetupPayloadHelper.h:31:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene]
using namespace std;
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, TY!

@woody-apple
Copy link
Contributor

@mspang build failures here, does this need rebase?

@mspang mspang changed the title Fix warnings -Wheader-hygeine Fix warnings -Wheader-hygiene Aug 21, 2020
@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,3
.debug_line,0,-57
.debug_info,0,-82


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@woody-apple woody-apple merged commit cc2423a into project-chip:master Aug 22, 2020
@mspang mspang deleted the for-chip/header-hygeine branch September 23, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants