Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 22318 - commissioner attestation delegate should be able to override success #22321

Merged
merged 8 commits into from
Sep 7, 2022
Merged

Issue 22318 - commissioner attestation delegate should be able to override success #22321

merged 8 commits into from
Sep 7, 2022

Conversation

jtung-apple
Copy link
Contributor

@jtung-apple jtung-apple commented Aug 31, 2022 •
edited
Loading

Problem

Copying problem description from issue #22318:

The SDK currently allows an attestation delegate to override an attestation failure in response to user preference. The attestation delegate should also be able to override attestation success, in case application logic decides to stop commissioning a device.

For example, if the application keeps a more up-to-date revocation list, it can use that information to reject commissioning particular devices.

For this to work, the completion callback for the delegate should include DAC/PAI/CD for the device.

Edit for justification:

  • why is this important
    This is required for third party developers on iOS to verify device attestation.

  • what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?
    Once commissioning starts, third party developers would not be able to reject attestation results, even if they have more verification information

/Edit

Change overview

  • Have DeviceAttestationDelegate add an optional override to use the new flow
  • Add a new AttestationDeviceInfo object to hold a copy of the device information
  • Have DeviceCommissioner check if the delegate uses the new flow, and always pass the device information
  • Darwin: add an optional attestation completion callback for the objc delegate protocol

Testing

  • Used darwin-framework-tool and verified the existing path still works
  • Used chip-tool and verified existing path still works
  • Tested locally with modified darwin-framework-tool that implements the new delegate callback

@jtung-apple jtung-apple self-assigned this Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited
Loading

PR #22321: Size comparison from 4e01cee to ea82080

Increases (5 builds for bl602, cc13x2_26x2, linux, telink)
platform target config section 4e01cee ea82080 change % change
bl602 lighting-app bl602+rpc .text 1084072 1084076 4 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 173044 173052 8 0.0
linux chip-tool-ipv6only arm64 (read only) 10290484 10291700 1216 0.0
.text 8143364 8144580 1216 0.0
telink light-switch-app tlsr9518adk80d text 571344 571346 2 0.0
lighting-app tlsr9518adk80d text 589456 589460 4 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 4e01cee ea82080 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 669491 669483 -8 -0.0
.text 583504 583496 -8 -0.0
Full report (20 builds for bl602, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 4e01cee ea82080 change % change
bl602 lighting-app bl602 (read/write) 1385934 1385934 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052316 1052316 0 0.0
bl602+rpc (read/write) 1431582 1431582 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084072 1084076 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675119 675119 0 0.0
(read/write) 176288 176288 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89231 89231 0 0.0
.text 585576 585576 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639823 639823 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561128 561128 0 0.0
lock-ftd LP_CC2652R7 (read only) 676171 676171 0 0.0
(read/write) 165548 165548 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598616 598616 0 0.0
lock-mtd LP_CC2652R7 (read only) 659139 659139 0 0.0
(read/write) 178268 178268 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102339 102339 0 0.0
.text 556320 556320 0 0.0
pump-app LP_CC2652R7 (read only) 684975 684975 0 0.0
(read/write) 157448 157448 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 89951 89951 0 0.0
.text 594540 594540 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669491 669483 -8 -0.0
(read/write) 173044 173052 8 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85507 85507 0 0.0
.text 583504 583496 -8 -0.0
shell LP_CC2652R7 (read only) 665914 665914 0 0.0
(read/write) 181012 181012 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85786 85786 0 0.0
.text 579812 579812 0 0.0
k32w light k32w0+release (read/write) 648108 648108 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572600 572600 0 0.0
lock k32w0+release (read/write) 705112 705112 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629148 629148 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10290484 10291700 1216 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 494708 494708 0 0.0
.text 8143364 8144580 1216 0.0
thermostat-no-ble arm64 (read only) 2361956 2361956 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141276 141276 0 0.0
.text 1982640 1982640 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454936 2454936 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417580 1417580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180835 1180835 0 0.0
bss 143641 143641 0 0.0
rodata 143380 143380 0 0.0
text 814872 814872 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160015 1160015 0 0.0
bss 142868 142868 0 0.0
rodata 134968 134968 0 0.0
text 803264 803264 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129092 1129092 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576188 576188 0 0.0
lock-app qpg6105+debug (read/write) 1100080 1100080 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547180 547180 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571344 571346 2 0.0
lighting-app tlsr9518adk80d (read/write) 830644 830644 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589456 589460 4 0.0

@jtung-apple jtung-apple force-pushed the issue-22318-additional-verification-after-attestation branch 3 times, most recently from 5f321a6 to 5a8aa81 Compare August 31, 2022 21:48
@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited
Loading

PR #22321: Size comparison from 8873a20 to 5a8aa81

Increases (6 builds for esp32, linux, telink)
platform target config section 8873a20 5a8aa81 change % change
esp32 all-clusters-app m5stack (read/write) 490804 490812 8 0.0
.flash.rodata 247344 247352 8 0.0
linux chip-tool debug (read only) 10909881 10911481 1600 0.0
.text 8824820 8826420 1600 0.0
chip-tool-ipv6only arm64 (read only) 10290484 10291700 1216 0.0
.text 8143364 8144580 1216 0.0
tv-app debug (read only) 3190409 3191961 1552 0.0
.text 2740402 2741954 1552 0.1
tv-casting-app debug (read only) 5508801 5508817 16 0.0
.text 4891986 4892002 16 0.0
telink lighting-app tlsr9518adk80d text 589456 589458 2 0.0
Decreases (3 builds for psoc6)
platform target config section 8873a20 5a8aa81 change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26708620 26708618 -2 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26445243 26445241 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 21907524 21907523 -1 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8873a20 5a8aa81 change % change
bl602 lighting-app bl602 (read/write) 1385934 1385934 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052316 1052316 0 0.0
bl602+rpc (read/write) 1431582 1431582 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084076 1084076 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675271 675271 0 0.0
(read/write) 176136 176136 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89231 89231 0 0.0
.text 585728 585728 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639975 639975 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561280 561280 0 0.0
lock-ftd LP_CC2652R7 (read only) 676323 676323 0 0.0
(read/write) 165396 165396 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598768 598768 0 0.0
lock-mtd LP_CC2652R7 (read only) 659307 659307 0 0.0
(read/write) 178100 178100 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102339 102339 0 0.0
.text 556488 556488 0 0.0
pump-app LP_CC2652R7 (read only) 684975 684975 0 0.0
(read/write) 157448 157448 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 89951 89951 0 0.0
.text 594540 594540 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669491 669491 0 0.0
(read/write) 173044 173044 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85507 85507 0 0.0
.text 583504 583504 0 0.0
shell LP_CC2652R7 (read only) 665914 665914 0 0.0
(read/write) 181012 181012 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85786 85786 0 0.0
.text 579812 579812 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586786 586786 0 0.0
.app_xip_area 463444 463444 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592538 592538 0 0.0
.app_xip_area 464412 464412 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599570 599570 0 0.0
.app_xip_area 476948 476948 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108016 1108016 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 969592 969592 0 0.0
BRD4161A+rpc (read/write) 971892 971892 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818776 818776 0 0.0
BRD4161A+rs911x (read/write) 1001708 1001708 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830456 830456 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150008 1150008 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995668 995668 0 0.0
window-app BRD4161A (read/write) 1099272 1099272 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959384 959384 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033730 1033730 0 0.0
(read/write) 1493518 1493518 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218032 218032 0 0.0
.flash.text 1033730 1033730 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086083 1086083 0 0.0
(read/write) 490804 490812 8 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247344 247352 8 0.0
.flash.text 1080699 1080699 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648108 648108 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572600 572600 0 0.0
lock k32w0+release (read/write) 705112 705112 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629148 629148 0 0.0
linux all-clusters-app debug (read only) 3043945 3043945 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275307 275307 0 0.0
.text 2589202 2589202 0 0.0
all-clusters-minimal-app debug (read only) 2879745 2879745 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275467 275467 0 0.0
.text 2427618 2427618 0 0.0
bridge-app debug+rpc (read only) 2378009 2378009 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204168 204168 0 0.0
.text 2010930 2010930 0 0.0
chip-tool debug (read only) 10909881 10911481 1600 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 564245 564245 0 0.0
.text 8824820 8826420 1600 0.0
chip-tool-ipv6only arm64 (read only) 10290484 10291700 1216 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 494708 494708 0 0.0
.text 8143364 8144580 1216 0.0
lighting-app debug+rpc (read only) 2602937 2602937 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221008 221008 0 0.0
.text 2210738 2210738 0 0.0
lock-app debug (read only) 2585905 2585905 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238000 238000 0 0.0
.text 2180962 2180962 0 0.0
ota-provider-app debug (read only) 2363161 2363161 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209976 209976 0 0.0
.text 1989426 1989426 0 0.0
ota-requestor-app debug (read only) 2528409 2528409 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216704 216704 0 0.0
.text 2138802 2138802 0 0.0
shell debug (read only) 2612249 2612249 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235410 235410 0 0.0
.text 2218130 2218130 0 0.0
thermostat-no-ble arm64 (read only) 2361956 2361956 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141276 141276 0 0.0
.text 1982640 1982640 0 0.0
tv-app debug (read only) 3190409 3191961 1552 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 259976 259976 0 0.0
.text 2740402 2741954 1552 0.1
tv-casting-app debug (read only) 5508801 5508817 16 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 344913 344913 0 0.0
.text 4891986 4892002 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454936 2454936 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417580 1417580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180835 1180835 0 0.0
bss 143641 143641 0 0.0
rodata 143380 143380 0 0.0
text 814872 814872 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160015 1160015 0 0.0
bss 142868 142868 0 0.0
rodata 134968 134968 0 0.0
text 803264 803264 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742236 1742236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221468 1221468 0 0.0
.debug_aranges 111712 111712 0 0.0
.debug_frame 372900 372900 0 0.0
.debug_info 26708620 26708618 -2 -0.0
.debug_line 3655730 3655730 0 0.0
.debug_loc 3569692 3569692 0 0.0
.debug_ranges 337616 337616 0 0.0
.debug_str 3426920 3426920 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570576 570576 0 0.0
.symtab 421488 421488 0 0.0
.text 1542464 1542464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685420 1685420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213307 1213307 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 375980 375980 0 0.0
.debug_info 26445243 26445241 -2 -0.0
.debug_line 3676246 3676246 0 0.0
.debug_loc 3557329 3557329 0 0.0
.debug_ranges 336232 336232 0 0.0
.debug_str 3415925 3415925 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535050 535050 0 0.0
.symtab 408080 408080 0 0.0
.text 1486384 1486384 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1602700 1602700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048126 1048126 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 346248 346248 0 0.0
.debug_info 21907524 21907523 -1 -0.0
.debug_line 3246711 3246711 0 0.0
.debug_loc 3255672 3255672 0 0.0
.debug_ranges 301704 301704 0 0.0
.debug_str 3221145 3221145 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468349 468349 0 0.0
.symtab 375168 375168 0 0.0
.text 1411896 1411896 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640380 1640380 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055561 1055561 0 0.0
.debug_aranges 104032 104032 0 0.0
.debug_frame 349076 349076 0 0.0
.debug_info 22287270 22287270 0 0.0
.debug_line 3255532 3255532 0 0.0
.debug_loc 3295525 3295525 0 0.0
.debug_ranges 305048 305048 0 0.0
.debug_str 3248566 3248566 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1444544 1444544 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129092 1129092 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576188 576188 0 0.0
lock-app qpg6105+debug (read/write) 1100080 1100080 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547180 547180 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571346 571346 0 0.0
lighting-app tlsr9518adk80d (read/write) 830644 830644 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589456 589458 2 0.0

@jtung-apple jtung-apple force-pushed the issue-22318-additional-verification-after-attestation branch 3 times, most recently from 3996724 to aa32f4b Compare August 31, 2022 23:23
@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited
Loading

PR #22321: Size comparison from 8873a20 to aa32f4b

Increases (9 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
platform target config section 8873a20 aa32f4b change % change
bl602 lighting-app bl602 (read/write) 1385934 1385942 8 0.0
.text 1052316 1052320 4 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 173044 173052 8 0.0
linux chip-tool debug (read only) 10909881 10911449 1568 0.0
.rodata 564245 564405 160 0.0
.text 8824820 8826228 1408 0.0
chip-tool-ipv6only arm64 (read only) 10290484 10291572 1088 0.0
.text 8143364 8144452 1088 0.0
tv-app debug (read only) 3190409 3191785 1376 0.0
.rodata 259976 260104 128 0.0
.text 2740402 2741650 1248 0.0
tv-casting-app debug (read only) 5508801 5508945 144 0.0
.rodata 344913 345041 128 0.0
.text 4891986 4892002 16 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21907524 21907525 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22287270 22287272 2 0.0
telink lighting-app tlsr9518adk80d text 589456 589458 2 0.0
Decreases (4 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
platform target config section 8873a20 aa32f4b change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 669491 669483 -8 -0.0
.text 583504 583496 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1033730 1033728 -2 -0.0
.flash.text 1033730 1033728 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803264 803260 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26708620 26708619 -1 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8873a20 aa32f4b change % change
bl602 lighting-app bl602 (read/write) 1385934 1385942 8 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052316 1052320 4 0.0
bl602+rpc (read/write) 1431582 1431582 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084076 1084076 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675271 675271 0 0.0
(read/write) 176136 176136 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89231 89231 0 0.0
.text 585728 585728 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639975 639975 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561280 561280 0 0.0
lock-ftd LP_CC2652R7 (read only) 676323 676323 0 0.0
(read/write) 165396 165396 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598768 598768 0 0.0
lock-mtd LP_CC2652R7 (read only) 659307 659307 0 0.0
(read/write) 178100 178100 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102339 102339 0 0.0
.text 556488 556488 0 0.0
pump-app LP_CC2652R7 (read only) 684975 684975 0 0.0
(read/write) 157448 157448 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 89951 89951 0 0.0
.text 594540 594540 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669491 669483 -8 -0.0
(read/write) 173044 173052 8 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85507 85507 0 0.0
.text 583504 583496 -8 -0.0
shell LP_CC2652R7 (read only) 665914 665914 0 0.0
(read/write) 181012 181012 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85786 85786 0 0.0
.text 579812 579812 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586786 586786 0 0.0
.app_xip_area 463444 463444 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592538 592538 0 0.0
.app_xip_area 464412 464412 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599570 599570 0 0.0
.app_xip_area 476948 476948 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108016 1108016 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 969592 969592 0 0.0
BRD4161A+rpc (read/write) 971892 971892 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818776 818776 0 0.0
BRD4161A+rs911x (read/write) 1001708 1001708 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830456 830456 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150008 1150008 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995668 995668 0 0.0
window-app BRD4161A (read/write) 1099272 1099272 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959384 959384 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033730 1033728 -2 -0.0
(read/write) 1493518 1493518 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218032 218032 0 0.0
.flash.text 1033730 1033728 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086083 1086083 0 0.0
(read/write) 490804 490804 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247344 247344 0 0.0
.flash.text 1080699 1080699 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648108 648108 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572600 572600 0 0.0
lock k32w0+release (read/write) 705112 705112 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629148 629148 0 0.0
linux all-clusters-app debug (read only) 3043945 3043945 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275307 275307 0 0.0
.text 2589202 2589202 0 0.0
all-clusters-minimal-app debug (read only) 2879745 2879745 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275467 275467 0 0.0
.text 2427618 2427618 0 0.0
bridge-app debug+rpc (read only) 2378009 2378009 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204168 204168 0 0.0
.text 2010930 2010930 0 0.0
chip-tool debug (read only) 10909881 10911449 1568 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 564245 564405 160 0.0
.text 8824820 8826228 1408 0.0
chip-tool-ipv6only arm64 (read only) 10290484 10291572 1088 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 494708 494708 0 0.0
.text 8143364 8144452 1088 0.0
lighting-app debug+rpc (read only) 2602937 2602937 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221008 221008 0 0.0
.text 2210738 2210738 0 0.0
lock-app debug (read only) 2585905 2585905 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238000 238000 0 0.0
.text 2180962 2180962 0 0.0
ota-provider-app debug (read only) 2363161 2363161 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209976 209976 0 0.0
.text 1989426 1989426 0 0.0
ota-requestor-app debug (read only) 2528409 2528409 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216704 216704 0 0.0
.text 2138802 2138802 0 0.0
shell debug (read only) 2612249 2612249 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235410 235410 0 0.0
.text 2218130 2218130 0 0.0
thermostat-no-ble arm64 (read only) 2361956 2361956 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141276 141276 0 0.0
.text 1982640 1982640 0 0.0
tv-app debug (read only) 3190409 3191785 1376 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 259976 260104 128 0.0
.text 2740402 2741650 1248 0.0
tv-casting-app debug (read only) 5508801 5508945 144 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 344913 345041 128 0.0
.text 4891986 4892002 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454936 2454936 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417580 1417580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180835 1180835 0 0.0
bss 143641 143641 0 0.0
rodata 143380 143380 0 0.0
text 814872 814872 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160015 1160015 0 0.0
bss 142868 142868 0 0.0
rodata 134968 134968 0 0.0
text 803264 803260 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742236 1742236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221468 1221468 0 0.0
.debug_aranges 111712 111712 0 0.0
.debug_frame 372900 372900 0 0.0
.debug_info 26708620 26708619 -1 -0.0
.debug_line 3655730 3655730 0 0.0
.debug_loc 3569692 3569692 0 0.0
.debug_ranges 337616 337616 0 0.0
.debug_str 3426920 3426920 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570576 570576 0 0.0
.symtab 421488 421488 0 0.0
.text 1542464 1542464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685420 1685420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213307 1213307 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 375980 375980 0 0.0
.debug_info 26445243 26445243 0 0.0
.debug_line 3676246 3676246 0 0.0
.debug_loc 3557329 3557329 0 0.0
.debug_ranges 336232 336232 0 0.0
.debug_str 3415925 3415925 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535050 535050 0 0.0
.symtab 408080 408080 0 0.0
.text 1486384 1486384 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1602700 1602700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048126 1048126 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 346248 346248 0 0.0
.debug_info 21907524 21907525 1 0.0
.debug_line 3246711 3246711 0 0.0
.debug_loc 3255672 3255672 0 0.0
.debug_ranges 301704 301704 0 0.0
.debug_str 3221145 3221145 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468349 468349 0 0.0
.symtab 375168 375168 0 0.0
.text 1411896 1411896 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640380 1640380 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055561 1055561 0 0.0
.debug_aranges 104032 104032 0 0.0
.debug_frame 349076 349076 0 0.0
.debug_info 22287270 22287272 2 0.0
.debug_line 3255532 3255532 0 0.0
.debug_loc 3295525 3295525 0 0.0
.debug_ranges 305048 305048 0 0.0
.debug_str 3248566 3248566 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1444544 1444544 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129092 1129092 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576188 576188 0 0.0
lock-app qpg6105+debug (read/write) 1100080 1100080 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547180 547180 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571346 571346 0 0.0
lighting-app tlsr9518adk80d (read/write) 830644 830644 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589456 589458 2 0.0

@andy31415
Copy link
Contributor

@jtung-apple - this is a core code change. Please help me triage it for 1.0 acceptance by providing 1.0 justification:

  • why is this important
  • what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?

@andy31415
Copy link
Contributor

@jtung-apple - regarding Used darwin-framework-tool to see that the existing path still works - how about chip-tool?

@jtung-apple jtung-apple force-pushed the issue-22318-additional-verification-after-attestation branch from aa32f4b to 711527f Compare September 2, 2022 17:11
@jtung-apple jtung-apple marked this pull request as ready for review September 2, 2022 17:11
@pullapprove pullapprove bot requested review from arkq and Byungjoo-Lee September 2, 2022 17:13
@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

PR #22321: Size comparison from 3522317 to 18cfcc0

Increases (10 builds for bl602, cc13x2_26x2, linux, psoc6)
platform target config section 3522317 18cfcc0 change % change
bl602 lighting-app bl602 .text 1052584 1052588 4 0.0
bl602+rpc .text 1084344 1084348 4 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676411 676419 8 0.0
.text 598864 598872 8 0.0
linux chip-tool debug (read only) 10944537 10947097 2560 0.0
.text 8854676 8857236 2560 0.0
chip-tool-ipv6only arm64 (read only) 10319348 10321332 1984 0.0
.text 8167636 8169620 1984 0.0
tv-app debug (read only) 3191689 3194233 2544 0.1
.text 2741554 2744098 2544 0.1
tv-casting-app debug (read only) 5510017 5510033 16 0.0
.text 4893042 4893058 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26715435 26715436 1 0.0
light cy8ckit_062s2_43012 .debug_info 21914340 21914341 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22294086 22294087 1 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 3522317 18cfcc0 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 165308 165300 -8 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3522317 18cfcc0 change % change
bl602 lighting-app bl602 (read/write) 1386190 1386190 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052584 1052588 4 0.0
bl602+rpc (read/write) 1431846 1431846 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084344 1084348 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675359 0 0.0
(read/write) 176048 176048 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585832 585832 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640071 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561384 561384 0 0.0
lock-ftd LP_CC2652R7 (read only) 676411 676419 8 0.0
(read/write) 165308 165300 -8 -0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598864 598872 8 0.0
lock-mtd LP_CC2652R7 (read only) 659379 659379 0 0.0
(read/write) 178028 178028 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556576 556576 0 0.0
pump-app LP_CC2652R7 (read only) 685247 685247 0 0.0
(read/write) 157176 157176 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594684 594684 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669739 0 0.0
(read/write) 172796 172796 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583632 583632 0 0.0
shell LP_CC2652R7 (read only) 666010 666010 0 0.0
(read/write) 180916 180916 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579924 579924 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586882 0 0.0
.app_xip_area 463540 463540 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592634 592634 0 0.0
.app_xip_area 464508 464508 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599818 0 0.0
.app_xip_area 477196 477196 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108528 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970104 970104 0 0.0
BRD4161A+rpc (read/write) 972188 972188 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819072 819072 0 0.0
BRD4161A+rs911x (read/write) 1002244 1002244 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830992 830992 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150304 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995964 995964 0 0.0
window-app BRD4161A (read/write) 1099768 1099768 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959880 959880 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033912 0 0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033912 1033912 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086515 1086515 0 0.0
(read/write) 490924 490924 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247464 247464 0 0.0
.flash.text 1081131 1081131 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648204 648204 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572696 572696 0 0.0
lock k32w0+release (read/write) 705216 705216 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629252 629252 0 0.0
linux all-clusters-app debug (read only) 3045113 3045113 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275435 275435 0 0.0
.text 2590242 2590242 0 0.0
all-clusters-minimal-app debug (read only) 2880897 2880897 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275595 275595 0 0.0
.text 2428642 2428642 0 0.0
bridge-app debug+rpc (read only) 2378681 2378681 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204296 204296 0 0.0
.text 2011474 2011474 0 0.0
chip-tool debug (read only) 10944537 10947097 2560 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 569045 569045 0 0.0
.text 8854676 8857236 2560 0.0
chip-tool-ipv6only arm64 (read only) 10319348 10321332 1984 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499300 499300 0 0.0
.text 8167636 8169620 1984 0.0
lighting-app debug+rpc (read only) 2604105 2604105 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221104 221104 0 0.0
.text 2211810 2211810 0 0.0
lock-app debug (read only) 2587105 2587105 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238128 238128 0 0.0
.text 2182034 2182034 0 0.0
ota-provider-app debug (read only) 2364345 2364345 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210104 210104 0 0.0
.text 1990482 1990482 0 0.0
ota-requestor-app debug (read only) 2529609 2529609 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216832 216832 0 0.0
.text 2139874 2139874 0 0.0
shell debug (read only) 2613401 2613401 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235538 235538 0 0.0
.text 2219154 2219154 0 0.0
thermostat-no-ble arm64 (read only) 2363012 2363012 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141404 141404 0 0.0
.text 1983568 1983568 0 0.0
tv-app debug (read only) 3191689 3194233 2544 0.1
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260104 260104 0 0.0
.text 2741554 2744098 2544 0.1
tv-casting-app debug (read only) 5510017 5510033 16 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 345073 345073 0 0.0
.text 4893042 4893058 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181087 0 0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 815004 815004 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160283 0 0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803400 803400 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742748 1742748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111728 111728 0 0.0
.debug_frame 372968 372968 0 0.0
.debug_info 26715435 26715436 1 0.0
.debug_line 3657402 3657402 0 0.0
.debug_loc 3573108 3573108 0 0.0
.debug_ranges 338424 338424 0 0.0
.debug_str 3427409 3427409 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570588 570588 0 0.0
.symtab 421488 421488 0 0.0
.text 1542976 1542976 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685948 1685948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111200 111200 0 0.0
.debug_frame 376048 376048 0 0.0
.debug_info 26452059 26452059 0 0.0
.debug_line 3677918 3677918 0 0.0
.debug_loc 3560745 3560745 0 0.0
.debug_ranges 337040 337040 0 0.0
.debug_str 3416414 3416414 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535062 535062 0 0.0
.symtab 408080 408080 0 0.0
.text 1486912 1486912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603196 1603196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 346316 346316 0 0.0
.debug_info 21914340 21914341 1 0.0
.debug_line 3248383 3248383 0 0.0
.debug_loc 3259088 3259088 0 0.0
.debug_ranges 302512 302512 0 0.0
.debug_str 3221680 3221680 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468361 468361 0 0.0
.symtab 375168 375168 0 0.0
.text 1412392 1412392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640892 1640892 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104048 104048 0 0.0
.debug_frame 349144 349144 0 0.0
.debug_info 22294086 22294087 1 0.0
.debug_line 3257204 3257204 0 0.0
.debug_loc 3298941 3298941 0 0.0
.debug_ranges 305856 305856 0 0.0
.debug_str 3249101 3249101 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1445056 1445056 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129172 1129172 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576268 576268 0 0.0
lock-app qpg6105+debug (read/write) 1100184 1100184 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547284 547284 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 809004 809004 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571480 571480 0 0.0
lighting-app tlsr9518adk80d (read/write) 830912 830912 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589604 589604 0 0.0

@jtung-apple
Copy link
Contributor Author

@jtung-apple - regarding Used darwin-framework-tool to see that the existing path still works - how about chip-tool?

@andy31415 I've also verified that chip-tool continues to commission correctly.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022 •
edited
Loading

PR #22321: Size comparison from 3522317 to 27ee7d2

Increases (6 builds for cc13x2_26x2)
platform target config section 3522317 27ee7d2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 176048 176072 24 0.0
lock-ftd LP_CC2652R7 (read/write) 165308 165316 8 0.0
lock-mtd LP_CC2652R7 (read/write) 178028 178052 24 0.0
pump-app LP_CC2652R7 (read/write) 157176 157200 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 172796 172828 32 0.0
shell LP_CC2652R7 (read/write) 180916 180940 24 0.0
Decreases (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6)
platform target config section 3522317 27ee7d2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675335 -24 -0.0
.text 585832 585808 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640047 -24 -0.0
.text 561384 561360 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 676411 676403 -8 -0.0
.text 598864 598856 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 659379 659355 -24 -0.0
.text 556576 556552 -24 -0.0
pump-app LP_CC2652R7 (read only) 685247 685223 -24 -0.0
.text 594684 594660 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669707 -32 -0.0
.text 583632 583600 -32 -0.0
shell LP_CC2652R7 (read only) 666010 665986 -24 -0.0
.text 579924 579900 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586866 -16 -0.0
.app_xip_area 463540 463524 -16 -0.0
lock cyw930739m2evb_01 (read/write) 592634 592610 -24 -0.0
.app_xip_area 464508 464484 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599794 -24 -0.0
.app_xip_area 477196 477172 -24 -0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108512 -16 -0.0
.text 970104 970088 -16 -0.0
BRD4161A+rpc (read/write) 972188 972156 -32 -0.0
.text 819072 819040 -32 -0.0
BRD4161A+rs911x (read/write) 1002244 1002228 -16 -0.0
.text 830992 830976 -16 -0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150288 -16 -0.0
.text 995964 995948 -16 -0.0
window-app BRD4161A (read/write) 1099768 1099752 -16 -0.0
.text 959880 959864 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033882 -30 -0.0
.flash.text 1033912 1033882 -30 -0.0
m5stack (read only) 1086515 1086503 -12 -0.0
(read/write) 490924 490916 -8 -0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081131 1081119 -12 -0.0
k32w light k32w0+release (read/write) 648204 648188 -16 -0.0
.text 572696 572680 -16 -0.0
lock k32w0+release (read/write) 705216 705184 -32 -0.0
.text 629252 629220 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181071 -16 -0.0
text 815004 814980 -24 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160251 -32 -0.0
text 803400 803372 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1742748 1742732 -16 -0.0
.debug_frame 372968 372964 -4 -0.0
.debug_info 26715435 26715282 -153 -0.0
.debug_line 3657402 3657380 -22 -0.0
.debug_loc 3573108 3573063 -45 -0.0
.debug_str 3427409 3427396 -13 -0.0
.strtab 570588 570587 -1 -0.0
.text 1542976 1542960 -16 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1685948 1685932 -16 -0.0
.debug_frame 376048 376044 -4 -0.0
.debug_info 26452059 26451905 -154 -0.0
.debug_line 3677918 3677896 -22 -0.0
.debug_loc 3560745 3560700 -45 -0.0
.debug_str 3416414 3416401 -13 -0.0
.strtab 535062 535061 -1 -0.0
.text 1486912 1486896 -16 -0.0
light cy8ckit_062s2_43012 (read/write) 1603196 1603180 -16 -0.0
.debug_frame 346316 346312 -4 -0.0
.debug_info 21914340 21914185 -155 -0.0
.debug_line 3248383 3248361 -22 -0.0
.debug_loc 3259088 3259042 -46 -0.0
.debug_str 3221680 3221667 -13 -0.0
.strtab 468361 468360 -1 -0.0
.text 1412392 1412376 -16 -0.0
lock cy8ckit_062s2_43012 (read/write) 1640892 1640876 -16 -0.0
.debug_frame 349144 349140 -4 -0.0
.debug_info 22294086 22293934 -152 -0.0
.debug_line 3257204 3257182 -22 -0.0
.debug_loc 3298941 3298895 -46 -0.0
.debug_str 3249101 3249088 -13 -0.0
.strtab 474564 474563 -1 -0.0
.text 1445056 1445040 -16 -0.0
Full report (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6)
platform target config section 3522317 27ee7d2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675335 -24 -0.0
(read/write) 176048 176072 24 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585832 585808 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640047 -24 -0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561384 561360 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 676411 676403 -8 -0.0
(read/write) 165308 165316 8 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598864 598856 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 659379 659355 -24 -0.0
(read/write) 178028 178052 24 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556576 556552 -24 -0.0
pump-app LP_CC2652R7 (read only) 685247 685223 -24 -0.0
(read/write) 157176 157200 24 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594684 594660 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669707 -32 -0.0
(read/write) 172796 172828 32 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583632 583600 -32 -0.0
shell LP_CC2652R7 (read only) 666010 665986 -24 -0.0
(read/write) 180916 180940 24 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579924 579900 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586866 -16 -0.0
.app_xip_area 463540 463524 -16 -0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592634 592610 -24 -0.0
.app_xip_area 464508 464484 -24 -0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599794 -24 -0.0
.app_xip_area 477196 477172 -24 -0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108512 -16 -0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970104 970088 -16 -0.0
BRD4161A+rpc (read/write) 972188 972156 -32 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819072 819040 -32 -0.0
BRD4161A+rs911x (read/write) 1002244 1002228 -16 -0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830992 830976 -16 -0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150288 -16 -0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995964 995948 -16 -0.0
window-app BRD4161A (read/write) 1099768 1099752 -16 -0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959880 959864 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033882 -30 -0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033912 1033882 -30 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086515 1086503 -12 -0.0
(read/write) 490924 490916 -8 -0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081131 1081119 -12 -0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648204 648188 -16 -0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572696 572680 -16 -0.0
lock k32w0+release (read/write) 705216 705184 -32 -0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629252 629220 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181071 -16 -0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 815004 814980 -24 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160251 -32 -0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803400 803372 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742748 1742732 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111728 111728 0 0.0
.debug_frame 372968 372964 -4 -0.0
.debug_info 26715435 26715282 -153 -0.0
.debug_line 3657402 3657380 -22 -0.0
.debug_loc 3573108 3573063 -45 -0.0
.debug_ranges 338424 338424 0 0.0
.debug_str 3427409 3427396 -13 -0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570588 570587 -1 -0.0
.symtab 421488 421488 0 0.0
.text 1542976 1542960 -16 -0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685948 1685932 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111200 111200 0 0.0
.debug_frame 376048 376044 -4 -0.0
.debug_info 26452059 26451905 -154 -0.0
.debug_line 3677918 3677896 -22 -0.0
.debug_loc 3560745 3560700 -45 -0.0
.debug_ranges 337040 337040 0 0.0
.debug_str 3416414 3416401 -13 -0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535062 535061 -1 -0.0
.symtab 408080 408080 0 0.0
.text 1486912 1486896 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603196 1603180 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 346316 346312 -4 -0.0
.debug_info 21914340 21914185 -155 -0.0
.debug_line 3248383 3248361 -22 -0.0
.debug_loc 3259088 3259042 -46 -0.0
.debug_ranges 302512 302512 0 0.0
.debug_str 3221680 3221667 -13 -0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468361 468360 -1 -0.0
.symtab 375168 375168 0 0.0
.text 1412392 1412376 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640892 1640876 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104048 104048 0 0.0
.debug_frame 349144 349140 -4 -0.0
.debug_info 22294086 22293934 -152 -0.0
.debug_line 3257204 3257182 -22 -0.0
.debug_loc 3298941 3298895 -46 -0.0
.debug_ranges 305856 305856 0 0.0
.debug_str 3249101 3249088 -13 -0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474563 -1 -0.0
.symtab 378352 378352 0 0.0
.text 1445056 1445040 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0

@jtung-apple
Copy link
Contributor Author

@jtung-apple - this is a core code change. Please help me triage it for 1.0 acceptance by providing 1.0 justification:

  • why is this important
  • what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?

@andy31415

@jtung-apple
Copy link
Contributor Author

@jtung-apple - this is a core code change. Please help me triage it for 1.0 acceptance by providing 1.0 justification:

  • why is this important
  • what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?

@andy31415

  • why is this important
    This is required for third party developers on iOS to verify device attestation.

  • what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?
    Once commissioning starts, third party developers would not be able to reject attestation results, even if they have more verification information

@jtung-apple jtung-apple linked an issue Sep 6, 2022 that may be closed by this pull request
[1.0] Commissioner attestation delegate should be able to override success #22423
Closed
@jtung-apple
Copy link
Contributor Author

@andy31415 For bookkeeping - I've filed new Issue #22423 with template and copied justification over and linked to this PR.

bzbarsky-apple
bzbarsky-apple reviewed Sep 6, 2022
View reviewed changes
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.h Outdated Show resolved Hide resolved
src/credentials/attestation_verifier/DeviceAttestationVerifier.cpp Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceAttestationDelegateBridge.h Outdated Show resolved Hide resolved
@woody-apple
Copy link
Contributor

@jtung-apple thanks for the new issue template, approving.

@woody-apple woody-apple merged commit 89f5c8a into project-chip:master Sep 7, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@jtung-apple @bzbarsky-apple @isiu-apple
Issue 22318 - commissioner attestation delegate should be able to ove…
f3475b9 
…rride success (project-chip#22321)

* Issue 22318 - commissioner attestation delegate should be able to override success

* restyled

* hook up darwin delegate when commissioning

* restyled

* header doc and nullability fix for darwin MTRDeviceAttestationDelegate

* NULL check before memcpy

Co-authored-by: Boris Zbarsky <[email protected]>

* Declare const member as const in MTRDeviceAttestationDelegateBridge

Co-authored-by: Boris Zbarsky <[email protected]>

* Address review comments

Co-authored-by: Boris Zbarsky <[email protected]>
@panliming-tuya panliming-tuya mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple Awaiting requested review from woody-apple

@emargolis emargolis Awaiting requested review from emargolis

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@anush-apple anush-apple Awaiting requested review from anush-apple

Assignees

@jtung-apple jtung-apple

Labels
controller darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.0] Commissioner attestation delegate should be able to override success
6 participants
@jtung-apple @andy31415 @woody-apple @tcarmelveilleux @anush-apple @bzbarsky-apple