Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commissioner should allow attestation delegate to override attestation success #22318

Closed
jtung-apple opened this issue Aug 31, 2022 · 1 comment
Assignees

Comments

@jtung-apple
Copy link
Contributor

Problem

The SDK currently allows an attestation delegate to override an attestation failure in response to user preference. The attestation delegate should also be able to override attestation success, in case application logic decides to stop commissioning a device.

For example, if the application keeps a more up-to-date revocation list, it can use that information to reject commissioning particular devices.

For this to work, the completion callback for the delegate should include DAC/PAI/CD for the device.

Proposed Solution

  • Have DeviceAttestationDelegate add an optional override to use the new flow
  • Add a new AttestationDeviceInfo object to hold a copy of the device information
  • Have DeviceCommissioner check if the delegate uses the new flow, and always pass the device information
  • Darwin: add an optional attestation completion callback for the objc delegate protocol
@jtung-apple
Copy link
Contributor Author

Closing this - there is new templated Issue to replace this one: #22423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant