Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when last controller is shut down while a PASE session is outstanding. #22282

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix crashes when last controller is shut down while a PASE session is outstanding. #22282

merged 1 commit into from
Aug 31, 2022

Commits on Aug 31, 2022

  1. Fix crashes when last controller is shut down while a PASE session is… 

    … outstanding.

Commissioner shutdown shuts down the CASE sessions associated with the
commissioner, but not the PASE sessions.  Those sessions then get shut down
much later in shutdown, at which point various objects that are needed to
handle the shutdown are no longer present.

The fix is to shut down PASE sessions when we destroy CommissioneeDeviceProxy
objects, and ensure that we always destroy CommissioneeDeviceProxy via
ReleaseCommissioneeDevice, so we don't end up with dangling pointers to the
objects.

Fixes project-chip#16440

Should vastly improve, if not completely fix,
project-chip#20880
    @bzbarsky-apple
    bzbarsky-apple committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    11830ff View commit details
    Browse the repository at this point in the history