Fix crashes when last controller is shut down while a PASE session is outstanding. #22282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
yunhanw-google
approved these changes
Aug 30, 2022
|
Acceptable for 1.0: fixing a crash |
|
PR #22282: Size comparison from bb1ebba to 10ef2d5 Increases (5 builds for cc13x2_26x2, efr32, esp32, linux)
Decreases (8 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… outstanding. Commissioner shutdown shuts down the CASE sessions associated with the commissioner, but not the PASE sessions. Those sessions then get shut down much later in shutdown, at which point various objects that are needed to handle the shutdown are no longer present. The fix is to shut down PASE sessions when we destroy CommissioneeDeviceProxy objects, and ensure that we always destroy CommissioneeDeviceProxy via ReleaseCommissioneeDevice, so we don't end up with dangling pointers to the objects. Fixes project-chip#16440 Should vastly improve, if not completely fix, project-chip#20880
bzbarsky-apple
force-pushed
the
fix-shutdown-PASE-crash
branch
from
10ef2d5
to
11830ff
Compare
|
PR #22282: Size comparison from 08830a5 to 11830ff Increases (5 builds for bl602, cc13x2_26x2, linux, telink)
Decreases (5 builds for cc13x2_26x2, esp32, linux, psoc6)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This was referenced Aug 31, 2022
woody-apple
approved these changes
Aug 31, 2022
amitnj
reviewed
Sep 4, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… outstanding. (project-chip#22282) Commissioner shutdown shuts down the CASE sessions associated with the commissioner, but not the PASE sessions. Those sessions then get shut down much later in shutdown, at which point various objects that are needed to handle the shutdown are no longer present. The fix is to shut down PASE sessions when we destroy CommissioneeDeviceProxy objects, and ensure that we always destroy CommissioneeDeviceProxy via ReleaseCommissioneeDevice, so we don't end up with dangling pointers to the objects. Fixes project-chip#16440 Should vastly improve, if not completely fix, project-chip#20880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commissioner shutdown shuts down the CASE sessions associated with the
commissioner, but not the PASE sessions. Those sessions then get shut down
much later in shutdown, at which point various objects that are needed to
handle the shutdown are no longer present.
The fix is to shut down PASE sessions when we destroy CommissioneeDeviceProxy
objects, and ensure that we always destroy CommissioneeDeviceProxy via
ReleaseCommissioneeDevice, so we don't end up with dangling pointers to the
objects.
Fixes #16440
Should vastly improve, if not completely fix,
#20880 which is a very common crash we are seeing.
Problem
Crashes during shutdown of the Matter stack.
Change overview
Clean up PASE sessions earlier in shutdown.
Testing
Should pass existing tests.