Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce constraints on UserStatus in SetUser/SetCredential commands. #21657

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Enforce constraints on UserStatus in SetUser/SetCredential commands. #21657

merged 2 commits into from
Aug 9, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #21577

Problem

See #21577

Change overview

  1. Re-enable the DL_UsersAndCredentials test.
  2. Fix the DL_UsersAndCredentials test to pass, as much as it can.
  3. Add tests for constraint checks on UserStatus in SetUser and SetCredential.
  4. Fix broken constraint checking on UserStatus.

Testing

See above.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21657: Size comparison from 9d7ec6a to f0dd55f

Increases above 0.2%:

platform target config section 9d7ec6a f0dd55f change % change
linux chip-tool-ipv6only arm64 (read only) 9849164 9969836 120672 1.2
.rodata 464364 471948 7584 1.6
.text 7757796 7868548 110752 1.4
Increases (11 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6)
platform target config section 9d7ec6a f0dd55f change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655459 655499 40 0.0
.text 553544 553584 40 0.0
shell LP_CC2652R7 (read only) 663218 663234 16 0.0
.text 577476 577492 16 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 590674 590682 8 0.0
.app_xip_area 462692 462700 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1136328 1136360 32 0.0
.text 989420 989452 32 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025542 58 0.0
.flash.text 1025484 1025542 58 0.0
m5stack (read only) 1078931 1078987 56 0.0
.flash.text 1073547 1073603 56 0.0
k32w lock k32w0+release (read/write) 701652 701684 32 0.0
.text 626688 626720 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9849164 9969836 120672 1.2
(read/write) 694033 695009 976 0.1
.data.rel.ro 639264 640240 976 0.2
.got 13624 13632 8 0.1
.rodata 464364 471948 7584 1.6
.text 7757796 7868548 110752 1.4
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177423 32 0.0
text 812612 812644 32 0.0
p6 all-clusters-app default (read/write) 1690484 1690532 48 0.0
.text 1530280 1530328 48 0.0
lock-app default (read/write) 1592252 1592300 48 0.0
.text 1436592 1436640 48 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 9d7ec6a f0dd55f change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181796 181756 -40 -0.0
shell LP_CC2652R7 (read/write) 183684 183668 -16 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9d7ec6a f0dd55f change % change
bl602 lighting-app bl602 (read/write) 1380210 1380210 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048312 1048312 0 0.0
bl602+rpc (read/write) 1425458 1425458 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079812 1079812 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670551 0 0.0
(read/write) 180832 180832 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88479 88479 0 0.0
.text 581756 581756 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636063 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558012 558012 0 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 168540 168540 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596000 596000 0 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655499 40 0.0
(read/write) 181796 181756 -40 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101435 101435 0 0.0
.text 553544 553584 40 0.0
pump-app LP_CC2652R7 (read only) 682639 682639 0 0.0
(read/write) 159736 159736 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 592908 592908 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667103 667103 0 0.0
(read/write) 175408 175408 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581832 581832 0 0.0
shell LP_CC2652R7 (read only) 663218 663234 16 0.0
(read/write) 183684 183668 -16 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85426 85426 0 0.0
.text 577476 577492 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584738 0 0.0
.app_xip_area 461540 461540 0 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590674 590682 8 0.0
.app_xip_area 462692 462700 8 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589882 589882 0 0.0
.app_xip_area 467500 467500 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096476 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961540 961540 0 0.0
BRD4161A+rpc (read/write) 1150756 1150756 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998924 998924 0 0.0
BRD4161A+rs911x (read/write) 985764 985764 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821504 821504 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136360 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989420 989452 32 0.0
window-app BRD4161A (read/write) 1088216 1088216 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951808 951808 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025542 58 0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025484 1025542 58 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078931 1078987 56 0.0
(read/write) 489240 489240 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073547 1073603 56 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644316 644316 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569832 569832 0 0.0
lock k32w0+release (read/write) 701652 701684 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626688 626720 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9849164 9969836 120672 1.2
(read/write) 694033 695009 976 0.1
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 640240 976 0.2
.dynamic 560 560 0 0.0
.got 13624 13632 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464364 471948 7584 1.6
.text 7757796 7868548 110752 1.4
thermostat-no-ble arm64 (read only) 2347804 2347804 0 0.0
(read/write) 141617 141617 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5024 5024 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970800 1970800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453560 2453560 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1416204 1416204 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177423 32 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812612 812644 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157447 0 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 801764 801764 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690484 1690532 48 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530280 1530328 48 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634692 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475208 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1554980 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403816 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592252 1592300 48 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436592 1436640 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805652 805652 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569460 569460 0 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827332 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587302 587302 0 0.0

@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

PR #21657: Size comparison from 9d7ec6a to b3e21dc

Increases above 0.2%:

platform target config section 9d7ec6a b3e21dc change % change
linux chip-tool-ipv6only arm64 (read only) 9849164 9976732 127568 1.3
.rodata 464364 472060 7696 1.7
.text 7757796 7875124 117328 1.5
Increases (29 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9d7ec6a b3e21dc change % change
bl602 lighting-app bl602 (read/write) 1380210 1380298 88 0.0
.text 1048312 1048400 88 0.0
bl602+rpc (read/write) 1425458 1425554 96 0.0
.text 1079812 1079904 92 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670647 96 0.0
.text 581756 581852 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636159 96 0.0
.text 558012 558108 96 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673123 96 0.0
.text 596000 596096 96 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655643 184 0.0
.text 553544 553728 184 0.0
shell LP_CC2652R7 (read only) 663218 663330 112 0.0
.text 577476 577588 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584842 104 0.0
.app_xip_area 461540 461644 104 0.0
lock cyw930739m2evb_01 (read/write) 590674 590778 104 0.0
.app_xip_area 462692 462796 104 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096572 96 0.0
.text 961540 961636 96 0.0
BRD4161A+rpc (read/write) 1150756 1150868 112 0.0
.text 998924 999036 112 0.0
BRD4161A+rs911x (read/write) 985764 985860 96 0.0
.text 821504 821600 96 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136488 160 0.0
.text 989420 989580 160 0.0
window-app BRD4161A (read/write) 1088216 1088312 96 0.0
.text 951808 951904 96 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025710 226 0.0
.flash.text 1025484 1025710 226 0.0
m5stack (read only) 1078931 1079107 176 0.0
.flash.text 1073547 1073723 176 0.0
k32w light k32w0+release (read/write) 644316 644460 144 0.0
.text 569832 569976 144 0.0
lock k32w0+release (read/write) 701652 701828 176 0.0
.text 626688 626864 176 0.0
linux chip-tool-ipv6only arm64 (read only) 9849164 9976732 127568 1.3
(read/write) 694033 695089 1056 0.2
.data.rel.ro 639264 640312 1048 0.2
.got 13624 13632 8 0.1
.rodata 464364 472060 7696 1.7
.text 7757796 7875124 117328 1.5
thermostat-no-ble arm64 (read only) 2347804 2349068 1264 0.1
.text 1970800 1972064 1264 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2453560 2453688 128 0.0
.text 1416204 1416332 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177551 160 0.0
text 812612 812776 164 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157575 128 0.0
text 801764 801896 132 0.0
p6 all-clusters-app default (read/write) 1690484 1690628 144 0.0
.text 1530280 1530424 144 0.0
all-clusters-minimal-app default (read/write) 1634692 1634772 80 0.0
.text 1475208 1475288 80 0.0
light-app default (read/write) 1554980 1555060 80 0.0
.text 1403816 1403896 80 0.0
lock-app default (read/write) 1592252 1592396 144 0.0
.text 1436592 1436736 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805652 805828 176 0.0
text 569460 569632 172 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827500 168 0.0
text 587302 587472 170 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section 9d7ec6a b3e21dc change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180832 180736 -96 -0.1
lock-ftd LP_CC2652R7 (read/write) 168540 168444 -96 -0.1
lock-mtd LP_CC2652R7 (read/write) 181796 181612 -184 -0.1
shell LP_CC2652R7 (read/write) 183684 183572 -112 -0.1
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9d7ec6a b3e21dc change % change
bl602 lighting-app bl602 (read/write) 1380210 1380298 88 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048312 1048400 88 0.0
bl602+rpc (read/write) 1425458 1425554 96 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079812 1079904 92 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670551 670647 96 0.0
(read/write) 180832 180736 -96 -0.1
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88479 88479 0 0.0
.text 581756 581852 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636063 636159 96 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558012 558108 96 0.0
lock-ftd LP_CC2652R7 (read only) 673027 673123 96 0.0
(read/write) 168540 168444 -96 -0.1
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596000 596096 96 0.0
lock-mtd LP_CC2652R7 (read only) 655459 655643 184 0.0
(read/write) 181796 181612 -184 -0.1
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101435 101435 0 0.0
.text 553544 553728 184 0.0
pump-app LP_CC2652R7 (read only) 682639 682639 0 0.0
(read/write) 159736 159736 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 592908 592908 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667103 667103 0 0.0
(read/write) 175408 175408 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 581832 581832 0 0.0
shell LP_CC2652R7 (read only) 663218 663330 112 0.0
(read/write) 183684 183572 -112 -0.1
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85426 85426 0 0.0
.text 577476 577588 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584738 584842 104 0.0
.app_xip_area 461540 461644 104 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590674 590778 104 0.0
.app_xip_area 462692 462796 104 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589882 589882 0 0.0
.app_xip_area 467500 467500 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096476 1096572 96 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961540 961636 96 0.0
BRD4161A+rpc (read/write) 1150756 1150868 112 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998924 999036 112 0.0
BRD4161A+rs911x (read/write) 985764 985860 96 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821504 821600 96 0.0
lock-app BRD4161A+wf200 (read/write) 1136328 1136488 160 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989420 989580 160 0.0
window-app BRD4161A (read/write) 1088216 1088312 96 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951808 951904 96 0.0
esp32 all-clusters-app c3devkit (read only) 1025484 1025710 226 0.0
(read/write) 1487234 1487234 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216864 0 0.0
.flash.text 1025484 1025710 226 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078931 1079107 176 0.0
(read/write) 489240 489240 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247260 0 0.0
.flash.text 1073547 1073723 176 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644316 644460 144 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569832 569976 144 0.0
lock k32w0+release (read/write) 701652 701828 176 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626688 626864 176 0.0
linux chip-tool-ipv6only arm64 (read only) 9849164 9976732 127568 1.3
(read/write) 694033 695089 1056 0.2
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 640312 1048 0.2
.dynamic 560 560 0 0.0
.got 13624 13632 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464364 472060 7696 1.7
.text 7757796 7875124 117328 1.5
thermostat-no-ble arm64 (read only) 2347804 2349068 1264 0.1
(read/write) 141617 141617 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5024 5024 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970800 1972064 1264 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453560 2453688 128 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1416204 1416332 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177391 1177551 160 0.0
bss 143222 143222 0 0.0
rodata 142704 142704 0 0.0
text 812612 812776 164 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157447 1157575 128 0.0
bss 142460 142460 0 0.0
rodata 134400 134400 0 0.0
text 801764 801896 132 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690484 1690628 144 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530280 1530424 144 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634772 80 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475288 80 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1555060 80 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403896 80 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592252 1592396 144 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436592 1436736 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805652 805828 176 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569460 569632 172 0.0
lighting-app tlsr9518adk80d (read/write) 827332 827500 168 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587302 587472 170 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 9, 2022 14:16
@woody-apple woody-apple merged commit 36fb7cd into project-chip:master Aug 9, 2022
@woody-apple woody-apple added the sve label Aug 9, 2022
@bzbarsky-apple bzbarsky-apple deleted the door-lock-user-status-constraints branch August 9, 2022 14:25
woody-apple pushed a commit that referenced this pull request Aug 9, 2022
@bzbarsky-apple @woody-apple
Enforce constraints on UserStatus in SetUser/SetCredential commands. (#…
1beb10c 
…21657)

* Enforce constraints on UserStatus in SetUser/SetCredential commands.

Fixes #21577

* Fix incorrect userStatus in precondition setup in cert YAMLs.
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Enforce constraints on UserStatus in SetUser/SetCredential commands. (p…
1291aa0 
…roject-chip#21657)

* Enforce constraints on UserStatus in SetUser/SetCredential commands.

Fixes project-chip#21577

* Fix incorrect userStatus in precondition setup in cert YAMLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@tehampson tehampson tehampson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved sve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Door lock Set User and Set Credential are not enforcing UserStatus constraints
3 participants
@bzbarsky-apple @tehampson @woody-apple