Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door lock Set User and Set Credential are not enforcing UserStatus constraints #21577

Closed
bzbarsky-apple opened this issue Aug 3, 2022 · 0 comments · Fixed by #21657
Closed

Door lock Set User and Set Credential are not enforcing UserStatus constraints #21577

bzbarsky-apple opened this issue Aug 3, 2022 · 0 comments · Fixed by #21657
Assignees
@bzbarsky-apple
Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Aug 3, 2022 •
edited
Loading

Problem

These commands both succeed against chip-lock-app:

chip-tool doorlock set-user 0 1 null null 0 null null 17 1 --timedInteractionTimeoutMs 1000

and

chip-tool doorlock set-credential 0 '{"credentialType": 1, "credentialIndex": 1}' "123456" null 0 null 17 1 --timedInteractionTimeoutMs 1000

but they should both fail: the UserStatus they are passing (0) is not allowed by the constraints on UserStatus for those commands (which are "must be one of null, OccupiedEnabled, OccupiedDisabled").

Proposed Solution

Need to fix the error-checking.
@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation app-clusters Application cluster work labels Aug 3, 2022
@bzbarsky-apple bzbarsky-apple self-assigned this Aug 5, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 5, 2022
@bzbarsky-apple
Enforce constraints on UserStatus in SetUser/SetCredential commands.
f0dd55f 
Fixes project-chip#21577
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 5, 2022
Merged
woody-apple pushed a commit that referenced this issue Aug 9, 2022
@bzbarsky-apple @woody-apple
Enforce constraints on UserStatus in SetUser/SetCredential commands. (#…
1beb10c 
…21657)

* Enforce constraints on UserStatus in SetUser/SetCredential commands.

Fixes #21577

* Fix incorrect userStatus in precondition setup in cert YAMLs.
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Enforce constraints on UserStatus in SetUser/SetCredential commands. (p…
1291aa0 
…roject-chip#21657)

* Enforce constraints on UserStatus in SetUser/SetCredential commands.

Fixes project-chip#21577

* Fix incorrect userStatus in precondition setup in cert YAMLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
app-clusters Application cluster work spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce constraints on UserStatus in SetUser/SetCredential commands. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple