-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some text entry leaks on Darwin. #21317
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-e4916bb51260c926708e20723dd6ed9f44c8b6aa
Jul 29, 2022
Merged
Fix some text entry leaks on Darwin. #21317
woody-apple
merged 1 commit into
sve
from
cherry-pick-e4916bb51260c926708e20723dd6ed9f44c8b6aa
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get OnNewInterface twice for the same interface. When the happens we replace the old InterfaceInfo with a new one in the map. Because our cleanup was from ~ResolveContext, that meant we leaked any allocated memory the InterfaceInfo was holding on to. The fix is to make InterfaceInfo manage its own memory and make sure we transfer the ownership properly via move constructors when inserting into the map.
PR #21317: Size comparison from d4fb03c to 6b6483a Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-e4916bb51260c926708e20723dd6ed9f44c8b6aa
branch
July 29, 2022 05:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get OnNewInterface twice for the same interface. When the happens we
replace the old InterfaceInfo with a new one in the map. Because our cleanup
was from ~ResolveContext, that meant we leaked any allocated memory the
InterfaceInfo was holding on to.
The fix is to make InterfaceInfo manage its own memory and make sure we transfer
the ownership properly via move constructors when inserting into the map.
Problem
See above.
Change overview
See above.
Testing
Ran
darwin-framework-tool pairing code
with LeakSanitizer and observed that the leak that had detected without these changes is gone.