Fix some text entry leaks on Darwin. #21286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get OnNewInterface twice for the same interface. When the happens we replace the old InterfaceInfo with a new one in the map. Because our cleanup was from ~ResolveContext, that meant we leaked any allocated memory the InterfaceInfo was holding on to. The fix is to make InterfaceInfo manage its own memory and make sure we transfer the ownership properly via move constructors when inserting into the map.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #21286: Size comparison from 5cd92fb to df101d8 Increases (5 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (3 builds for bl602, cc13x2_26x2, efr32)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
We can get OnNewInterface twice for the same interface. When the happens we replace the old InterfaceInfo with a new one in the map. Because our cleanup was from ~ResolveContext, that meant we leaked any allocated memory the InterfaceInfo was holding on to. The fix is to make InterfaceInfo manage its own memory and make sure we transfer the ownership properly via move constructors when inserting into the map.
woody-apple
added a commit
that referenced
this pull request
Jul 29, 2022
We can get OnNewInterface twice for the same interface. When the happens we replace the old InterfaceInfo with a new one in the map. Because our cleanup was from ~ResolveContext, that meant we leaked any allocated memory the InterfaceInfo was holding on to. The fix is to make InterfaceInfo manage its own memory and make sure we transfer the ownership properly via move constructors when inserting into the map. Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
We can get OnNewInterface twice for the same interface. When the happens we replace the old InterfaceInfo with a new one in the map. Because our cleanup was from ~ResolveContext, that meant we leaked any allocated memory the InterfaceInfo was holding on to. The fix is to make InterfaceInfo manage its own memory and make sure we transfer the ownership properly via move constructors when inserting into the map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get OnNewInterface twice for the same interface. When the happens we
replace the old InterfaceInfo with a new one in the map. Because our cleanup
was from ~ResolveContext, that meant we leaked any allocated memory the
InterfaceInfo was holding on to.
The fix is to make InterfaceInfo manage its own memory and make sure we transfer
the ownership properly via move constructors when inserting into the map.
Problem
See above.
Change overview
See above.
Testing
Ran
darwin-framework-tool pairing codewith LeakSanitizer and observed that the leak that had detected without these changes is gone.