Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repost "[esp32]: Do not setup DeviceInfoProvider within PlatformMgr" #21164

Merged

Conversation

woody-apple
Copy link
Contributor

Problem

What is being fixed? Examples:

  • The ESP32 platform specific implementation of DeviceInfoProvider has no difference than the common one(examples/providers/DeviceInfoProvider), we should use the common implementation of this class like other platforms since DeviceInfoProviderImpl is not platform dependent.

Currently, we call SetDiagnosticDataProvider within PaltformMgr separately on ESP32 platform. And this will cause call DiagnosticDataProvider get set up on both client and server side.

Change overview

Use common DeviceInfoProvider implementation instead of platform specific version

Please note, currently, some functions of DeviceInfoProvider does not work since storage delegate has not been setup for DeviceInfoProvider. This PR does not solve this issue either, it will be addressed in a separate PR.

Testing

How was this tested? (at least one bullet point required)

  • Confirm we can still read information from DeviceInfoProvider with this change

@woody-apple woody-apple merged commit 6545766 into sve Jul 25, 2022
@woody-apple woody-apple deleted the cherry-pick-35e13a9c69376011ee818c7affcf9c1c71e33096 branch July 25, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants