Repost "[esp32]: Do not setup DeviceInfoProvider within PlatformMgr" #21109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
andy31415
approved these changes
Jul 22, 2022
|
PR #21109: Size comparison from 27fc7b7 to 3081d4b Increases (3 builds for cc13x2_26x2, cyw30739, nrfconnect)
Decreases (5 builds for esp32, k32w, nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
previously requested changes
Jul 22, 2022
This is a temporary state, per #18236 (comment), and the ESP32 implementation is meant to be modified to use factory data. Please make sure that @dhrishi or @wqx6 approves this before merging it, since in the past they have explicitly asked for this change to not be made. |
|
As discussed, @wqx6 may be unavailable due to SVE, we can merge this PR as this uses the generic DeviceInfoProvider. We will add a follow-on PR with any platform specific required changes required on top (cc @shubhamdp). Will approve this now. |
dhrishi
approved these changes
Jul 22, 2022
|
Sorry for the later replying due to sve. I have discussed with @shubhamdp and he will add the device info(Fixed label, SupportedLocales and SupportedCalendarTypes) in generate_esp32_chip_factory_bin.py and then we will add the DeviceInfoProviderImpl for ESP32 platform. |
|
Had a discussion with @wqx6 offline and we can merge this PR. We'll add a PR for ESP32 for this along with the support for reading this configurations from the factory partition. |
shubhamdp
approved these changes
Jul 25, 2022
wqx6
approved these changes
Jul 25, 2022
bzbarsky-apple
approved these changes
Jul 25, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 25, 2022
…21164) Co-authored-by: Yufeng Wang <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Jul 26, 2022
Use common example for DeviceInfoProvider implementation. Also see this PR: project-chip#21109 Signed-off-by: Marius Tache <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Jul 29, 2022
Use common example for DeviceInfoProvider implementation. Also see this PR: project-chip#21109 Signed-off-by: Marius Tache <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Aug 5, 2022
Use common example for DeviceInfoProvider implementation. Also see this PR: project-chip#21109 Signed-off-by: Marius Tache <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Aug 16, 2022
Use common example for DeviceInfoProvider implementation. Also see this PR: project-chip#21109 Signed-off-by: Marius Tache <[email protected]>
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Aug 18, 2022
Use common example for DeviceInfoProvider implementation. Also see this PR: project-chip#21109 Signed-off-by: Marius Tache <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Currently, we call SetDiagnosticDataProvider within PaltformMgr separately on ESP32 platform. And this will cause call DiagnosticDataProvider get set up on both client and server side.
Change overview
Use common DeviceInfoProvider implementation instead of platform specific version
Please note, currently, some functions of DeviceInfoProvider does not work since storage delegate has not been setup for DeviceInfoProvider. This PR does not solve this issue either, it will be addressed in a separate PR.
Testing
How was this tested? (at least one bullet point required)