Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chef DoorLock lock/unlock functions didn't overide weak functions in door-lock-server.cpp #20538

Merged
merged 7 commits into from
Jul 12, 2022
Merged

Fix Chef DoorLock lock/unlock functions didn't overide weak functions in door-lock-server.cpp #20538

merged 7 commits into from
Jul 12, 2022

Conversation

erwinpan1
Copy link
Contributor

The functions emberAfPluginDoorLockOnDoorLockCommand and ……emberAfPluginDoorLockOnDoorLockCommand in Chef examples/chef/common/stubs.cpp didn't override the weak functions in src/app/clusters/door-lock-server/door-lock-server.cpp on ESP32 platform.
This causes user's customized Lock and Unlock codes to override weak functions never work.

Problem

What is being fixed? Examples:

  • The functions interface in stubs.cpp are not aligned with the weak functions
  • The weak functions are in the same file with the functions that call them. This seems to make the linker just link the first found (weak) function codes and will not link the strong functions in another file objects anymore.

Change overview

  • Align the strong functions' interface in stubs.cpp exactly the same with the weak functions' .
  • Move the weak functions out of door-lock-server.cpp to a new file called "door-lock-server-callback.cpp"

Testing

How was this tested? (at least one bullet point required)

  • Verified Chef with matter-door-lock-wifi.zap build on ESP32 and Linux platform with chip-tool and it works.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Jul 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20538: Size comparison from 776c06d to 6fb39d5

Increases above 0.2%:

platform target config section 776c06d 6fb39d5 change % change
linux all-clusters-app debug .init_array 1040 1048 8 0.8
all-clusters-minimal-app debug .init_array 1040 1048 8 0.8
lock-app debug .init_array 784 792 8 1.0
shell debug .init_array 920 928 8 0.9
Increases (15 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 776c06d 6fb39d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
.text 541792 541824 32 0.0
shell LP_CC2652R7 (read only) 658550 658582 32 0.0
.text 573388 573420 32 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585470 585502 32 0.0
585470 585494 24 0.0
.app_xip_area 459504 459536 32 0.0
459504 459528 24 0.0
k32w lock k32w061+release (read/write) 685348 685380 32 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.init_array 1040 1048 8 0.8
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.init_array 1040 1048 8 0.8
.text 2372754 2372850 96 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.init_array 784 792 8 1.0
.text 2121730 2121826 96 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.init_array 920 928 8 0.9
.text 2166034 2166146 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2447976 64 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174951 16 0.0
text 811332 811360 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
text 800776 800808 32 0.0
telink lighting-app tlsr9518adk80d text 581886 581888 2 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 776c06d 6fb39d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185172 185140 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 172408 172376 -32 -0.0
shell LP_CC2652R7 (read/write) 188176 188144 -32 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582582 -8 -0.0
.app_xip_area 462208 462200 -8 -0.0
telink light-switch-app tlsr9518adk80d text 565564 565562 -2 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 776c06d 6fb39d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
(read/write) 185172 185140 -32 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
(read/write) 172408 172376 -32 -0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541824 32 0.0
pump-app LP_CC2652R7 (read only) 677991 677991 0 0.0
(read/write) 164224 164224 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589076 589076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663815 0 0.0
(read/write) 178520 178520 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579040 0 0.0
shell LP_CC2652R7 (read only) 658550 658582 32 0.0
(read/write) 188176 188144 -32 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573388 573420 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579534 579534 0 0.0
.app_xip_area 458304 458304 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585470 585502 32 0.0
585470 585494 24 0.0
.app_xip_area 459504 459536 32 0.0
459504 459528 24 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582590 0 0.0
582590 582582 -8 -0.0
.app_xip_area 462208 462208 0 0.0
462208 462200 -8 -0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658592 658592 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581284 581284 0 0.0
lock k32w061+release (read/write) 685348 685380 32 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 263581 263581 0 0.0
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 265277 265277 0 0.0
.text 2372754 2372850 96 0.0
bridge-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955522 1955522 0 0.0
chip-tool debug (read only) 10303697 10303697 0 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515061 515061 0 0.0
.text 8356948 8356948 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9997684 9997684 0 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477780 477780 0 0.0
.text 7959236 7959236 0 0.0
lighting-app debug+rpc (read only) 2550953 2550953 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2167346 2167346 0 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 792 8 1.0
.rodata 228680 228680 0 0.0
.text 2121730 2121826 96 0.0
ota-provider-app debug (read only) 2322033 2322033 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955842 1955842 0 0.0
ota-requestor-app debug (read only) 2439185 2439185 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2060802 2060802 0 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 928 8 0.9
.rodata 227698 227698 0 0.0
.text 2166034 2166146 112 0.0
thermostat-no-ble arm64 (read only) 2595044 2595044 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189856 2189856 0 0.0
tv-app debug (read only) 3101905 3101905 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2665074 2665074 0 0.0
tv-casting-app debug (read only) 5565689 5565689 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343273 343273 0 0.0
.text 4944466 4944466 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447976 64 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174951 16 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811360 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800808 32 0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510192 2510192 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468456 1468456 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797092 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565564 565562 -2 -0.0
565564 565564 0 0.0
lighting-app tlsr9518adk80d (read/write) 816916 816916 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581886 581888 2 0.0

@erwinpan1 erwinpan1 closed this Jul 11, 2022
@erwinpan1 erwinpan1 reopened this Jul 11, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 11, 2022
Closed
@erwinpan1 erwinpan1 closed this Jul 11, 2022
@erwinpan1 erwinpan1 reopened this Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20538: Size comparison from 776c06d to 9324696

Increases (10 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect)
platform target config section 776c06d 9324696 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
.text 541792 541824 32 0.0
shell LP_CC2652R7 (read only) 658550 658574 24 0.0
.text 573388 573412 24 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585470 585502 32 0.0
.app_xip_area 459504 459536 32 0.0
k32w lock k32w061+release (read/write) 685348 685380 32 0.0
.text 607564 607596 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2447976 64 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174967 32 0.0
text 811332 811364 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
text 800776 800804 28 0.0
Decreases (4 builds for cc13x2_26x2, telink)
platform target config section 776c06d 9324696 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185172 185140 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 172408 172376 -32 -0.0
shell LP_CC2652R7 (read/write) 188176 188152 -24 -0.0
telink light-switch-app tlsr9518adk80d text 565564 565562 -2 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 776c06d 9324696 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
(read/write) 185172 185140 -32 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
(read/write) 172408 172376 -32 -0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541824 32 0.0
pump-app LP_CC2652R7 (read only) 677991 677991 0 0.0
(read/write) 164224 164224 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589076 589076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663815 0 0.0
(read/write) 178520 178520 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579040 0 0.0
shell LP_CC2652R7 (read only) 658550 658574 24 0.0
(read/write) 188176 188152 -24 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573388 573412 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579534 579534 0 0.0
.app_xip_area 458304 458304 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585470 585502 32 0.0
.app_xip_area 459504 459536 32 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582590 0 0.0
.app_xip_area 462208 462208 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658592 658592 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581284 581284 0 0.0
lock k32w061+release (read/write) 685348 685380 32 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607564 607596 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9997684 9997684 0 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477780 477780 0 0.0
.text 7959236 7959236 0 0.0
thermostat-no-ble arm64 (read only) 2595044 2595044 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189856 2189856 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447976 64 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174967 32 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811364 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800804 28 0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510192 2510192 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468456 1468456 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797092 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565564 565562 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816916 816916 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581886 581886 0 0.0

@restyled-io restyled-io bot mentioned this pull request Jul 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20538: Size comparison from 383ced5 to 7976654

Increases above 0.2%:

platform target config section 383ced5 7976654 change % change
linux all-clusters-app debug .init_array 1040 1048 8 0.8
all-clusters-minimal-app debug .init_array 1040 1048 8 0.8
lock-app debug .init_array 784 792 8 1.0
shell debug .init_array 920 928 8 0.9
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect)
platform target config section 383ced5 7976654 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618391 24 0.0
.text 541792 541816 24 0.0
pump-app LP_CC2652R7 (read only) 677983 677991 8 0.0
.text 589068 589076 8 0.0
shell LP_CC2652R7 (read only) 658550 658582 32 0.0
.text 573388 573420 32 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585470 585494 24 0.0
.app_xip_area 459504 459528 24 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1128496 1128544 48 0.0
.text 982228 982276 48 0.0
esp32 all-clusters-app c3devkit (read only) 1019954 1019958 4 0.0
.flash.text 1019954 1019958 4 0.0
k32w lock k32w061+release (read/write) 685348 685380 32 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.init_array 1040 1048 8 0.8
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.init_array 1040 1048 8 0.8
.text 2372754 2372850 96 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.init_array 784 792 8 1.0
.text 2121730 2121826 96 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.init_array 920 928 8 0.9
.text 2166034 2166146 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2447976 64 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174951 16 0.0
text 811332 811360 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
text 800776 800808 32 0.0
Decreases (9 builds for cc13x2_26x2, cyw30739, esp32, k32w, telink)
platform target config section 383ced5 7976654 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185172 185140 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 172408 172376 -32 -0.0
pump-app LP_CC2652R7 (read/write) 164232 164224 -8 -0.0
shell LP_CC2652R7 (read/write) 188176 188144 -32 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582582 -8 -0.0
.app_xip_area 462208 462200 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1073919 1073899 -20 -0.0
.flash.text 1068535 1068515 -20 -0.0
k32w light k32w061+release (read/write) 658592 658576 -16 -0.0
.text 581284 581268 -16 -0.0
telink light-switch-app tlsr9518adk80d text 565564 565562 -2 -0.0
lighting-app tlsr9518adk80d text 581888 581886 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 383ced5 7976654 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
(read/write) 185172 185140 -32 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
(read/write) 172408 172376 -32 -0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618391 24 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541816 24 0.0
pump-app LP_CC2652R7 (read only) 677983 677991 8 0.0
(read/write) 164232 164224 -8 -0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589068 589076 8 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663815 0 0.0
(read/write) 178520 178520 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579040 0 0.0
shell LP_CC2652R7 (read only) 658550 658582 32 0.0
(read/write) 188176 188144 -32 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573388 573420 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579534 579534 0 0.0
.app_xip_area 458304 458304 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585470 585494 24 0.0
.app_xip_area 459504 459528 24 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582590 582582 -8 -0.0
.app_xip_area 462208 462200 -8 -0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081212 1081212 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946148 946148 0 0.0
BRD4161A+rpc (read/write) 1135516 1135516 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983560 983560 0 0.0
BRD4161A+rs911x (read/write) 947692 947692 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804856 804856 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128496 1128544 48 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982228 982276 48 0.0
window-app BRD4161A (read/write) 1075012 1075012 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938444 938444 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019954 1019958 4 0.0
(read/write) 1485490 1485490 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215376 215376 0 0.0
.flash.text 1019954 1019958 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073919 1073899 -20 -0.0
(read/write) 487568 487568 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245828 245828 0 0.0
.flash.text 1068535 1068515 -20 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658592 658576 -16 -0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581284 581268 -16 -0.0
lock k32w061+release (read/write) 685348 685380 32 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 263581 263581 0 0.0
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 265277 265277 0 0.0
.text 2372754 2372850 96 0.0
bridge-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955522 1955522 0 0.0
chip-tool debug (read only) 10316433 10316433 0 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 514933 514933 0 0.0
.text 8369812 8369812 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10008356 10008356 0 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477652 477652 0 0.0
.text 7970036 7970036 0 0.0
lighting-app debug+rpc (read only) 2550953 2550953 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2167346 2167346 0 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 792 8 1.0
.rodata 228680 228680 0 0.0
.text 2121730 2121826 96 0.0
ota-provider-app debug (read only) 2322033 2322033 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955842 1955842 0 0.0
ota-requestor-app debug (read only) 2439185 2439185 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2060802 2060802 0 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 928 8 0.9
.rodata 227698 227698 0 0.0
.text 2166034 2166146 112 0.0
thermostat-no-ble arm64 (read only) 2595044 2595044 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189856 2189856 0 0.0
tv-app debug (read only) 3101905 3101905 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2665074 2665074 0 0.0
tv-casting-app debug (read only) 5577545 5577545 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343145 343145 0 0.0
.text 4956450 4956450 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447976 64 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174951 16 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811360 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800808 32 0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510192 2510192 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468456 1468456 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797092 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565564 565562 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 816916 816916 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581888 581886 -2 -0.0

@erwinpan1 erwinpan1 marked this pull request as ready for review July 11, 2022 12:30
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

PR #20538: Size comparison from 034b926 to 0ed6bce

Increases above 0.2%:

platform target config section 034b926 0ed6bce change % change
linux all-clusters-app debug .init_array 1040 1048 8 0.8
all-clusters-minimal-app debug .init_array 1040 1048 8 0.8
lock-app debug .init_array 784 792 8 1.0
shell debug .init_array 920 928 8 0.9
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, telink)
platform target config section 034b926 0ed6bce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
.text 541792 541824 32 0.0
pump-controller-app LP_CC2652R7 (read/write) 178520 178528 8 0.0
shell LP_CC2652R7 (read only) 658542 658582 40 0.0
.text 573380 573420 40 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 585478 585510 32 0.0
.app_xip_area 459504 459536 32 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1128496 1128544 48 0.0
.text 982228 982276 48 0.0
k32w lock k32w061+release (read/write) 685348 685380 32 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.init_array 1040 1048 8 0.8
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.init_array 1040 1048 8 0.8
.text 2372754 2372850 96 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.init_array 784 792 8 1.0
.text 2121730 2121826 96 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.init_array 920 928 8 0.9
.text 2166034 2166146 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447912 2447976 64 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174967 32 0.0
text 811332 811364 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
text 800776 800808 32 0.0
telink light-switch-app tlsr9518adk80d text 565562 565564 2 0.0
Decreases (6 builds for cc13x2_26x2, cyw30739, esp32)
platform target config section 034b926 0ed6bce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 185172 185140 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 172408 172376 -32 -0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663807 -8 -0.0
.text 579040 579032 -8 -0.0
shell LP_CC2652R7 (read/write) 188184 188144 -40 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582606 582598 -8 -0.0
.app_xip_area 462208 462200 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1073919 1073899 -20 -0.0
.flash.text 1068535 1068515 -20 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 034b926 0ed6bce change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666051 666083 32 0.0
(read/write) 185172 185140 -32 -0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88067 88067 0 0.0
.text 577668 577700 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 631859 631891 32 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77307 77307 0 0.0
.text 554228 554260 32 0.0
lock-ftd LP_CC2652R7 (read only) 668959 668991 32 0.0
(read/write) 172408 172376 -32 -0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76207 76207 0 0.0
.text 592272 592304 32 0.0
lock-mtd LP_CC2652R7 (read only) 618367 618399 32 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76087 76087 0 0.0
.text 541792 541824 32 0.0
pump-app LP_CC2652R7 (read only) 677991 677991 0 0.0
(read/write) 164224 164224 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88431 88431 0 0.0
.text 589076 589076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663815 663807 -8 -0.0
(read/write) 178520 178528 8 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84295 84295 0 0.0
.text 579040 579032 -8 -0.0
shell LP_CC2652R7 (read only) 658542 658582 40 0.0
(read/write) 188184 188144 -40 -0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84846 84846 0 0.0
.text 573380 573420 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579550 579550 0 0.0
.app_xip_area 458304 458304 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585478 585510 32 0.0
.app_xip_area 459504 459536 32 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582606 582598 -8 -0.0
.app_xip_area 462208 462200 -8 -0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081212 1081212 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946148 946148 0 0.0
BRD4161A+rpc (read/write) 1135516 1135516 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983560 983560 0 0.0
BRD4161A+rs911x (read/write) 947692 947692 0 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 804856 804856 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128496 1128544 48 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982228 982276 48 0.0
window-app BRD4161A (read/write) 1075012 1075012 0 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938444 938444 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019956 1019956 0 0.0
(read/write) 1485490 1485490 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215376 215376 0 0.0
.flash.text 1019956 1019956 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073919 1073899 -20 -0.0
(read/write) 487568 487568 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245828 245828 0 0.0
.flash.text 1068535 1068515 -20 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658592 658592 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581284 581284 0 0.0
lock k32w061+release (read/write) 685348 685380 32 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607564 607596 32 0.0
linux all-clusters-app debug (read only) 2960497 2960617 120 0.0
(read/write) 154744 154752 8 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 263581 263581 0 0.0
.text 2519730 2519826 96 0.0
all-clusters-minimal-app debug (read only) 2813041 2813161 120 0.0
(read/write) 146680 146688 8 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1048 8 0.8
.rodata 265277 265277 0 0.0
.text 2372754 2372850 96 0.0
bridge-app debug+rpc (read only) 2315209 2315209 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197952 197952 0 0.0
.text 1955522 1955522 0 0.0
chip-tool debug (read only) 10316433 10316433 0 0.0
(read/write) 622240 622240 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587888 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 514933 514933 0 0.0
.text 8369812 8369812 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10008356 10008356 0 0.0
(read/write) 684529 684529 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623432 0 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 477652 477652 0 0.0
.text 7970036 7970036 0 0.0
lighting-app debug+rpc (read only) 2550953 2550953 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213640 213640 0 0.0
.text 2167346 2167346 0 0.0
lock-app debug (read only) 2515553 2515673 120 0.0
(read/write) 124504 124512 8 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 792 8 1.0
.rodata 228680 228680 0 0.0
.text 2121730 2121826 96 0.0
ota-provider-app debug (read only) 2322033 2322033 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203416 203416 0 0.0
.text 1955842 1955842 0 0.0
ota-requestor-app debug (read only) 2439185 2439185 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207232 207232 0 0.0
.text 2060802 2060802 0 0.0
shell debug (read only) 2550809 2550945 136 0.0
(read/write) 141096 141104 8 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 928 8 0.9
.rodata 227698 227698 0 0.0
.text 2166034 2166146 112 0.0
thermostat-no-ble arm64 (read only) 2595044 2595044 0 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165412 165412 0 0.0
.text 2189856 2189856 0 0.0
tv-app debug (read only) 3101905 3101905 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 248928 248928 0 0.0
.text 2665074 2665074 0 0.0
tv-casting-app debug (read only) 5577545 5577545 0 0.0
(read/write) 161968 161968 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103048 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343145 343145 0 0.0
.text 4956450 4956450 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447912 2447976 64 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410556 1410620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1174967 32 0.0
bss 142900 142900 0 0.0
rodata 141808 141808 0 0.0
text 811332 811364 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155163 32 0.0
bss 142136 142136 0 0.0
rodata 133340 133340 0 0.0
text 800776 800808 32 0.0
p6 all-clusters-app default (read/write) 2565152 2565152 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1523416 1523416 0 0.0
all-clusters-minimal-app default (read/write) 2510192 2510192 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1468456 1468456 0 0.0
light-app default (read/write) 2440496 2440496 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1398760 1398760 0 0.0
lock-app default (read/write) 2467760 2467760 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426024 1426024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797092 797092 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565562 565564 2 0.0
lighting-app tlsr9518adk80d (read/write) 816916 816916 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 581888 581888 0 0.0

@github-actions
Copy link

PR #20538: Size comparison from 034b926 to 5a889a3

Increases (2 builds for nrfconnect)
platform target config section 034b926 5a889a3 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1175151 216 0.0
rodata 141808 141880 72 0.1
text 811332 811476 144 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155347 216 0.0
rodata 133340 133412 72 0.1
text 800776 800924 148 0.0
Full report (2 builds for nrfconnect)
platform target config section 034b926 5a889a3 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1174935 1175151 216 0.0
bss 142900 142900 0 0.0
rodata 141808 141880 72 0.1
text 811332 811476 144 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155131 1155347 216 0.0
bss 142136 142136 0 0.0
rodata 133340 133412 72 0.1
text 800776 800924 148 0.0

@tcarmelveilleux tcarmelveilleux merged commit d64b0fd into project-chip:master Jul 12, 2022
github-actions bot pushed a commit that referenced this pull request Jul 12, 2022
@erwinpan1 @restyled-commits @web-flow
Fix Chef DoorLock lock/unlock functions didn't overide weak functions…
261f046 
… in door-lock-server.cpp (#20538)

* Fix Chef DoorLock lock/unlock functions didn't overide weak functions in door-lock-server.cpp

* Fix restyle issue in src/app/chip_data_model.gni

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
andy31415 pushed a commit that referenced this pull request Jul 13, 2022
@woody-apple @erwinpan1 @restyled-commits
Fix Chef DoorLock lock/unlock functions didn't overide weak functions…
6efb05e 
… in door-lock-server.cpp (#20538) (#20612)

* Fix Chef DoorLock lock/unlock functions didn't overide weak functions in door-lock-server.cpp

* Fix restyle issue in src/app/chip_data_model.gni

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>

Co-authored-by: Erwin Pan <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
ajwak pushed a commit to ajwak/connectedhomeip that referenced this pull request Jul 13, 2022
@erwinpan1 @restyled-commits @ajwak
Fix Chef DoorLock lock/unlock functions didn't overide weak functions…
984b6ae 
… in door-lock-server.cpp (project-chip#20538)

* Fix Chef DoorLock lock/unlock functions didn't overide weak functions in door-lock-server.cpp

* Fix restyle issue in src/app/chip_data_model.gni

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
@wqx6 wqx6 mentioned this pull request Jul 25, 2022
Closed
@erwinpan1 erwinpan1 deleted the fix_chef_lock_function_not_overrode_weak_ones branch September 7, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjc13 gjc13 gjc13 approved these changes

@mspang mspang mspang approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erwinpan1 @CLAassistant @mspang @gjc13 @tcarmelveilleux @restyled-commits