-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate default MRP config from local MPR config #19753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
June 20, 2022 03:52
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 20, 2022 03:52
PR #19753: Size comparison from c60233d to 4e1e222 Increases (18 builds for cc13x2_26x2, efr32, esp32, linux, p6, telink)
Decreases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19753: Size comparison from c60233d to 0a57a28 Increases (18 builds for cc13x2_26x2, efr32, esp32, linux, p6, telink)
Decreases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Needs to be rebased as #19749 references GetLocalMRPConfig() |
PR #19753: Size comparison from 97e9cb2 to 2558b88 Increases (30 builds for cc13x2_26x2, efr32, esp32, k32w, linux, p6, telink)
Decreases (26 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 20, 2022
PR #19753: Size comparison from 39073b3 to aebd769 Increases (25 builds for cc13x2_26x2, esp32, linux, p6, telink)
Decreases (26 builds for cc13x2_26x2, cyw30739, k32w, linux, nrfconnect)
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 22, 2022
PR #19753: Size comparison from d1a4bb7 to 5c12d15 Increases (19 builds for cc13x2_26x2, efr32, esp32, linux, p6, telink)
Decreases (16 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 22, 2022
woody-apple
approved these changes
Jun 22, 2022
woody-apple
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #17620. GetLocalMRPConfig is used to initialize remote MRP config in some places
Current MRP parameter setup is a bit confusing, that people do not understand what's the difference between local and remote MRP config.
Change overview
This PR fixes following things
GetLocalMRPConfig
is used to initialize all local MRP configCHIP_CONFIG_MRP_LOCAL_*
CHIP_CONFIG_MRP_DEFAULT_*
==>CHIP_CONFIG_MRP_LOCAL_*
GetDefaultMRPConfig
is used to initialize all remote MRP configTesting
Refactor, verified by unit-tests