Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timed invoke for commands with no fields in darwin-framework-tool. #19435

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix timed invoke for commands with no fields in darwin-framework-tool. #19435

merged 1 commit into from
Jun 10, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

For commands with no fields we were ignoring the params struct we
allocated.

Fixes #19427

Problem

See #19427

Change overview

See above: use the params that have the timed interaction bits in them.

Testing

Ran command from #19427, verified that now we get a timed invoke.

@bzbarsky-apple
Fix timed invoke for commands with no fields in darwin-framework-tool.
ef76022 
For commands with no fields we were ignoring the params struct we
allocated.

Fixes project-chip#19427
@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19435: Size comparison from c2a869a to ef76022

Increases (2 builds for cc13x2_26x2, telink)
platform target config section c2a869a ef76022 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 157240 157248 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783120 783128 8 0.0
text 553736 553738 2 0.0
Decreases (2 builds for cc13x2_26x2, esp32)
platform target config section c2a869a ef76022 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 684679 684671 -8 -0.0
.text 585940 585932 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1008082 1008080 -2 -0.0
.flash.text 1008082 1008080 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c2a869a ef76022 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691167 691167 0 0.0
(read/write) 159688 159688 0 0.0
.bss 73748 73748 0 0.0
.data 3392 3392 0 0.0
.rodata 112391 112391 0 0.0
.text 578464 578464 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641815 641815 0 0.0
(read/write) 157220 157220 0 0.0
.bss 72972 72972 0 0.0
.data 3332 3332 0 0.0
.rodata 89439 89439 0 0.0
.text 552056 552056 0 0.0
lock-ftd LP_CC2652R7 (read only) 684679 684671 -8 -0.0
(read/write) 157240 157248 8 0.0
.bss 71700 71700 0 0.0
.data 3256 3256 0 0.0
.rodata 98255 98255 0 0.0
.text 585940 585932 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 634095 634095 0 0.0
(read/write) 144808 144808 0 0.0
.bss 67436 67436 0 0.0
.data 3256 3256 0 0.0
.rodata 98143 98143 0 0.0
.text 535460 535460 0 0.0
pump-app LP_CC2652R7 (read only) 666035 666035 0 0.0
(read/write) 176796 176796 0 0.0
.bss 71844 71844 0 0.0
.data 3292 3292 0 0.0
.rodata 86363 86363 0 0.0
.text 579188 579188 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656603 656603 0 0.0
(read/write) 186332 186332 0 0.0
.bss 71948 71948 0 0.0
.data 3252 3252 0 0.0
.rodata 84251 84251 0 0.0
.text 571868 571868 0 0.0
shell LP_CC2652R7 (read only) 683454 683454 0 0.0
(read/write) 162896 162896 0 0.0
.bss 76044 76044 0 0.0
.data 3396 3396 0 0.0
.rodata 108990 108990 0 0.0
.text 574152 574152 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 604098 604098 0 0.0
.app_xip_area 462668 462668 0 0.0
.bss 84384 84384 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 601198 601198 0 0.0
.app_xip_area 459632 459632 0 0.0
.bss 84552 84552 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600966 600966 0 0.0
.app_xip_area 460516 460516 0 0.0
.bss 83516 83516 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915672 915672 0 0.0
(read/write) 133368 133368 0 0.0
.bss 131280 131280 0 0.0
.data 2088 2088 0 0.0
.text 915664 915664 0 0.0
BRD4161A+rpc (read only) 949876 949876 0 0.0
(read/write) 150060 150060 0 0.0
.bss 147768 147768 0 0.0
.data 2292 2292 0 0.0
.text 949868 949868 0 0.0
BRD4161A+rs911x (read only) 790788 790788 0 0.0
(read/write) 129652 129652 0 0.0
.bss 127556 127556 0 0.0
.data 2096 2096 0 0.0
.text 790780 790780 0 0.0
lock-app BRD4161A+wf200 (read only) 959612 959612 0 0.0
(read/write) 129996 129996 0 0.0
.bss 127932 127932 0 0.0
.data 2064 2064 0 0.0
.text 959604 959604 0 0.0
window-app BRD4161A (read only) 900728 900728 0 0.0
(read/write) 133456 133456 0 0.0
.bss 131368 131368 0 0.0
.data 2084 2084 0 0.0
.text 900720 900720 0 0.0
esp32 all-clusters-app c3devkit (read only) 1008082 1008080 -2 -0.0
(read/write) 1482098 1482098 0 0.0
.dram0.bss 69360 69360 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212656 212656 0 0.0
.flash.text 1008082 1008080 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062899 1062899 0 0.0
(read/write) 484232 484232 0 0.0
.dram0.bss 74880 74880 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243156 243156 0 0.0
.flash.text 1057515 1057515 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 654608 654608 0 0.0
.bss 69700 69700 0 0.0
.data 2004 2004 0 0.0
.text 577104 577104 0 0.0
lock k32w061+release (read/write) 715804 715804 0 0.0
.bss 70140 70140 0 0.0
.data 1976 1976 0 0.0
.text 637888 637888 0 0.0
linux all-clusters-app debug (read only) 2894081 2894081 0 0.0
(read/write) 187928 187928 0 0.0
.bss 95744 95744 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83944 83944 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256189 256189 0 0.0
.text 2463442 2463442 0 0.0
all-clusters-minimal-app debug (read only) 2755593 2755593 0 0.0
(read/write) 179544 179544 0 0.0
.bss 94912 94912 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 257501 257501 0 0.0
.text 2325650 2325650 0 0.0
bridge-app debug+rpc (read only) 2199449 2199449 0 0.0
(read/write) 157432 157432 0 0.0
.bss 82400 82400 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65384 65384 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 188448 188448 0 0.0
.text 1852162 1852162 0 0.0
chip-tool debug (read only) 9811765 9811765 0 0.0
(read/write) 623232 623232 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590432 590432 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 506741 506741 0 0.0
.text 7864933 7864933 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9558780 9558780 0 0.0
(read/write) 689553 689553 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 625888 625888 0 0.0
.dynamic 528 528 0 0.0
.got 15032 15032 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468828 468828 0 0.0
.text 7514548 7514548 0 0.0
lighting-app debug+rpc (read only) 2483897 2483897 0 0.0
(read/write) 163040 163040 0 0.0
.bss 84224 84224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70872 70872 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 206024 206024 0 0.0
.text 2110354 2110354 0 0.0
lock-app debug (read only) 2429945 2429945 0 0.0
(read/write) 158176 158176 0 0.0
.bss 82944 82944 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67832 67832 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 220136 220136 0 0.0
.text 2047282 2047282 0 0.0
ota-provider-app debug (read only) 2205297 2205297 0 0.0
(read/write) 151136 151136 0 0.0
.bss 82400 82400 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61192 61192 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192600 192600 0 0.0
.text 1853090 1853090 0 0.0
ota-requestor-app debug (read only) 2266961 2266961 0 0.0
(read/write) 154184 154184 0 0.0
.bss 83168 83168 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195968 195968 0 0.0
.text 1907330 1907330 0 0.0
shell debug (read only) 2585673 2585673 0 0.0
(read/write) 219008 219008 0 0.0
.bss 134536 134536 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77368 77368 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228722 228722 0 0.0
.text 2198402 2198402 0 0.0
thermostat-no-ble arm64 (read only) 2545340 2545340 0 0.0
(read/write) 190961 190961 0 0.0
.bss 99313 99313 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82120 82120 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160516 160516 0 0.0
.text 2147968 2147968 0 0.0
tv-app debug (read only) 3037465 3037465 0 0.0
(read/write) 289520 289520 0 0.0
.bss 200200 200200 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78216 78216 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241664 241664 0 0.0
.text 2610690 2610690 0 0.0
tv-casting-app debug (read only) 5336633 5336633 0 0.0
(read/write) 231904 231904 0 0.0
.bss 88040 88040 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135216 135216 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 341184 341184 0 0.0
.text 4644850 4644850 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430136 2430136 0 0.0
.bss 208956 208956 0 0.0
.data 5872 5872 0 0.0
.text 1392780 1392780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192683 1192683 0 0.0
bss 141554 141554 0 0.0
rodata 154732 154732 0 0.0
text 817532 817532 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1140423 1140423 0 0.0
bss 140771 140771 0 0.0
rodata 131224 131224 0 0.0
text 789612 789612 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 143384 143384 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490536 2490536 0 0.0
.bss 142592 142592 0 0.0
.data 2752 2752 0 0.0
.text 1448800 1448800 0 0.0
light-app default (read/write) 2421904 2421904 0 0.0
.bss 135696 135696 0 0.0
.data 2600 2600 0 0.0
.text 1380168 1380168 0 0.0
lock-app default (read/write) 2442296 2442296 0 0.0
.bss 135520 135520 0 0.0
.data 2576 2576 0 0.0
.text 1400560 1400560 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 783120 783128 8 0.0
bss 70828 70828 0 0.0
noinit 40416 40416 0 0.0
text 553736 553738 2 0.0
lighting-app tlsr9518adk80d (read/write) 803132 803132 0 0.0
bss 71080 71080 0 0.0
noinit 40416 40416 0 0.0
text 570456 570456 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast tracking platform-specific fix that has review from the relevant owner anyway, but that owner is not in pullapprove's list.

@bzbarsky-apple bzbarsky-apple merged commit f8171b6 into project-chip:master Jun 10, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-tool-timed-invoke branch June 10, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krypton36 krypton36 krypton36 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@andy31415 andy31415 Awaiting requested review from andy31415

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[darwin-framework-tool] timed Interactions only work with commands that have fields
3 participants
@bzbarsky-apple @andy31415 @krypton36