Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[darwin-framework-tool] timed Interactions only work with commands that have fields #19427

Closed
dwgaul opened this issue Jun 10, 2022 · 2 comments · Fixed by #19435
Closed

[darwin-framework-tool] timed Interactions only work with commands that have fields #19427

dwgaul opened this issue Jun 10, 2022 · 2 comments · Fixed by #19435

Comments

@dwgaul
Copy link

dwgaul commented Jun 10, 2022

Noticed that while testing with darwin-framework-tool that timed interactions (adding --timedInteractionTimeoutMs 200) don't appear to be working with all commands. For example:

 ./darwin-framework-tool onoff off 0x00000000000008B9 1 --timedInteractionTimeoutMs 200

Will properly send the off command to the server, but on the server side, I do not see any TimedRequestMessage log lines.

However running:

./darwin-framework-tool doorlock lock-door 0x00000000000008B9 1 --timedInteractionTimeoutMs 200

Results in the actual timed request being sent to the server.

Not sure if this is really a big deal, but the standard Chip-tool sends a timedInteractionRequest for any command if the --timedInteractionTimeoutMs argument is used, regardless of the command.
@bzbarsky-apple
Copy link
Contributor

This is not intended behavior. It's a bug in the fix for #17998. Fix coming up.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 10, 2022
@bzbarsky-apple
Fix timed invoke for commands with no fields in darwin-framework-tool.
ef76022 
For commands with no fields we were ignoring the params struct we
allocated.

Fixes project-chip#19427
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 10, 2022
Merged
@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jun 10, 2022 •
edited
Loading

And for what it's worth, the argument was ignored for commands that have not fields, regardless of whether they require a timed invoke or not.

@bzbarsky-apple bzbarsky-apple changed the title [darwin-framework-tool] timed Interactions only work with commands that require them [darwin-framework-tool] timed Interactions only work with commands that have fields Jun 10, 2022
bzbarsky-apple added a commit that referenced this issue Jun 10, 2022
@bzbarsky-apple
Fix timed invoke for commands with no fields in darwin-framework-tool. (
f8171b6 
#19435)

For commands with no fields we were ignoring the params struct we
allocated.

Fixes #19427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dwgaul @bzbarsky-apple