Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commissioning error handling in darwin-framework-tool to be more like chip-tool. #19298

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix commissioning error handling in darwin-framework-tool to be more like chip-tool. #19298

merged 1 commit into from
Jun 8, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead. chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes #19276

Problem

See above.

Change overview

See above.

Testing

Re-enabled the disabled bits of #18521 on Darwin and it passed CI.

@bzbarsky-apple bzbarsky-apple changed the title Fix commissionig error handling in darwin-framework-tool to be more like chip-tool. Fix commissioning error handling in darwin-framework-tool to be more like chip-tool. Jun 8, 2022
@bzbarsky-apple
Fix commissioning error handling in darwin-framework-tool to be more …
c3483a0 
…like chip-tool.

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes project-chip#19276
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-tool-commissioning-errors branch from 9f57f8c to c3483a0 Compare June 8, 2022 02:31
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19298: Size comparison from fbce051 to c3483a0

Increases (1 build for cc13x2_26x2)
platform target config section fbce051 c3483a0 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 188092 188100 8 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section fbce051 c3483a0 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 655843 655835 -8 -0.0
.text 571124 571116 -8 -0.0
telink lighting-app tlsr9518adk80d text 569532 569530 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fbce051 c3483a0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690303 690303 0 0.0
(read/write) 161552 161552 0 0.0
.bss 74748 74748 0 0.0
.data 3392 3392 0 0.0
.rodata 112311 112311 0 0.0
.text 577680 577680 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640919 640919 0 0.0
(read/write) 158220 158220 0 0.0
.bss 73972 73972 0 0.0
.data 3332 3332 0 0.0
.rodata 89351 89351 0 0.0
.text 551248 551248 0 0.0
lock-ftd LP_CC2652R7 (read only) 683815 683815 0 0.0
(read/write) 159104 159104 0 0.0
.bss 72700 72700 0 0.0
.data 3256 3256 0 0.0
.rodata 98167 98167 0 0.0
.text 585164 585164 0 0.0
lock-mtd LP_CC2652R7 (read only) 633231 633231 0 0.0
(read/write) 145808 145808 0 0.0
.bss 68436 68436 0 0.0
.data 3256 3256 0 0.0
.rodata 98055 98055 0 0.0
.text 534684 534684 0 0.0
pump-app LP_CC2652R7 (read only) 665267 665267 0 0.0
(read/write) 178564 178564 0 0.0
.bss 72844 72844 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 578436 578436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655843 655835 -8 -0.0
(read/write) 188092 188100 8 0.0
.bss 72948 72948 0 0.0
.data 3252 3252 0 0.0
.rodata 84235 84235 0 0.0
.text 571124 571116 -8 -0.0
shell LP_CC2652R7 (read only) 682582 682582 0 0.0
(read/write) 164768 164768 0 0.0
.bss 77044 77044 0 0.0
.data 3396 3396 0 0.0
.rodata 108910 108910 0 0.0
.text 573360 573360 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602546 602546 0 0.0
.app_xip_area 461492 461492 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599630 599630 0 0.0
.app_xip_area 458440 458440 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599366 599366 0 0.0
.app_xip_area 459292 459292 0 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915256 915256 0 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2088 2088 0 0.0
.text 915248 915248 0 0.0
BRD4161A+rpc (read only) 949476 949476 0 0.0
(read/write) 149956 149956 0 0.0
.bss 147664 147664 0 0.0
.data 2292 2292 0 0.0
.text 949468 949468 0 0.0
BRD4161A+rs911x (read only) 790540 790540 0 0.0
(read/write) 129548 129548 0 0.0
.bss 127452 127452 0 0.0
.data 2096 2096 0 0.0
.text 790532 790532 0 0.0
lock-app BRD4161A+wf200 (read only) 958716 958716 0 0.0
(read/write) 128340 128340 0 0.0
.bss 126276 126276 0 0.0
.data 2064 2064 0 0.0
.text 958708 958708 0 0.0
window-app BRD4161A (read only) 900328 900328 0 0.0
(read/write) 133352 133352 0 0.0
.bss 131264 131264 0 0.0
.data 2084 2084 0 0.0
.text 900320 900320 0 0.0
esp32 all-clusters-app c3devkit (read only) 1008060 1008060 0 0.0
(read/write) 1481914 1481914 0 0.0
.dram0.bss 69256 69256 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212568 212568 0 0.0
.flash.text 1008060 1008060 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062859 1062859 0 0.0
(read/write) 484048 484048 0 0.0
.dram0.bss 74776 74776 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243076 243076 0 0.0
.flash.text 1057475 1057475 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653944 653944 0 0.0
.bss 70052 70052 0 0.0
.data 2004 2004 0 0.0
.text 576088 576088 0 0.0
lock k32w061+release (read/write) 715036 715036 0 0.0
.bss 70492 70492 0 0.0
.data 1976 1976 0 0.0
.text 636768 636768 0 0.0
linux all-clusters-app debug (read only) 2893417 2893417 0 0.0
(read/write) 180056 180056 0 0.0
.bss 87872 87872 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255549 255549 0 0.0
.text 2463346 2463346 0 0.0
all-clusters-minimal-app debug (read only) 2754929 2754929 0 0.0
(read/write) 171672 171672 0 0.0
.bss 87040 87040 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256861 256861 0 0.0
.text 2325554 2325554 0 0.0
bridge-app debug+rpc (read only) 2198961 2198961 0 0.0
(read/write) 149560 149560 0 0.0
.bss 74528 74528 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187904 187904 0 0.0
.text 1852146 1852146 0 0.0
chip-tool debug (read only) 9737285 9737285 0 0.0
(read/write) 608064 608064 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505405 505405 0 0.0
.text 7829877 7829877 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9474988 0 0.0
(read/write) 674321 674321 0 0.0
.bss 43729 43729 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467548 0 0.0
.text 7470420 7470420 0 0.0
lighting-app debug+rpc (read only) 2483377 2483377 0 0.0
(read/write) 155168 155168 0 0.0
.bss 76352 76352 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205480 205480 0 0.0
.text 2110306 2110306 0 0.0
lock-app debug (read only) 2429329 2429329 0 0.0
(read/write) 150304 150304 0 0.0
.bss 75072 75072 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219496 219496 0 0.0
.text 2047234 2047234 0 0.0
ota-provider-app debug (read only) 2204761 2204761 0 0.0
(read/write) 143296 143296 0 0.0
.bss 74528 74528 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192024 192024 0 0.0
.text 1853058 1853058 0 0.0
ota-requestor-app debug (read only) 2266409 2266409 0 0.0
(read/write) 146344 146344 0 0.0
.bss 75296 75296 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195392 195392 0 0.0
.text 1907282 1907282 0 0.0
shell debug (read only) 2585089 2585089 0 0.0
(read/write) 203232 203232 0 0.0
.bss 118760 118760 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228146 228146 0 0.0
.text 2198322 2198322 0 0.0
thermostat-no-ble arm64 (read only) 2544956 2544956 0 0.0
(read/write) 183153 183153 0 0.0
.bss 91457 91457 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82168 82168 0 0.0
.dynamic 528 528 0 0.0
.got 5000 5000 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160196 160196 0 0.0
.text 2147776 2147776 0 0.0
tv-app debug (read only) 3031449 3031449 0 0.0
(read/write) 281936 281936 0 0.0
.bss 192648 192648 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240736 240736 0 0.0
.text 2605650 2605650 0 0.0
tv-casting-app debug (read only) 5335041 5335041 0 0.0
(read/write) 224000 224000 0 0.0
.bss 80168 80168 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135168 135168 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340576 340576 0 0.0
.text 4643986 4643986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429848 2429848 0 0.0
.bss 202724 202724 0 0.0
.data 5872 5872 0 0.0
.text 1392492 1392492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192179 0 0.0
bss 141378 141378 0 0.0
rodata 154628 154628 0 0.0
text 817264 817264 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139891 0 0.0
bss 140595 140595 0 0.0
rodata 131124 131124 0 0.0
text 789312 789312 0 0.0
p6 all-clusters-app default (read/write) 2544880 2544880 0 0.0
.bss 137208 137208 0 0.0
.data 2808 2808 0 0.0
.text 1503144 1503144 0 0.0
all-clusters-minimal-app default (read/write) 2489744 2489744 0 0.0
.bss 136416 136416 0 0.0
.data 2752 2752 0 0.0
.text 1448008 1448008 0 0.0
light-app default (read/write) 2421656 2421656 0 0.0
.bss 129520 129520 0 0.0
.data 2600 2600 0 0.0
.text 1379920 1379920 0 0.0
lock-app default (read/write) 2441992 2441992 0 0.0
.bss 129344 129344 0 0.0
.data 2576 2576 0 0.0
.text 1400256 1400256 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781940 0 0.0
bss 70652 70652 0 0.0
noinit 40416 40416 0 0.0
text 552812 552812 0 0.0
lighting-app tlsr9518adk80d (read/write) 801952 801952 0 0.0
bss 70904 70904 0 0.0
noinit 40416 40416 0 0.0
text 569532 569530 -2 -0.0

@andy31415 andy31415 merged commit 0750d15 into project-chip:master Jun 8, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-tool-commissioning-errors branch June 8, 2022 15:08
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@bzbarsky-apple @mkardous-silabs
Fix commissioning error handling in darwin-framework-tool to be more …
7c616f0 
…like chip-tool. (project-chip#19298)

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes project-chip#19276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krypton36 krypton36 krypton36 approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MF-10 and MF-1.9 tests failes for Darwin(no-ble-asan) showing Invalid PASE parameter
3 participants
@bzbarsky-apple @andy31415 @krypton36