Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-10 and MF-1.9 tests failes for Darwin(no-ble-asan) showing Invalid PASE parameter #19276

Closed
manjunath-grl opened this issue Jun 7, 2022 · 12 comments · Fixed by #19298
Closed

Comments

@manjunath-grl
Copy link
Contributor

manjunath-grl commented Jun 7, 2022

Summary:
As per testplan TC-MF-1.10 TH start attempting to do PASE to DUT_CE and failing 20 times for Invalid payload value but Test Suites - Darwin (no-ble-asan) seems to be failing showing that Invalid PASE Parameter for PR #18521

Execution logs:
image
image
logs_1075704.zip

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl So this is for darwin-framework-tool and specifically for using PairWithCode with an incorrect code?

@manjunath-grl
Copy link
Contributor Author

@manjunath-grl So this is for darwin-framework-tool and specifically for using PairWithCode with an incorrect code?

@bzbarsky-apple yes

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl I can't reproduce this. I pulled the code for PR #18521 and ran:

./scripts/run_in_build_env.sh "./scripts/tests/run_test_suite.py --chip-tool ./out/debug/standalone/darwin-framework-tool --target Test_TC_MF_1_10 run --iterations 1 --all-clusters-app ./out/debug/standalone/chip-all-clusters-app"

and it passed fine for me....

@manjunath-grl
Copy link
Contributor Author

@manjunath-grl I can't reproduce this. I pulled the code for PR #18521 and ran:

./scripts/run_in_build_env.sh "./scripts/tests/run_test_suite.py --chip-tool ./out/debug/standalone/darwin-framework-tool --target Test_TC_MF_1_10 run --iterations 1 --all-clusters-app ./out/debug/standalone/chip-all-clusters-app"

and it passed fine for me....

I disabled the tests MF-1.10 and MF-1.9 from Darwin tests.js as per @raju-apple request can you please enable them and test it.

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jun 7, 2022

@manjunath-grl I pulled the PR before you did that, so I don't have the test disabled. It just passes.

@manjunath-grl
Copy link
Contributor Author

@manjunath-grl I pulled the PR before you did that, so I don't have the test disabled. It just passes.

It's weird because when I rebase my PR it was always failed for the test MF-1.10 that's y I made the test disabled and pushed it

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl As in the CI failed?

@bzbarsky-apple
Copy link
Contributor

Note that the bits about "invalid PASE parameter" are absolutely expected. What's not necessarily expected is a OnPairingComplete call with error after that.

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl I tried taking your PR and re-enabling the Darwin tests, then running CI and I do see it fail. I wonder why I can't reproduce that locally...

@bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple
Copy link
Contributor

Ah, interesting, that failure is in MF-1.9, not MF-1.10. All the text above claimed the failure was in MF-1.10.

But locally I can't reproduce the failure in MF-1.9 either.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 8, 2022
…ike chip-tool.

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes project-chip#19276
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 8, 2022
…like chip-tool.

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes project-chip#19276
@bzbarsky-apple
Copy link
Contributor

Still can't reproduce this locally, but the linked PR fixes it in CI...

andy31415 pushed a commit that referenced this issue Jun 8, 2022
…like chip-tool. (#19298)

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes #19276
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this issue Jun 10, 2022
…like chip-tool. (project-chip#19298)

For some reason, we sometimes get OnPairingComplete with an error in cases where
the same code (same YAML test) running on a different system gets a
OnStatusUpdate instead.  chip-tool handles OnPairingComplete with an error by
calling OnStatusUpdate, which steps through the test to the next test.
darwin-framework-tool should do the same, when running YAML tests.

Fixes project-chip#19276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants