Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix]Remove endpointid check for command path IB #19085

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[hotfix]Remove endpointid check for command path IB #19085

merged 1 commit into from
Jun 2, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Jun 2, 2022 •
edited
Loading

Problem

Master CI is broken.
#19016 has accidentally added the endpointId check in CommandPathIB, group message don't have endpointId, so we need remove this check.

Change overview

Remove this endpointId check in CommandPathIB

Testing

CI pass

@boring-cyborg boring-cyborg bot added the app label Jun 2, 2022
@restyled-io restyled-io bot mentioned this pull request Jun 2, 2022
Closed
@yunhanw-google yunhanw-google force-pushed the feature/remove_command_endpointid_check branch from 4d28e59 to 415d484 Compare June 2, 2022 07:28
@yunhanw-google yunhanw-google changed the title temporarily remove endpointid check for command path IB Remove endpointid check for command path IB Jun 2, 2022
@yunhanw-google yunhanw-google changed the title Remove endpointid check for command path IB [hotfix]Remove endpointid check for command path IB Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #19085: Size comparison from 731ae5a to 415d484

Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 731ae5a 415d484 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648563 648563 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563796 563796 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615395 615395 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541244 541244 0 0.0
lock-ftd LP_CC2652R7 (read only) 680627 680627 0 0.0
(read/write) 162196 162196 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583516 583516 0 0.0
lock-mtd LP_CC2652R7 (read only) 630027 630027 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533028 533028 0 0.0
pump-app LP_CC2652R7 (read only) 663515 663515 0 0.0
(read/write) 180220 180220 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577392 577392 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654963 654963 0 0.0
(read/write) 188884 188884 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570648 570648 0 0.0
shell LP_CC2652R7 (read only) 641578 641578 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559824 559824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602022 602022 0 0.0
.app_xip_area 461048 461048 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598162 598162 0 0.0
.app_xip_area 457060 457060 0 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596666 596666 0 0.0
.app_xip_area 456688 456688 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915432 915432 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915424 915424 0 0.0
BRD4161A+rpc (read only) 949660 949660 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949652 949652 0 0.0
BRD4161A+rs911x (read only) 787580 787580 0 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 787572 787572 0 0.0
lock-app BRD4161A+wf200 (read only) 955288 955288 0 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955280 955280 0 0.0
window-app BRD4161A (read only) 900368 900368 0 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900360 900360 0 0.0
k32w light k32w061+release (read/write) 681284 681284 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597400 597400 0 0.0
lock k32w061+release (read/write) 733316 733316 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649032 649032 0 0.0
linux all-clusters-app debug (read only) 2766161 2766161 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244509 244509 0 0.0
.text 2347698 2347698 0 0.0
all-clusters-minimal-app debug (read only) 2643281 2643281 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246429 246429 0 0.0
.text 2224290 2224290 0 0.0
bridge-app debug+rpc (read only) 2029457 2029457 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169728 169728 0 0.0
.text 1703186 1703186 0 0.0
chip-tool debug (read only) 9678749 9678749 0 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497917 497917 0 0.0
.text 7792245 7792245 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9419924 9419924 0 0.0
(read/write) 666897 666897 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604672 604672 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461372 461372 0 0.0
.text 7434708 7434708 0 0.0
lighting-app debug+rpc (read only) 2319273 2319273 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188616 188616 0 0.0
.text 1964882 1964882 0 0.0
lock-app debug (read only) 2257905 2257905 0 0.0
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201672 201672 0 0.0
.text 1895890 1895890 0 0.0
ota-provider-app debug (read only) 2065761 2065761 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181048 181048 0 0.0
.text 1725618 1725618 0 0.0
ota-requestor-app debug (read only) 2092913 2092913 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177056 177056 0 0.0
.text 1755298 1755298 0 0.0
shell debug (read only) 2571097 2571097 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224594 224594 0 0.0
.text 2187058 2187058 0 0.0
thermostat-no-ble arm64 (read only) 2366612 2366612 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148788 148788 0 0.0
.text 1988128 1988128 0 0.0
tv-app debug (read only) 2876025 2876025 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222944 222944 0 0.0
.text 2470450 2470450 0 0.0
tv-casting-app debug (read only) 5428257 5428257 0 0.0
(read/write) 226032 226032 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138792 138792 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340416 340416 0 0.0
.text 4728562 4728562 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425688 2425688 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388332 1388332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188067 1188067 0 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815120 815120 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136799 1136799 0 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788132 788132 0 0.0
p6 all-clusters-app default (read/write) 2541488 2541488 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499752 1499752 0 0.0
all-clusters-minimal-app default (read/write) 2487424 2487424 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445688 1445688 0 0.0
light-app default (read/write) 2421864 2421864 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380128 1380128 0 0.0
lock-app default (read/write) 2439912 2439912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398176 1398176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780748 780748 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552086 552086 0 0.0
lighting-app tlsr9518adk80d (read/write) 800784 800784 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568828 568828 0 0.0

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Jun 2, 2022
@andy31415 andy31415 merged commit ee638e1 into project-chip:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunhanw-google @andy31415