Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IM Message encoding #19016

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Improve IM Message encoding #19016

merged 3 commits into from
Jun 2, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented May 31, 2022 •
edited
Loading

Problem

-- Remove redundant return.
-- Add error code, CHIP_ERROR_IM_MALFORMED_EVENT_FILTER_IB
CHIP_ERROR_IM_MALFORMED_EVENT_STATUS_IB
CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_REPORT_IB
CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_STATUS_IB
CHIP_ERROR_IM_MALFORMED_COMMAND_DATA_IB
-- Remove unused CHIP_ERROR_IM_MALFORMED_WRITE_RESPONSE_MESSAGE
-- Use enum class for fields in CommandPathIB
-- Loose the schema check for missing flag in CommandPathIB, StatusResponseMessage, similar to other IB and messages for forward compatibility purpose(#18440)
-- Replace one exit style with ReturnErrorOnFailure
-- Remove IsProxy flag from subscription request message per latest spec change.
-- Rename kData to kFields in CommandDataIB per latest spec change

Change overview

See above

Testing

Existing tests cover

@boring-cyborg boring-cyborg bot added the app label May 31, 2022
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 3303e8a to 3336dc2 Compare May 31, 2022 23:34
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19016: Size comparison from eb3ac83 to 3336dc2

Increases (22 builds for cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, telink)
platform target config section eb3ac83 3336dc27 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 679731 679747 16 0.0
.text 583036 583052 16 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629155 8 0.0
.text 532556 532564 8 0.0
shell LP_CC2652R7 (read only) 641194 641210 16 0.0
.text 559712 559728 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621806 16 0.0
.app_xip_area 525368 525384 16 0.0
efr32 lock-app BRD4161A+wf200 (read only) 954460 954476 16 0.0
.text 954452 954468 16 0.0
linux all-clusters-app debug .rodata 243677 243805 128 0.1
all-clusters-minimal-app debug .rodata 245597 245725 128 0.1
bridge-app debug+rpc .rodata 168768 168864 96 0.1
chip-tool debug .rodata 496285 496349 64 0.0
chip-tool-no-interactive-ipv6only arm64 .rodata 459972 460036 64 0.0
lighting-app debug+rpc .rodata 187720 187816 96 0.1
lock-app debug .rodata 200904 201000 96 0.0
ota-provider-app debug .rodata 180184 180312 128 0.1
ota-requestor-app debug .rodata 176256 176352 96 0.1
shell debug .rodata 223794 223922 128 0.1
thermostat-no-ble arm64 .rodata 148164 148244 80 0.1
tv-app debug .rodata 222112 222240 128 0.1
tv-casting-app debug .rodata 339808 339904 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814672 814676 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135187 16 0.0
text 787672 787680 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779604 8 0.0
text 551404 551406 2 0.0
lighting-app tlsr9518adk80d text 568146 568148 2 0.0
Decreases (24 builds for cc13x2_26x2, efr32, esp32, linux, p6)
platform target config section eb3ac83 3336dc27 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163092 163076 -16 -0.0
efr32 lighting-app BRD4161A (read only) 914500 914388 -112 -0.0
.text 914492 914380 -112 -0.0
BRD4161A+rpc (read only) 948736 948624 -112 -0.0
.text 948728 948616 -112 -0.0
BRD4161A+rs911x (read only) 789360 789248 -112 -0.0
.text 789352 789240 -112 -0.0
window-app BRD4161A (read only) 899428 899316 -112 -0.0
.text 899420 899308 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005450 -32 -0.0
(read/write) 1479602 1479570 -32 -0.0
.flash.rodata 210368 210336 -32 -0.0
.flash.text 1005482 1005450 -32 -0.0
m5stack (read only) 1060687 1060663 -24 -0.0
(read/write) 481816 481792 -24 -0.0
.flash.rodata 240948 240924 -24 -0.0
.flash.text 1055303 1055279 -24 -0.0
linux all-clusters-app debug (read only) 2769745 2766433 -3312 -0.1
.text 2352114 2348674 -3440 -0.1
all-clusters-minimal-app debug (read only) 2646865 2643553 -3312 -0.1
.text 2228706 2225266 -3440 -0.2
bridge-app debug+rpc (read only) 2030057 2027433 -2624 -0.1
.text 1704770 1702050 -2720 -0.2
chip-tool debug (read only) 9669565 9666029 -3536 -0.0
.text 7784261 7780661 -3600 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9410300 -3552 -0.0
(read/write) 667105 667089 -16 -0.0
.data.rel.ro 604872 604848 -24 -0.0
.text 7429556 7425972 -3584 -0.0
lighting-app debug+rpc (read only) 2319889 2317265 -2624 -0.1
.text 1966418 1963698 -2720 -0.1
lock-app debug (read only) 2258649 2256025 -2624 -0.1
.text 1897426 1894706 -2720 -0.1
ota-provider-app debug (read only) 2067729 2065137 -2592 -0.1
.text 1728450 1725730 -2720 -0.2
ota-requestor-app debug (read only) 2096529 2093185 -3344 -0.2
.text 1759714 1756274 -3440 -0.2
shell debug (read only) 2573833 2571257 -2576 -0.1
.text 2190594 2187890 -2704 -0.1
thermostat-no-ble arm64 (read only) 2366708 2364164 -2544 -0.1
(read/write) 177441 177409 -32 -0.0
.data.rel.ro 80192 80168 -24 -0.0
.text 1988912 1986320 -2592 -0.1
tv-app debug (read only) 2876433 2872945 -3488 -0.1
.text 2471714 2468098 -3616 -0.1
tv-casting-app debug (read only) 5434009 5430505 -3504 -0.1
.text 4734562 4730962 -3600 -0.1
p6 all-clusters-app default (read/write) 2540960 1033536 -1507424 -59.3
.text 1499224 1499128 -96 -0.0
all-clusters-minimal-app default (read/write) 2486928 2486832 -96 -0.0
.text 1445192 1445096 -96 -0.0
light-app default (read/write) 2420872 2420792 -80 -0.0
.text 1379136 1379056 -80 -0.0
lock-app default (read/write) 2438912 2438816 -96 -0.0
.text 1397176 1397080 -96 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 3336dc27 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648187 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84267 0 0.0
.text 563684 563684 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615027 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73659 0 0.0
.text 541132 541132 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679747 16 0.0
(read/write) 163092 163076 -16 -0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96211 0 0.0
.text 583036 583052 16 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629155 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96099 0 0.0
.text 532556 532564 8 0.0
pump-app LP_CC2652R7 (read only) 676167 676167 0 0.0
(read/write) 167824 167824 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 88687 0 0.0
.text 586996 586996 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654087 0 0.0
(read/write) 189760 189760 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83423 0 0.0
.text 570184 570184 0 0.0
shell LP_CC2652R7 (read only) 641194 641210 16 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81250 0 0.0
.text 559712 559728 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621806 16 0.0
.app_xip_area 525368 525384 16 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630498 0 0.0
.app_xip_area 535548 535548 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914500 914388 -112 -0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914492 914380 -112 -0.0
BRD4161A+rpc (read only) 948736 948624 -112 -0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948728 948616 -112 -0.0
BRD4161A+rs911x (read only) 789360 789248 -112 -0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789240 -112 -0.0
lock-app BRD4161A+wf200 (read only) 954460 954476 16 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954468 16 0.0
window-app BRD4161A (read only) 899428 899316 -112 -0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899420 899308 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005450 -32 -0.0
(read/write) 1479602 1479570 -32 -0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210336 -32 -0.0
.flash.text 1005482 1005450 -32 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060663 -24 -0.0
(read/write) 481816 481792 -24 -0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240924 -24 -0.0
.flash.text 1055303 1055279 -24 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 680932 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597048 0 0.0
lock k32w061+release (read/write) 732420 732420 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648136 0 0.0
linux all-clusters-app debug (read only) 2769745 2766433 -3312 -0.1
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243805 128 0.1
.text 2352114 2348674 -3440 -0.1
all-clusters-minimal-app debug (read only) 2646865 2643553 -3312 -0.1
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245725 128 0.1
.text 2228706 2225266 -3440 -0.2
bridge-app debug+rpc (read only) 2030057 2027433 -2624 -0.1
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168864 96 0.1
.text 1704770 1702050 -2720 -0.2
chip-tool debug (read only) 9669565 9666029 -3536 -0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496349 64 0.0
.text 7784261 7780661 -3600 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9410300 -3552 -0.0
(read/write) 667105 667089 -16 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604848 -24 -0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 460036 64 0.0
.text 7429556 7425972 -3584 -0.0
lighting-app debug+rpc (read only) 2319889 2317265 -2624 -0.1
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187816 96 0.1
.text 1966418 1963698 -2720 -0.1
lock-app debug (read only) 2258649 2256025 -2624 -0.1
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 201000 96 0.0
.text 1897426 1894706 -2720 -0.1
ota-provider-app debug (read only) 2067729 2065137 -2592 -0.1
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180312 128 0.1
.text 1728450 1725730 -2720 -0.2
ota-requestor-app debug (read only) 2096529 2093185 -3344 -0.2
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176352 96 0.1
.text 1759714 1756274 -3440 -0.2
shell debug (read only) 2573833 2571257 -2576 -0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223922 128 0.1
.text 2190594 2187890 -2704 -0.1
thermostat-no-ble arm64 (read only) 2366708 2364164 -2544 -0.1
(read/write) 177441 177409 -32 -0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80168 -24 -0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148244 80 0.1
.text 1988912 1986320 -2592 -0.1
tv-app debug (read only) 2876433 2872945 -3488 -0.1
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222240 128 0.1
.text 2471714 2468098 -3616 -0.1
tv-casting-app debug (read only) 5434009 5430505 -3504 -0.1
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339904 96 0.0
.text 4734562 4730962 -3600 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425016 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186455 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814676 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135187 16 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787680 8 0.0
p6 all-clusters-app default (read/write) 2540960 1033536 -1507424 -59.3
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499128 -96 -0.0
all-clusters-minimal-app default (read/write) 2486928 2486832 -96 -0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445096 -96 -0.0
light-app default (read/write) 2420872 2420792 -80 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379056 -80 -0.0
lock-app default (read/write) 2438912 2438816 -96 -0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397080 -96 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779604 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551406 2 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799640 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568148 2 0.0

@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 3336dc2 to 8ba39ae Compare June 1, 2022 05:29
@restyled-io restyled-io bot mentioned this pull request Jun 1, 2022
Closed
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 8ba39ae to 5bb983d Compare June 1, 2022 05:31
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19016: Size comparison from 5148b5d to 5bb983d

Increases (24 builds for cc13x2_26x2, cyw30739, k32w, linux, nrfconnect, telink)
platform target config section 5148b5d 5bb983d change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 679995 680011 16 0.0
.text 582948 582964 16 0.0
lock-mtd LP_CC2652R7 (read only) 629411 629419 8 0.0
.text 532468 532476 8 0.0
shell LP_CC2652R7 (read only) 641362 641378 16 0.0
.text 559640 559656 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622118 622126 8 0.0
.app_xip_area 525696 525704 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570978 570986 8 0.0
.app_xip_area 466100 466108 8 0.0
k32w light k32w061+release (read/write) 680700 680716 16 0.0
.text 596816 596832 16 0.0
lock k32w061+release (read/write) 732692 732708 16 0.0
.text 648408 648424 16 0.0
linux all-clusters-app debug .rodata 244381 244509 128 0.1
all-clusters-minimal-app debug .rodata 246269 246397 128 0.1
bridge-app debug+rpc .rodata 169472 169600 128 0.1
chip-tool debug .rodata 496701 496765 64 0.0
chip-tool-no-interactive-ipv6only arm64 .rodata 460228 460276 48 0.0
lighting-app debug+rpc .rodata 188456 188552 96 0.1
lock-app debug .rodata 201576 201672 96 0.0
ota-provider-app debug .rodata 180920 181048 128 0.1
ota-requestor-app debug .rodata 176960 177056 96 0.1
shell debug .rodata 224498 224626 128 0.1
thermostat-no-ble arm64 .rodata 148708 148804 96 0.1
tv-app debug .rodata 222848 222944 96 0.0
tv-casting-app debug .rodata 340352 340448 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186795 1186811 16 0.0
text 814632 814640 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 787636 787640 4 0.0
telink light-switch-app tlsr9518adk80d text 551456 551458 2 0.0
lighting-app tlsr9518adk80d text 568198 568200 2 0.0
Decreases (20 builds for cc13x2_26x2, esp32, linux, p6)
platform target config section 5148b5d 5bb983d change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162828 162812 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1005546 1005514 -32 -0.0
(read/write) 1480002 1479986 -16 -0.0
.flash.rodata 210768 210752 -16 -0.0
.flash.text 1005546 1005514 -32 -0.0
m5stack (read only) 1060695 1060671 -24 -0.0
(read/write) 482208 482184 -24 -0.0
.flash.rodata 241340 241316 -24 -0.0
.flash.text 1055311 1055287 -24 -0.0
linux all-clusters-app debug (read only) 2769985 2766577 -3408 -0.1
.text 2351650 2348114 -3536 -0.2
all-clusters-minimal-app debug (read only) 2647073 2643665 -3408 -0.1
.text 2228242 2224706 -3536 -0.2
bridge-app debug+rpc (read only) 2030297 2027609 -2688 -0.1
.text 1704306 1701490 -2816 -0.2
chip-tool debug (read only) 9668925 9665293 -3632 -0.0
.text 7783637 7779941 -3696 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413324 9409708 -3616 -0.0
(read/write) 666929 666897 -32 -0.0
.data.rel.ro 604696 604672 -24 -0.0
.text 7429236 7425588 -3648 -0.0
lighting-app debug+rpc (read only) 2319921 2317217 -2704 -0.1
.text 1965714 1962914 -2800 -0.1
lock-app debug (read only) 2258857 2256153 -2704 -0.1
.text 1896962 1894162 -2800 -0.1
ota-provider-app debug (read only) 2068689 2066017 -2672 -0.1
.text 1728674 1725874 -2800 -0.2
ota-requestor-app debug (read only) 2096753 2093329 -3424 -0.2
.text 1759234 1755714 -3520 -0.2
shell debug (read only) 2574073 2571401 -2672 -0.1
.text 2190130 2187330 -2800 -0.1
thermostat-no-ble arm64 (read only) 2367316 2364724 -2592 -0.1
(read/write) 177457 177441 -16 -0.0
.data.rel.ro 80216 80192 -24 -0.0
.text 1988960 1986288 -2672 -0.1
tv-app debug (read only) 2876689 2873089 -3600 -0.1
.text 2471234 2467538 -3696 -0.1
tv-casting-app debug (read only) 5430313 5426713 -3600 -0.1
.text 4730706 4727010 -3696 -0.1
p6 all-clusters-app default (read/write) 2541352 2541272 -80 -0.0
.text 1499616 1499536 -80 -0.0
all-clusters-minimal-app default (read/write) 2487304 2487208 -96 -0.0
.text 1445568 1445472 -96 -0.0
light-app default (read/write) 2421248 2421152 -96 -0.0
.text 1379512 1379416 -96 -0.0
lock-app default (read/write) 2439296 2439200 -96 -0.0
.text 1397560 1397464 -96 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5148b5d 5bb983d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648347 648347 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84499 84499 0 0.0
.text 563612 563612 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615179 615179 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73883 73883 0 0.0
.text 541060 541060 0 0.0
lock-ftd LP_CC2652R7 (read only) 679995 680011 16 0.0
(read/write) 162828 162812 -16 -0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96563 96563 0 0.0
.text 582948 582964 16 0.0
lock-mtd LP_CC2652R7 (read only) 629411 629419 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96451 96451 0 0.0
.text 532468 532476 8 0.0
pump-app LP_CC2652R7 (read only) 676415 676415 0 0.0
(read/write) 167576 167576 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89039 89039 0 0.0
.text 586892 586892 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654343 654343 0 0.0
(read/write) 189504 189504 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83767 83767 0 0.0
.text 570096 570096 0 0.0
shell LP_CC2652R7 (read only) 641362 641378 16 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81490 81490 0 0.0
.text 559640 559656 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622118 622126 8 0.0
.app_xip_area 525696 525704 8 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630826 630826 0 0.0
.app_xip_area 535876 535876 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570978 570986 8 0.0
.app_xip_area 466100 466108 8 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005546 1005514 -32 -0.0
(read/write) 1480002 1479986 -16 -0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210768 210752 -16 -0.0
.flash.text 1005546 1005514 -32 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060695 1060671 -24 -0.0
(read/write) 482208 482184 -24 -0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241340 241316 -24 -0.0
.flash.text 1055311 1055287 -24 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680700 680716 16 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 596816 596832 16 0.0
lock k32w061+release (read/write) 732692 732708 16 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648408 648424 16 0.0
linux all-clusters-app debug (read only) 2769985 2766577 -3408 -0.1
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244381 244509 128 0.1
.text 2351650 2348114 -3536 -0.2
all-clusters-minimal-app debug (read only) 2647073 2643665 -3408 -0.1
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246269 246397 128 0.1
.text 2228242 2224706 -3536 -0.2
bridge-app debug+rpc (read only) 2030297 2027609 -2688 -0.1
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169472 169600 128 0.1
.text 1704306 1701490 -2816 -0.2
chip-tool debug (read only) 9668925 9665293 -3632 -0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496701 496765 64 0.0
.text 7783637 7779941 -3696 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413324 9409708 -3616 -0.0
(read/write) 666929 666897 -32 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604672 -24 -0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460228 460276 48 0.0
.text 7429236 7425588 -3648 -0.0
lighting-app debug+rpc (read only) 2319921 2317217 -2704 -0.1
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188456 188552 96 0.1
.text 1965714 1962914 -2800 -0.1
lock-app debug (read only) 2258857 2256153 -2704 -0.1
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201576 201672 96 0.0
.text 1896962 1894162 -2800 -0.1
ota-provider-app debug (read only) 2068689 2066017 -2672 -0.1
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180920 181048 128 0.1
.text 1728674 1725874 -2800 -0.2
ota-requestor-app debug (read only) 2096753 2093329 -3424 -0.2
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176960 177056 96 0.1
.text 1759234 1755714 -3520 -0.2
shell debug (read only) 2574073 2571401 -2672 -0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224498 224626 128 0.1
.text 2190130 2187330 -2800 -0.1
thermostat-no-ble arm64 (read only) 2367316 2364724 -2592 -0.1
(read/write) 177457 177441 -16 -0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80216 80192 -24 -0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148708 148804 96 0.1
.text 1988960 1986288 -2672 -0.1
tv-app debug (read only) 2876689 2873089 -3600 -0.1
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222848 222944 96 0.0
.text 2471234 2467538 -3696 -0.1
tv-casting-app debug (read only) 5430313 5426713 -3600 -0.1
(read/write) 226000 226000 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138760 138760 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340352 340448 96 0.0
.text 4730706 4727010 -3696 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424832 2424832 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387476 1387476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186795 1186811 16 0.0
bss 139280 139280 0 0.0
rodata 153980 153980 0 0.0
text 814632 814640 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135531 1135531 0 0.0
bss 138508 138508 0 0.0
rodata 130548 130548 0 0.0
text 787636 787640 4 0.0
p6 all-clusters-app default (read/write) 2541352 2541272 -80 -0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499616 1499536 -80 -0.0
all-clusters-minimal-app default (read/write) 2487304 2487208 -96 -0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445568 1445472 -96 -0.0
light-app default (read/write) 2421248 2421152 -96 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379512 1379416 -96 -0.0
lock-app default (read/write) 2439296 2439200 -96 -0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397560 1397464 -96 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780048 780048 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551456 551458 2 0.0
lighting-app tlsr9518adk80d (read/write) 800092 800092 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568198 568200 2 0.0

mrjerryjohns
mrjerryjohns approved these changes Jun 1, 2022
View reviewed changes
src/app/MessageDef/AttributeStatusIB.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/EventFilterIB.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Jun 1, 2022
View reviewed changes
src/lib/core/CHIPError.cpp Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 5bb983d to 4d230f8 Compare June 1, 2022 22:34
@restyled-io restyled-io bot mentioned this pull request Jun 1, 2022
Closed
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch 2 times, most recently from 2e0c502 to 3889f17 Compare June 1, 2022 22:51
@restyled-io restyled-io bot mentioned this pull request Jun 1, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19016: Size comparison from 131b13c to 3889f17

Increases (18 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, telink)
platform target config section 131b13c 3889f17 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
.text 533020 533028 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
linux all-clusters-app debug .rodata 244413 244445 32 0.0
all-clusters-minimal-app debug .rodata 246333 246365 32 0.0
bridge-app debug+rpc .rodata 169664 169696 32 0.0
lock-app debug .rodata 201608 201640 32 0.0
ota-provider-app debug .rodata 180984 181016 32 0.0
shell debug .rodata 224530 224562 32 0.0
thermostat-no-ble arm64 .rodata 148748 148756 8 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425624 2425688 64 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
text 788124 788132 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d text 568826 568828 2 0.0
Decreases (18 builds for cc13x2_26x2, linux, p6)
platform target config section 131b13c 3889f17 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162212 162196 -16 -0.0
linux all-clusters-app debug (read only) 2770337 2766097 -4240 -0.2
.text 2351970 2347698 -4272 -0.2
all-clusters-minimal-app debug (read only) 2647457 2643217 -4240 -0.2
.text 2228562 2224290 -4272 -0.2
bridge-app debug+rpc (read only) 2032801 2029425 -3376 -0.2
.text 1706594 1703186 -3408 -0.2
chip-tool debug (read only) 9683197 9678685 -4512 -0.0
.rodata 497885 497853 -32 -0.0
.text 7796725 7792245 -4480 -0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419876 -4136 -0.0
(read/write) 666929 666897 -32 -0.0
.data.rel.ro 604696 604672 -24 -0.0
.rodata 461364 461324 -40 -0.0
.text 7438788 7434708 -4080 -0.1
lighting-app debug+rpc (read only) 2322601 2319209 -3392 -0.1
.text 1968274 1964882 -3392 -0.2
lock-app debug (read only) 2261249 2257873 -3376 -0.1
.text 1899298 1895890 -3408 -0.2
ota-provider-app debug (read only) 2069089 2065729 -3360 -0.2
.text 1729010 1725618 -3392 -0.2
ota-requestor-app debug (read only) 2097121 2092849 -4272 -0.2
.text 1759570 1755298 -4272 -0.2
shell debug (read only) 2574441 2571065 -3376 -0.1
.text 2190466 2187058 -3408 -0.2
thermostat-no-ble arm64 (read only) 2369564 2366580 -2984 -0.1
(read/write) 177537 177505 -32 -0.0
.data.rel.ro 80288 80264 -24 -0.0
.text 1991088 1988128 -2960 -0.1
tv-app debug (read only) 2880441 2875961 -4480 -0.2
.text 2474930 2470450 -4480 -0.2
tv-casting-app debug (read only) 5432705 5428225 -4480 -0.1
.text 4733042 4728562 -4480 -0.1
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.text 1398272 1398176 -96 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 131b13c 3889f17 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
(read/write) 162212 162196 -16 -0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533020 533028 8 0.0
pump-app LP_CC2652R7 (read only) 677019 677019 0 0.0
(read/write) 166972 166972 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89107 89107 0 0.0
.text 587428 587428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654963 654963 0 0.0
(read/write) 188884 188884 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570648 570648 0 0.0
shell LP_CC2652R7 (read only) 641578 641578 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559824 559824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596666 596666 0 0.0
.app_xip_area 456688 456688 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 681284 681284 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597400 597400 0 0.0
lock k32w061+release (read/write) 733316 733316 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649032 649032 0 0.0
linux all-clusters-app debug (read only) 2770337 2766097 -4240 -0.2
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244413 244445 32 0.0
.text 2351970 2347698 -4272 -0.2
all-clusters-minimal-app debug (read only) 2647457 2643217 -4240 -0.2
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246333 246365 32 0.0
.text 2228562 2224290 -4272 -0.2
bridge-app debug+rpc (read only) 2032801 2029425 -3376 -0.2
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169664 169696 32 0.0
.text 1706594 1703186 -3408 -0.2
chip-tool debug (read only) 9683197 9678685 -4512 -0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497885 497853 -32 -0.0
.text 7796725 7792245 -4480 -0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419876 -4136 -0.0
(read/write) 666929 666897 -32 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604672 -24 -0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461364 461324 -40 -0.0
.text 7438788 7434708 -4080 -0.1
lighting-app debug+rpc (read only) 2322601 2319209 -3392 -0.1
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188552 188552 0 0.0
.text 1968274 1964882 -3392 -0.2
lock-app debug (read only) 2261249 2257873 -3376 -0.1
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201608 201640 32 0.0
.text 1899298 1895890 -3408 -0.2
ota-provider-app debug (read only) 2069089 2065729 -3360 -0.2
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180984 181016 32 0.0
.text 1729010 1725618 -3392 -0.2
ota-requestor-app debug (read only) 2097121 2092849 -4272 -0.2
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176992 176992 0 0.0
.text 1759570 1755298 -4272 -0.2
shell debug (read only) 2574441 2571065 -3376 -0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224530 224562 32 0.0
.text 2190466 2187058 -3408 -0.2
thermostat-no-ble arm64 (read only) 2369564 2366580 -2984 -0.1
(read/write) 177537 177505 -32 -0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80288 80264 -24 -0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148748 148756 8 0.0
.text 1991088 1988128 -2960 -0.1
tv-app debug (read only) 2880441 2875961 -4480 -0.2
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222880 222880 0 0.0
.text 2474930 2470450 -4480 -0.2
tv-casting-app debug (read only) 5432705 5428225 -4480 -0.1
(read/write) 226032 226032 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138792 138792 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340384 340384 0 0.0
.text 4733042 4728562 -4480 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425624 2425688 64 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788124 788132 8 0.0
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398272 1398176 -96 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d (read/write) 800784 800784 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568826 568828 2 0.0

@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 3889f17 to 4d379ef Compare June 1, 2022 23:45
@yunhanw-google
address comments
971bad7 
run codegen
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from 4d379ef to 971bad7 Compare June 2, 2022 00:10
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #19016: Size comparison from 131b13c to 971bad7

Increases (18 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, telink)
platform target config section 131b13c 971bad7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
.text 533020 533028 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
linux all-clusters-app debug .rodata 244413 244445 32 0.0
all-clusters-minimal-app debug .rodata 246333 246365 32 0.0
bridge-app debug+rpc .rodata 169664 169696 32 0.0
lock-app debug .rodata 201608 201640 32 0.0
ota-provider-app debug .rodata 180984 181016 32 0.0
shell debug .rodata 224530 224562 32 0.0
thermostat-no-ble arm64 .rodata 148748 148756 8 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425624 2425688 64 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
text 788124 788132 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d text 568826 568828 2 0.0
Decreases (20 builds for cc13x2_26x2, esp32, linux, p6)
platform target config section 131b13c 971bad7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162212 162196 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1005722 1005690 -32 -0.0
(read/write) 1480042 1480026 -16 -0.0
.flash.rodata 210808 210792 -16 -0.0
.flash.text 1005722 1005690 -32 -0.0
m5stack (read only) 1060843 1060811 -32 -0.0
(read/write) 482256 482232 -24 -0.0
.flash.rodata 241388 241364 -24 -0.0
.flash.text 1055459 1055427 -32 -0.0
linux all-clusters-app debug (read only) 2770337 2766097 -4240 -0.2
.text 2351970 2347698 -4272 -0.2
all-clusters-minimal-app debug (read only) 2647457 2643217 -4240 -0.2
.text 2228562 2224290 -4272 -0.2
bridge-app debug+rpc (read only) 2032801 2029425 -3376 -0.2
.text 1706594 1703186 -3408 -0.2
chip-tool debug (read only) 9683197 9678685 -4512 -0.0
.rodata 497885 497853 -32 -0.0
.text 7796725 7792245 -4480 -0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419876 -4136 -0.0
(read/write) 666929 666897 -32 -0.0
.data.rel.ro 604696 604672 -24 -0.0
.rodata 461364 461324 -40 -0.0
.text 7438788 7434708 -4080 -0.1
lighting-app debug+rpc (read only) 2322601 2319209 -3392 -0.1
.text 1968274 1964882 -3392 -0.2
lock-app debug (read only) 2261249 2257873 -3376 -0.1
.text 1899298 1895890 -3408 -0.2
ota-provider-app debug (read only) 2069089 2065729 -3360 -0.2
.text 1729010 1725618 -3392 -0.2
ota-requestor-app debug (read only) 2097121 2092849 -4272 -0.2
.text 1759570 1755298 -4272 -0.2
shell debug (read only) 2574441 2571065 -3376 -0.1
.text 2190466 2187058 -3408 -0.2
thermostat-no-ble arm64 (read only) 2369564 2366580 -2984 -0.1
(read/write) 177537 177505 -32 -0.0
.data.rel.ro 80288 80264 -24 -0.0
.text 1991088 1988128 -2960 -0.1
tv-app debug (read only) 2880441 2875961 -4480 -0.2
.text 2474930 2470450 -4480 -0.2
tv-casting-app debug (read only) 5432705 5428225 -4480 -0.1
.text 4733042 4728562 -4480 -0.1
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.text 1398272 1398176 -96 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 131b13c 971bad7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
(read/write) 162212 162196 -16 -0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533020 533028 8 0.0
pump-app LP_CC2652R7 (read only) 677019 677019 0 0.0
(read/write) 166972 166972 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89107 89107 0 0.0
.text 587428 587428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654963 654963 0 0.0
(read/write) 188884 188884 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570648 570648 0 0.0
shell LP_CC2652R7 (read only) 641578 641578 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559824 559824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596666 596666 0 0.0
.app_xip_area 456688 456688 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005722 1005690 -32 -0.0
(read/write) 1480042 1480026 -16 -0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210808 210792 -16 -0.0
.flash.text 1005722 1005690 -32 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060843 1060811 -32 -0.0
(read/write) 482256 482232 -24 -0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241388 241364 -24 -0.0
.flash.text 1055459 1055427 -32 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681284 681284 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597400 597400 0 0.0
lock k32w061+release (read/write) 733316 733316 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649032 649032 0 0.0
linux all-clusters-app debug (read only) 2770337 2766097 -4240 -0.2
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244413 244445 32 0.0
.text 2351970 2347698 -4272 -0.2
all-clusters-minimal-app debug (read only) 2647457 2643217 -4240 -0.2
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246333 246365 32 0.0
.text 2228562 2224290 -4272 -0.2
bridge-app debug+rpc (read only) 2032801 2029425 -3376 -0.2
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169664 169696 32 0.0
.text 1706594 1703186 -3408 -0.2
chip-tool debug (read only) 9683197 9678685 -4512 -0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497885 497853 -32 -0.0
.text 7796725 7792245 -4480 -0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419876 -4136 -0.0
(read/write) 666929 666897 -32 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604672 -24 -0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461364 461324 -40 -0.0
.text 7438788 7434708 -4080 -0.1
lighting-app debug+rpc (read only) 2322601 2319209 -3392 -0.1
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188552 188552 0 0.0
.text 1968274 1964882 -3392 -0.2
lock-app debug (read only) 2261249 2257873 -3376 -0.1
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201608 201640 32 0.0
.text 1899298 1895890 -3408 -0.2
ota-provider-app debug (read only) 2069089 2065729 -3360 -0.2
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180984 181016 32 0.0
.text 1729010 1725618 -3392 -0.2
ota-requestor-app debug (read only) 2097121 2092849 -4272 -0.2
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176992 176992 0 0.0
.text 1759570 1755298 -4272 -0.2
shell debug (read only) 2574441 2571065 -3376 -0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224530 224562 32 0.0
.text 2190466 2187058 -3408 -0.2
thermostat-no-ble arm64 (read only) 2369564 2366580 -2984 -0.1
(read/write) 177537 177505 -32 -0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80288 80264 -24 -0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148748 148756 8 0.0
.text 1991088 1988128 -2960 -0.1
tv-app debug (read only) 2880441 2875961 -4480 -0.2
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222880 222880 0 0.0
.text 2474930 2470450 -4480 -0.2
tv-casting-app debug (read only) 5432705 5428225 -4480 -0.1
(read/write) 226032 226032 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138792 138792 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340384 340384 0 0.0
.text 4733042 4728562 -4480 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425624 2425688 64 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788124 788132 8 0.0
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398272 1398176 -96 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d (read/write) 800784 800784 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568826 568828 2 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jun 2, 2022
View reviewed changes
src/lib/core/CHIPError.cpp Outdated Show resolved Hide resolved
src/lib/core/CHIPError.cpp Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/improve_im_encoding branch from e62c005 to f89f79f Compare June 2, 2022 03:53
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #19016: Size comparison from dce3d8a to f89f79f

Increases (13 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect, telink)
platform target config section dce3d8a f89f79f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
.text 533020 533028 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 461364 461372 8 0.0
thermostat-no-ble arm64 .rodata 148748 148788 40 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425624 2425688 64 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
text 788124 788132 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d text 568826 568828 2 0.0
Decreases (13 builds for cc13x2_26x2, efr32, esp32, linux, p6)
platform target config section dce3d8a f89f79f change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162212 162196 -16 -0.0
efr32 lighting-app BRD4161A (read only) 915544 915432 -112 -0.0
.text 915536 915424 -112 -0.0
BRD4161A+rpc (read only) 949772 949660 -112 -0.0
.text 949764 949652 -112 -0.0
BRD4161A+rs911x (read only) 787692 787580 -112 -0.0
.text 787684 787572 -112 -0.0
window-app BRD4161A (read only) 900480 900368 -112 -0.0
.text 900472 900360 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 1005722 1005690 -32 -0.0
(read/write) 1480042 1480026 -16 -0.0
.flash.rodata 210808 210792 -16 -0.0
.flash.text 1005722 1005690 -32 -0.0
m5stack (read only) 1060843 1060811 -32 -0.0
(read/write) 482256 482232 -24 -0.0
.flash.rodata 241388 241364 -24 -0.0
.flash.text 1055459 1055427 -32 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419924 -4088 -0.0
(read/write) 666929 666897 -32 -0.0
.data.rel.ro 604696 604672 -24 -0.0
.text 7438788 7434708 -4080 -0.1
thermostat-no-ble arm64 (read only) 2369564 2366612 -2952 -0.1
(read/write) 177537 177505 -32 -0.0
.data.rel.ro 80288 80264 -24 -0.0
.text 1991088 1988128 -2960 -0.1
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.text 1398272 1398176 -96 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section dce3d8a f89f79f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648563 16 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563780 563796 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615395 16 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541228 541244 16 0.0
lock-ftd LP_CC2652R7 (read only) 680611 680627 16 0.0
(read/write) 162212 162196 -16 -0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583500 583516 16 0.0
lock-mtd LP_CC2652R7 (read only) 630019 630027 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533020 533028 8 0.0
pump-app LP_CC2652R7 (read only) 677019 677019 0 0.0
(read/write) 166972 166972 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89107 89107 0 0.0
.text 587428 587428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654963 654963 0 0.0
(read/write) 188884 188884 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570648 570648 0 0.0
shell LP_CC2652R7 (read only) 641578 641578 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559824 559824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602014 602022 8 0.0
.app_xip_area 461040 461048 8 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598154 598162 8 0.0
.app_xip_area 457052 457060 8 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596666 596666 0 0.0
.app_xip_area 456688 456688 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915544 915432 -112 -0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915536 915424 -112 -0.0
BRD4161A+rpc (read only) 949772 949660 -112 -0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949764 949652 -112 -0.0
BRD4161A+rs911x (read only) 787692 787580 -112 -0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 787684 787572 -112 -0.0
lock-app BRD4161A+wf200 (read only) 955288 955288 0 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955280 955280 0 0.0
window-app BRD4161A (read only) 900480 900368 -112 -0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900472 900360 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 1005722 1005690 -32 -0.0
(read/write) 1480042 1480026 -16 -0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210808 210792 -16 -0.0
.flash.text 1005722 1005690 -32 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060843 1060811 -32 -0.0
(read/write) 482256 482232 -24 -0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241388 241364 -24 -0.0
.flash.text 1055459 1055427 -32 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681284 681284 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597400 597400 0 0.0
lock k32w061+release (read/write) 733316 733316 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649032 649032 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9419924 -4088 -0.0
(read/write) 666929 666897 -32 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604672 -24 -0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461364 461372 8 0.0
.text 7438788 7434708 -4080 -0.1
thermostat-no-ble arm64 (read only) 2369564 2366612 -2952 -0.1
(read/write) 177537 177505 -32 -0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80288 80264 -24 -0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148748 148788 40 0.0
.text 1991088 1988128 -2960 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425624 2425688 64 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388268 1388332 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188067 16 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815116 815120 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136799 16 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788124 788132 8 0.0
p6 all-clusters-app default (read/write) 2541584 2541488 -96 -0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499848 1499752 -96 -0.0
all-clusters-minimal-app default (read/write) 2487520 2487424 -96 -0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445784 1445688 -96 -0.0
light-app default (read/write) 2421960 2421864 -96 -0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380224 1380128 -96 -0.0
lock-app default (read/write) 2440008 2439912 -96 -0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398272 1398176 -96 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780740 780748 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552084 552086 2 0.0
lighting-app tlsr9518adk80d (read/write) 800784 800784 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568826 568828 2 0.0

@yunhanw-google yunhanw-google merged commit 731ae5a into project-chip:master Jun 2, 2022
@yunhanw-google yunhanw-google mentioned this pull request Jun 2, 2022
Merged
@yunhanw-google yunhanw-google mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @mrjerryjohns @yufengwangca @bzbarsky-apple