Implement holiday schedules #18711
Merged
Implement holiday schedules #18711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #18711: Size comparison from b36b8eb to f706473 Increases above 0.2%:
Increases (5 builds for linux)
Decreases (1 build for nrfconnect)
Full report (15 builds for linux, nrfconnect, telink)
|
Morozov-5F
force-pushed
the
feature/implement-holiday-schedules
branch
from
f706473 to
984599e
Compare
|
PR #18711: Size comparison from b36b8eb to 984599e Increases above 0.2%:
Increases (13 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6)
Decreases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Morozov-5F
force-pushed
the
feature/implement-holiday-schedules
branch
from
984599e to
1416eed
Compare
|
PR #18711: Size comparison from 7afd352 to 1416eed Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6)
Decreases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 24, 2022
andy31415
approved these changes
May 24, 2022
tehampson
approved these changes
May 24, 2022
Morozov-5F
force-pushed
the
feature/implement-holiday-schedules
branch
from
1416eed to
587ca8e
Compare
|
PR #18711: Size comparison from a3fdd05 to 587ca8e Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, p6)
Decreases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
May 26, 2022
Morozov-5F
force-pushed
the
feature/implement-holiday-schedules
branch
from
587ca8e to
a689762
Compare
|
PR #18711: Size comparison from 0219efa to a689762 Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6)
Decreases (3 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
| Zcl, | ||
| "Unable to get number of supported holiday schedules when initializing lock endpoint, defaulting to 10 [endpointId=%d]", | ||
| endpointId); | ||
| numberOfYearDaySchedulesPerUser = 10; |
There was a problem hiding this comment.
Why are we resetting numberOfYearDaySchedulesPerUser if holiday schedules are not supported?
There was a problem hiding this comment.
This was a typo, fixed here: #18860
| return false; | ||
| } | ||
|
|
||
| // appclusters, 5.2.4.22-25: year day index changes from 1 to maxNumberOfHolidaySchedules |
There was a problem hiding this comment.
What does this have to do with "year day index"?
There was a problem hiding this comment.
Just a typo, I copy pasted the comment, here's the result. I should probably revise all the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Implemented new commands for the door lock cluster related to holiday schedules:
Implemented new attribute related to holiday schedules:
Updated automated tests for the door lock schedules to include testing of the holiday schedules.
Testing