-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update door lock with latest spec changes #18280
Merged
andy31415
merged 6 commits into
project-chip:master
from
Morozov-5F:feature/update-door-lock-with-latest-spec-changes
May 13, 2022
Merged
Update door lock with latest spec changes #18280
andy31415
merged 6 commits into
project-chip:master
from
Morozov-5F:feature/update-door-lock-with-latest-spec-changes
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
May 10, 2022 20:59
pullapprove
bot
added
app
controller
darwin
examples
and removed
examples
darwin
controller
app
labels
May 10, 2022
PR #18280: Size comparison from 837b939 to 32a26fd Increases above 0.2%:
Increases (12 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (2 builds for cc13x2_26x2)
Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 11, 2022
andy31415
approved these changes
May 11, 2022
Morozov-5F
force-pushed
the
feature/update-door-lock-with-latest-spec-changes
branch
2 times, most recently
from
May 11, 2022 18:10
263568b
to
c6ba49a
Compare
PR #18280: Size comparison from ba0692c to c6ba49a Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (3 builds for cc13x2_26x2, efr32)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Morozov-5F
force-pushed
the
feature/update-door-lock-with-latest-spec-changes
branch
from
May 12, 2022 18:30
c6ba49a
to
5881fe4
Compare
PR #18280: Size comparison from 001d4fa to 5881fe4 Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (3 builds for cc13x2_26x2, efr32)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
… credentials per user - Also allowed the door lock user to have multiple credentials of the same type
Morozov-5F
force-pushed
the
feature/update-door-lock-with-latest-spec-changes
branch
from
May 13, 2022 13:32
5881fe4
to
bedb0a6
Compare
PR #18280: Size comparison from 226f5ee to bedb0a6 Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
Decreases (3 builds for cc13x2_26x2, efr32)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
DL_*
YAML tests