-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop storing breadcrumb in persistent storage. #17769
Merged
mspang
merged 1 commit into
project-chip:master
from
bzbarsky-apple:breadcrumb-non-persistent
Apr 27, 2022
Merged
Stop storing breadcrumb in persistent storage. #17769
mspang
merged 1 commit into
project-chip:master
from
bzbarsky-apple:breadcrumb-non-persistent
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
April 26, 2022 18:28
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
April 26, 2022 18:28
PR #17769: Size comparison from 6c54ab8 to 9893c6b Increases above 0.2%:
Increases (1 build for linux)
Decreases (11 builds for cyw30739, k32w, linux, p6, telink)
Full report (11 builds for cyw30739, k32w, linux, p6, telink)
|
bzbarsky-apple
force-pushed
the
breadcrumb-non-persistent
branch
from
April 26, 2022 19:00
9893c6b
to
de3b274
Compare
PR #17769: Size comparison from 6c54ab8 to de3b274 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux)
Decreases (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
breadcrumb-non-persistent
branch
from
April 26, 2022 20:40
de3b274
to
d920bbb
Compare
PR #17769: Size comparison from 6c54ab8 to d920bbb Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux)
Decreases (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Apr 26, 2022
msandstedt
approved these changes
Apr 27, 2022
bzbarsky-apple
force-pushed
the
breadcrumb-non-persistent
branch
from
April 27, 2022 17:41
d920bbb
to
543e8fe
Compare
PR #17769: Size comparison from 4b985dd to 543e8fe Increases above 0.2%:
Increases (1 build for linux)
Decreases (11 builds for cyw30739, k32w, linux, p6, telink)
Full report (11 builds for cyw30739, k32w, linux, p6, telink)
|
Breadcrumb is not supposed to be stored persistently. Also adds a bunch of tests and fixes various bugs where we were setting breadcrumbs when we should not (e.g. in error conditions) and not setting them when we should (e.g. when the fail-safe expires). Fixes project-chip#17515
bzbarsky-apple
force-pushed
the
breadcrumb-non-persistent
branch
from
April 27, 2022 18:22
543e8fe
to
566f943
Compare
PR #17769: Size comparison from 173b505 to 566f943 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux)
Decreases (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breadcrumb is not supposed to be stored persistently.
Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).
Fixes #17515
Problem
See above.
Change overview
See above.
Testing
See above about new tests, and existing tests should also test this.